Skip to contentSkip to conversation

package: add libpthsem

PATCH Superseded Gregory Hermant 4 participants 11 messages Oct 30, 2012 – Nov 13, 2012

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Gregory Hermant

author
#0 lore raw

PATCH 1/1 package: add libpthsem

Signed-off-by Gregory Hermant <[email protected]>
---
 package/Config.in                                  |    1 +
 package/libpthsem/Config.in                        |    9 +++++++
 ...bpthsem-2.0.8-fix-build-on-linux-3.x-host.patch |   28 ++++++++++++++++++++
 package/libpthsem/libpthsem.mk                     |   18 +++++++++++++
 4 files changed, 56 insertions(+)
 create mode 100644 package/libpthsem/Config.in
 create mode 100644 package/libpthsem/libpthsem-2.0.8-fix-build-on-linux-3.x-host.patch
 create mode 100644 package/libpthsem/libpthsem.mk
package/Config.in +1 -0
index ab966e0..a55a584 100644
@@ -483,6 +483,7 @@ source "package/gsl/Config.in"
 source "package/libglib2/Config.in"
 source "package/libical/Config.in"
 source "package/libnspr/Config.in"
+source "package/libpthsem/Config.in"
 source "package/libsigc/Config.in"
 source "package/libtpl/Config.in"
 source "package/liburcu/Config.in"
package/libpthsem/Config.in new file +9 -0
new file mode 100644
index 0000000..f818ee0
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_LIBPTHSEM
+	bool "libpthsem"
+	select BR2_PACKAGE_ARGP_STANDALONE
+	help
+	  GNU pth is a user mode multi threading library. pthsem is an extend
+	  version, with support for semaphores added.
+
+	  http://www.auto.tuwien.ac.at/~mkoegler/pth/
+
package/libpthsem/libpthsem-2.0.8-fix-build-on-linux-3.x-host.patch new file +28 -0
new file mode 100644
index 0000000..21fff4e
@@ -0,0 +1,28 @@
+From 2d0450bfa3fb7003098da1a7fe24c3ae140912dc Mon Sep 17 00:00:00 2001
+From: Gregory Hermant <[email protected]>
+Date: Mon, 22 Oct 2012 15:11:53 +0200
+Subject: [PATCH] pthsem build on Linux 3.x host
+
+
+Signed-off-by: Michael Markstaller <[email protected]>
+Signed-off-by: Gregory Hermant <[email protected]>
+---
+ acinclude.m4 |    2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/acinclude.m4 b/acinclude.m4
+index 03b42de..fea9bc8 100644
+--- a/acinclude.m4
++++ b/acinclude.m4
+@@ -892,6 +892,8 @@ case $PLATFORM in
+         case "x`uname -r`" in
+ changequote(, )dnl
+             x2.[23456789]* ) ;;
++changequote(, )dnl
++            x3.* ) ;;
+ changequote([, ])
+             * ) braindead=yes ;;
+         esac
+-- 
+1.7.9.5
+
package/libpthsem/libpthsem.mk new file +18 -0
new file mode 100644
index 0000000..8fdf1e1
@@ -0,0 +1,18 @@
+#############################################################
+#
+# libpthsem
+#
+#############################################################
+
+LIBPTHSEM_VERSION = 2.0.8
+LIBPTHSEM_SOURCE = pthsem_$(LIBPTHSEM_VERSION).tar.gz
+LIBPTHSEM_SITE = http://www.auto.tuwien.ac.at/~mkoegler/pth/
+LIBPTHSEM_LICENSE = LGPLv2.1+
+LIBPTHSEM_LICENSE_FILES = COPYING
+LIBPTHSEM_AUTORECONF = YES
+LIBPTHSEM_INSTALL_STAGING = YES
+LIBPTHSEM_INSTALL_TARGET = YES
+LIBPTHSEM_DEPENDENCIES = argp-standalone
+
+$(eval $(autotools-package))
+
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/1 package: add bcusdk

Signed-off-by Gregory Hermant <[email protected]>
---
 package/Config.in                                  |    1 +
 package/bcusdk/Config.in                           |   11 +++++++
 .../bcusdk-0.0.5-fix-pthsem-config-issue.patch     |   33 ++++++++++++++++++++
 package/bcusdk/bcusdk.mk                           |   21 +++++++++++++
 4 files changed, 66 insertions(+)
 create mode 100644 package/bcusdk/Config.in
 create mode 100644 package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch
 create mode 100644 package/bcusdk/bcusdk.mk
package/Config.in +1 -0
index a55a584..a6d0517 100644
@@ -541,6 +541,7 @@ menu "Networking applications"
 source "package/argus/Config.in"
 source "package/avahi/Config.in"
 source "package/axel/Config.in"
+source "package/bcusdk/Config.in"
 source "package/bluez_utils/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/boa/Config.in"
package/bcusdk/Config.in new file +11 -0
new file mode 100644
index 0000000..81d8882
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_BCUSDK
+	bool "bcusdk"
+	depends on BR2_INSTALL_LIBSTDCPP
+	select BR2_PACKAGE_LIBPTHSEM
+	help
+	  A free development environment for BCU1 and BCU2
+
+	  http://www.auto.tuwien.ac.at/~mkoegler/eib/
+
+comment "bcusdk requires a toolchain with C++ "
+	depends on !(BR2_INSTALL_LIBSTDCPP)
package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch new file +33 -0
new file mode 100644
index 0000000..82649f0
@@ -0,0 +1,33 @@
+From 8129fd135b0674017854fd722105eb0558cd3987 Mon Sep 17 00:00:00 2001
+From: Gregory Hermant <[email protected]>
+Date: Mon, 22 Oct 2012 15:29:43 +0200
+Subject: [PATCH] Prevent pthsem-config script to return bad include path.
+
+During the bcusdk configuration step, the script pthsem-config
+is used to return some parameters about the pthsem library location.
+Unfortunately this script returns host include path and prevents
+the bcusdk build.
+
+Signed-off-by: Gregory Hermant <[email protected]>
+---
+ configure |    4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/configure b/configure
+index 843e017..f77d5a9 100755
+--- a/configure
++++ b/configure
+@@ -15958,8 +15958,8 @@ if test ".$with_pth" != .no; then
+                                         if test ".$_pth_version" != .; then
+                         _pth_location=`$_dir/pthsem-config --prefix`
+                         _pth_type="installed"
+-                        _pth_cppflags=`$_dir/pthsem-config --cflags`
+-                        _pth_cflags=`$_dir/pthsem-config --cflags`
++#                       _pth_cppflags=`$_dir/pthsem-config --cflags`
++#                       _pth_cflags=`$_dir/pthsem-config --cflags`
+                         _pth_ldflags=`$_dir/pthsem-config --ldflags`
+                         _pth_libs=`$_dir/pthsem-config --libs --all`
+                         _pth_found=yes
+-- 
+1.7.9.5
+
package/bcusdk/bcusdk.mk new file +21 -0
new file mode 100644
index 0000000..9ed615d
@@ -0,0 +1,21 @@
+#############################################################
+#
+# bcusck
+#
+#############################################################
+
+BCUSDK_VERSION = 0.0.5
+BCUSDK_SOURCE = bcusdk_$(BCUSDK_VERSION).tar.gz
+BCUSDK_SITE = http://www.auto.tuwien.ac.at/~mkoegler/eib/
+BCUSDK_LICENSE = GPLv2+
+BCUSDK_LICENSE_FILES = COPYING
+BCUSDK_INSTALL_STAGING = YES
+BCUSDK_INSTALL_TARGET = YES
+BCUSDK_CONF_OPT =  --enable-onlyeibd --enable-ft12 --enable-pei16 \
+		 --enable-eibnetip --enable-eibnetipserver \
+		 --enable-eibnetiptunnel --without-pth-test \
+		 --with-pth=$(STAGING_DIR)/usr 
+
+BCUSDK_DEPENDENCIES = libpthsem
+
+$(eval $(autotools-package))
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 1/1 package: add bcusdk

Dear Gregory Hermant,

package/bcusdk/Config.in line 11

Quoted 2 lines · Gregory Hermant
package/bcusdk/Config.in new file +2 -0
+comment "bcusdk requires a toolchain with C++ "
+	depends on !(BR2_INSTALL_LIBSTDCPP)

Parenthesis not needed.

Quoted 26 lines
package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch new file +20 -0
new file mode 100644
index 0000000..82649f0
@@ -0,0 +1,33 @@
+From 8129fd135b0674017854fd722105eb0558cd3987 Mon Sep 17 00:00:00 2001
+From: Gregory Hermant <[email protected]>
+Date: Mon, 22 Oct 2012 15:29:43 +0200
+Subject: [PATCH] Prevent pthsem-config script to return bad include path.
+
+During the bcusdk configuration step, the script pthsem-config
+is used to return some parameters about the pthsem library location.
+Unfortunately this script returns host include path and prevents
+the bcusdk build.
+
+Signed-off-by: Gregory Hermant <[email protected]>
+---
+ configure |    4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/configure b/configure
+index 843e017..f77d5a9 100755
+--- a/configure
++++ b/configure
+@@ -15958,8 +15958,8 @@ if test ".$with_pth" != .no; then

package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch line 30

Quoted 10 lines
package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch new file +10 -0
+                                         if test ".$_pth_version" != .; then
+                         _pth_location=`$_dir/pthsem-config --prefix`
+                         _pth_type="installed"
+-                        _pth_cppflags=`$_dir/pthsem-config --cflags`
+-                        _pth_cflags=`$_dir/pthsem-config --cflags`
++#                       _pth_cppflags=`$_dir/pthsem-config --cflags`
++#                       _pth_cflags=`$_dir/pthsem-config --cflags`
+                         _pth_ldflags=`$_dir/pthsem-config --ldflags`
+                         _pth_libs=`$_dir/pthsem-config --libs --all`
+                         _pth_found=yes

No, that's not the way we handle this problem in Buildroot. In the pthsem package, you should mungle the pthsem-config script after installation, in order to adjust the paths. See package/libpng/libpng.mk for an example.

package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch

Quoted 7 lines
package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch new file +7 -0
+BCUSDK_VERSION = 0.0.5
+BCUSDK_SOURCE = bcusdk_$(BCUSDK_VERSION).tar.gz
+BCUSDK_SITE = http://www.auto.tuwien.ac.at/~mkoegler/eib/
+BCUSDK_LICENSE = GPLv2+
+BCUSDK_LICENSE_FILES = COPYING
+BCUSDK_INSTALL_STAGING = YES
+BCUSDK_INSTALL_TARGET = YES

_INSTALL_TARGET=YES not needed, it's the default.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#3 lore raw

PATCH 1/1 package: add linknx

In reply to Gregory Hermant
Signed-off-by Gregory Hermant <[email protected]>
---
 package/Config.in                                  |    1 +
 package/linknx/Config.in                           |   20 ++++++++++++
 .../linknx-0.0.1.30-fix-pthsem-config-issue.patch  |   33 ++++++++++++++++++++
 ...0.0.1.30-link-with-libdl-when-lua-enabled.patch |   27 ++++++++++++++++
 package/linknx/linknx.mk                           |   25 +++++++++++++++
 5 files changed, 106 insertions(+)
 create mode 100644 package/linknx/Config.in
 create mode 100644 package/linknx/linknx-0.0.1.30-fix-pthsem-config-issue.patch
 create mode 100644 package/linknx/linknx-0.0.1.30-link-with-libdl-when-lua-enabled.patch
 create mode 100644 package/linknx/linknx.mk
package/Config.in +1 -0
index a6d0517..3dd169f 100644
@@ -582,6 +582,7 @@ source "package/kismet/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/lighttpd/Config.in"
 endif
+source "package/linknx/Config.in"
 source "package/links/Config.in"
 source "package/linphone/Config.in"
 source "package/lrzsz/Config.in"
package/linknx/Config.in new file +20 -0
new file mode 100644
index 0000000..c5b49af
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_LINKNX
+	bool "linknx"
+	select BR2_PACKAGE_LIBPTHSEM
+	help
+	  Linknx is only one component of a bigger project.The goal is to get
+	  the maximum comfort and flexibility from a KNX domotic system while
+	  keeping the smallest possible resource consumption.
+
+	  http://belnet.dl.sourceforge.net/sourceforge/linknx/
+
+if BR2_PACKAGE_LINKNX
+
+config BR2_PACKAGE_LINKNX_LUA
+	bool "lua support"
+	depends on BR2_PACKAGE_LINKNX
+	select BR2_PACKAGE_LUA
+	help
+	  Enable Lua support.
+
+endif
package/linknx/linknx-0.0.1.30-fix-pthsem-config-issue.patch new file +33 -0
new file mode 100644
index 0000000..82649f0
@@ -0,0 +1,33 @@
+From 8129fd135b0674017854fd722105eb0558cd3987 Mon Sep 17 00:00:00 2001
+From: Gregory Hermant <[email protected]>
+Date: Mon, 22 Oct 2012 15:29:43 +0200
+Subject: [PATCH] Prevent pthsem-config script to return bad include path.
+
+During the bcusdk configuration step, the script pthsem-config
+is used to return some parameters about the pthsem library location.
+Unfortunately this script returns host include path and prevents
+the bcusdk build.
+
+Signed-off-by: Gregory Hermant <[email protected]>
+---
+ configure |    4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/configure b/configure
+index 843e017..f77d5a9 100755
+--- a/configure
++++ b/configure
+@@ -15958,8 +15958,8 @@ if test ".$with_pth" != .no; then
+                                         if test ".$_pth_version" != .; then
+                         _pth_location=`$_dir/pthsem-config --prefix`
+                         _pth_type="installed"
+-                        _pth_cppflags=`$_dir/pthsem-config --cflags`
+-                        _pth_cflags=`$_dir/pthsem-config --cflags`
++#                       _pth_cppflags=`$_dir/pthsem-config --cflags`
++#                       _pth_cflags=`$_dir/pthsem-config --cflags`
+                         _pth_ldflags=`$_dir/pthsem-config --ldflags`
+                         _pth_libs=`$_dir/pthsem-config --libs --all`
+                         _pth_found=yes
+-- 
+1.7.9.5
+
package/linknx/linknx-0.0.1.30-link-with-libdl-when-lua-enabled.patch new file +27 -0
new file mode 100644
index 0000000..22fea47
@@ -0,0 +1,27 @@
+From 6e377c72555ffc5f9b729292b802440f155854d7 Mon Sep 17 00:00:00 2001
+From: Gregory Hermant <[email protected]>
+Date: Mon, 29 Oct 2012 17:45:43 +0100
+Subject: [PATCH] Link with libdl when lua is enabled
+
+
+Signed-off-by: Gregory Hermant <[email protected]>
+---
+ src/Makefile.in |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/Makefile.in b/src/Makefile.in
+index 9eccf8d..90e02f0 100644
+--- a/src/Makefile.in
++++ b/src/Makefile.in
+@@ -184,7 +184,7 @@ top_build_prefix = @top_build_prefix@
+ top_builddir = @top_builddir@
+ top_srcdir = @top_srcdir@
+ AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_srcdir)/ticpp $(PTH_CPPFLAGS) $(LIBCURL_CPPFLAGS) $(LOG4CPP_CFLAGS) $(LUA_CFLAGS)
+-linknx_LDADD = ../ticpp/libticpp.a $(PTH_LDFLAGS) $(PTH_LIBS) $(LIBCURL) $(LOG4CPP_LIBS) $(LUA_LIBS) -lm
++linknx_LDADD = ../ticpp/libticpp.a $(PTH_LDFLAGS) $(PTH_LIBS) $(LIBCURL) $(LOG4CPP_LIBS) $(LUA_LIBS) -lm -ldl
+ linknx_SOURCES = linknx.cpp logger.cpp ruleserver.cpp objectcontroller.cpp eibclient.c threads.cpp timermanager.cpp  persistentstorage.cpp xmlserver.cpp smsgateway.cpp emailgateway.cpp knxconnection.cpp services.cpp suncalc.cpp  luacondition.cpp ioport.cpp ruleserver.h objectcontroller.h threads.h timermanager.h persistentstorage.h xmlserver.h smsgateway.h emailgateway.h knxconnection.h services.h suncalc.h luacondition.h ioport.h logger.h
+ all: all-am
+ 
+-- 
+1.7.9.5
+
package/linknx/linknx.mk new file +25 -0
new file mode 100644
index 0000000..219eca4
@@ -0,0 +1,25 @@
+#############################################################
+#
+# linknx
+#
+#############################################################
+
+LINKNX_VERSION = 0.0.1.30
+LINKNX_SOURCE = linknx-${LINKNX_VERSION}.tar.gz
+LINKNX_SITE = http://sourceforge.net/projects/linknx/files/linknx/linknx-0.0.1.30/
+LINKNX_LICENSE = GPLv2+
+LINKNX_LICENSE_FILES = COPYING
+LINKNX_INSTALL_STAGING = YES
+LINKNX_INSTALL_TARGET = YES
+LINKNX_CONF_OPT = --without-log4cpp --without-pth-test \
+		  --with-pth=$(STAGING_DIR)/usr
+LINKNX_DEPENDENCIES = libpthsem
+
+ifeq ($(BR2_PACKAGE_LUA),y)
+LINKNX_DEPENDENCIES += lua
+LINKNX_CONF_OPT += --with-lua
+else
+LINKNX_CONF_OPT += --without-lua
+endif
+ 
+$(eval $(autotools-package))
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH 1/1 package: add linknx

Dear Gregory Hermant,

package/linknx/Config.in line 5

Quoted 5 lines · Gregory Hermant
package/linknx/Config.in new file +5 -0
+config BR2_PACKAGE_LINKNX
+	bool "linknx"
+	select BR2_PACKAGE_LIBPTHSEM
+	help
+	  Linknx is only one component of a bigger project.The goal is to get

Nitpick: missing space after dot.

package/linknx/Config.in line 7

Quoted 2 lines
package/linknx/Config.in new file +2 -0
+	  the maximum comfort and flexibility from a KNX domotic system while
+	  keeping the smallest possible resource consumption.

This explanation is not very helpful "Linknx is only one component of a bigger project". Which bigger project?

package/linknx/Config.in line 15

Quoted 8 lines
package/linknx/Config.in new file +8 -0
+
+	  http://belnet.dl.sourceforge.net/sourceforge/linknx/
+
+if BR2_PACKAGE_LINKNX
+
+config BR2_PACKAGE_LINKNX_LUA
+	bool "lua support"
+	depends on BR2_PACKAGE_LINKNX

Dependency not needed, you are already inside a if BR2_PACKAGE_LINKNX ... endif clause.

package/linknx/Config.in line 16

Quoted 1 line
package/linknx/Config.in new file +1 -0
+	select BR2_PACKAGE_LUA

I am not sure we want a 'select' here. For things that require 'big' stuff like an interpreter, we generally use a 'depends on '.

Quoted 30 lines
package/linknx/Config.in new file +4 -0
+	help
+	  Enable Lua support.
+
+endif
package/linknx/linknx-0.0.1.30-fix-pthsem-config-issue.patch new file +20 -0
new file mode 100644
index 0000000..82649f0
@@ -0,0 +1,33 @@
+From 8129fd135b0674017854fd722105eb0558cd3987 Mon Sep 17 00:00:00 2001
+From: Gregory Hermant <[email protected]>
+Date: Mon, 22 Oct 2012 15:29:43 +0200
+Subject: [PATCH] Prevent pthsem-config script to return bad include path.
+
+During the bcusdk configuration step, the script pthsem-config
+is used to return some parameters about the pthsem library location.
+Unfortunately this script returns host include path and prevents
+the bcusdk build.
+
+Signed-off-by: Gregory Hermant <[email protected]>
+---
+ configure |    4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/configure b/configure
+index 843e017..f77d5a9 100755
+--- a/configure
++++ b/configure
+@@ -15958,8 +15958,8 @@ if test ".$with_pth" != .no; then

package/linknx/linknx-0.0.1.30-fix-pthsem-config-issue.patch line 30

Quoted 10 lines
package/linknx/linknx-0.0.1.30-fix-pthsem-config-issue.patch new file +10 -0
+                                         if test ".$_pth_version" != .; then
+                         _pth_location=`$_dir/pthsem-config --prefix`
+                         _pth_type="installed"
+-                        _pth_cppflags=`$_dir/pthsem-config --cflags`
+-                        _pth_cflags=`$_dir/pthsem-config --cflags`
++#                       _pth_cppflags=`$_dir/pthsem-config --cflags`
++#                       _pth_cflags=`$_dir/pthsem-config --cflags`
+                         _pth_ldflags=`$_dir/pthsem-config --ldflags`
+                         _pth_libs=`$_dir/pthsem-config --libs --all`
+                         _pth_found=yes

Same comment as previous package: fix pthsem-config instead of hacking all other packages on top of it.

Or even better (but takes more time): add pkg-config support to all those packages.

Quoted 24 lines
package/linknx/linknx-0.0.1.30-fix-pthsem-config-issue.patch new file +1 -0
+
package/linknx/linknx-0.0.1.30-link-with-libdl-when-lua-enabled.patch new file +17 -0
new file mode 100644
index 0000000..22fea47
@@ -0,0 +1,27 @@
+From 6e377c72555ffc5f9b729292b802440f155854d7 Mon Sep 17 00:00:00 2001
+From: Gregory Hermant <[email protected]>
+Date: Mon, 29 Oct 2012 17:45:43 +0100
+Subject: [PATCH] Link with libdl when lua is enabled
+
+
+Signed-off-by: Gregory Hermant <[email protected]>
+---
+ src/Makefile.in |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/Makefile.in b/src/Makefile.in
+index 9eccf8d..90e02f0 100644
+--- a/src/Makefile.in
++++ b/src/Makefile.in
+@@ -184,7 +184,7 @@ top_build_prefix = @top_build_prefix@
+ top_builddir = @top_builddir@

package/linknx/linknx-0.0.1.30-link-with-libdl-when-lua-enabled.patch line 27

Quoted 10 lines
package/linknx/linknx-0.0.1.30-link-with-libdl-when-lua-enabled.patch new file +10 -0
+ top_srcdir = @top_srcdir@
+ AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_srcdir)/ticpp $(PTH_CPPFLAGS) $(LIBCURL_CPPFLAGS) $(LOG4CPP_CFLAGS) $(LUA_CFLAGS)
+-linknx_LDADD = ../ticpp/libticpp.a $(PTH_LDFLAGS) $(PTH_LIBS) $(LIBCURL) $(LOG4CPP_LIBS) $(LUA_LIBS) -lm
++linknx_LDADD = ../ticpp/libticpp.a $(PTH_LDFLAGS) $(PTH_LIBS) $(LIBCURL) $(LOG4CPP_LIBS) $(LUA_LIBS) -lm -ldl
+ linknx_SOURCES = linknx.cpp logger.cpp ruleserver.cpp objectcontroller.cpp eibclient.c threads.cpp timermanager.cpp  persistentstorage.cpp xmlserver.cpp smsgateway.cpp emailgateway.cpp knxconnection.cpp services.cpp suncalc.cpp  luacondition.cpp ioport.cpp ruleserver.h objectcontroller.h threads.h timermanager.h persistentstorage.h xmlserver.h smsgateway.h emailgateway.h knxconnection.h services.h suncalc.h luacondition.h ioport.h logger.h
+ all: all-am
+ 
+-- 
+1.7.9.5
+

The Makefile.am should be patched instead, and the package marked _AUTORECONF=YES.

Quoted 6 lines
package/linknx/linknx.mk new file +0 -0
new file mode 100644
index 0000000..219eca4

package/linknx/linknx.mk line 9

Quoted 9 lines
package/linknx/linknx.mk new file +9 -0
@@ -0,0 +1,25 @@
+#############################################################
+#
+# linknx
+#
+#############################################################
+
+LINKNX_VERSION = 0.0.1.30
+LINKNX_SOURCE = linknx-${LINKNX_VERSION}.tar.gz
+LINKNX_SITE = http://sourceforge.net/projects/linknx/files/linknx/linknx-0.0.1.30/

Please use a http://downloads.sourceforge.net URL, like we do for all other Sourceforge-hosted packages.

package/linknx/linknx.mk line 13

Quoted 4 lines
package/linknx/linknx.mk new file +4 -0
+LINKNX_LICENSE = GPLv2+
+LINKNX_LICENSE_FILES = COPYING
+LINKNX_INSTALL_STAGING = YES
+LINKNX_INSTALL_TARGET = YES

Last line not needed.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#5 lore raw

PATCH 1/1 package: add linknx

In reply to Gregory Hermant

Hi Gregory,

On Tue, Oct 30, 2012 at 01:24:02PM +0100, Gregory Hermant wrote:
[...]

package/linknx/Config.in line 9

Quoted 9 lines
package/linknx/Config.in new file +9 -0
+config BR2_PACKAGE_LINKNX
+	bool "linknx"
+	select BR2_PACKAGE_LIBPTHSEM
+	help
+	  Linknx is only one component of a bigger project.The goal is to get
+	  the maximum comfort and flexibility from a KNX domotic system while
+	  keeping the smallest possible resource consumption.
+
+	  http://belnet.dl.sourceforge.net/sourceforge/linknx/

Broken link. Should probably be http://linknx.sourceforge.net/.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#6 lore raw

PATCH 1/1 package: add knxweb

In reply to Gregory Hermant
Signed-off-by Gregory Hermant <[email protected]>
---
 package/Config.in        |    1 +
 package/knxweb/Config.in |    6 ++++++
 package/knxweb/knxweb.mk |   20 ++++++++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/knxweb/Config.in
 create mode 100644 package/knxweb/knxweb.mk
package/Config.in +1 -0
index 3dd169f..2a99882 100644
@@ -579,6 +579,7 @@ source "package/ipset/Config.in"
 source "package/iptables/Config.in"
 source "package/iw/Config.in"
 source "package/kismet/Config.in"
+source "package/knxweb/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/lighttpd/Config.in"
 endif
package/knxweb/Config.in new file +6 -0
new file mode 100644
index 0000000..088e6e1
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_KNXWEB
+	bool "knxweb"
+	help
+	  KnxWeb is a graphical visualization interface for Linknx.
+
+	  http://belnet.dl.sourceforge.net/sourceforge/linknx/
package/knxweb/knxweb.mk new file +20 -0
new file mode 100644
index 0000000..5ca1760
@@ -0,0 +1,20 @@
+#############################################################
+#
+# knxweb
+#
+#############################################################
+
+KNXWEB_VERSION = 0.6.1
+KNXWEB_SOURCE = knxweb-$(KNXWEB_VERSION).tar.gz
+KNXWEB_SITE = http://sourceforge.net/projects/linknx/files/knxweb/knxweb-0.6.1/
+
+define KNXWEB_INSTALL_TARGET_CMDS
+	mkdir -p $(TARGET_DIR)/var/www
+	cp -rdpf $(@D)/* $(TARGET_DIR)/var/www
+endef
+
+define KNXWEB__UNINSTALL_TARGET_CMDS
+	rm -rf $(TARGET_DIR)/var/www/
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.7.9.5
#7 lore raw

PATCH 1/1 package: add knxweb

Dear Gregory Hermant,

Quoted 6 lines · Gregory Hermant
package/knxweb/knxweb.mk new file +0 -0
new file mode 100644
index 0000000..5ca1760

package/knxweb/knxweb.mk line 9

Quoted 9 lines
package/knxweb/knxweb.mk new file +9 -0
@@ -0,0 +1,20 @@
+#############################################################
+#
+# knxweb
+#
+#############################################################
+
+KNXWEB_VERSION = 0.6.1
+KNXWEB_SOURCE = knxweb-$(KNXWEB_VERSION).tar.gz
+KNXWEB_SITE = http://sourceforge.net/projects/linknx/files/knxweb/knxweb-0.6.1/

The tarball has no license information, this is quite annoying.

package/knxweb/knxweb.mk line 18

Quoted 8 lines
package/knxweb/knxweb.mk new file +8 -0
+define KNXWEB_INSTALL_TARGET_CMDS
+	mkdir -p $(TARGET_DIR)/var/www
+	cp -rdpf $(@D)/* $(TARGET_DIR)/var/www
+endef
+
+define KNXWEB__UNINSTALL_TARGET_CMDS
+	rm -rf $(TARGET_DIR)/var/www/
+endef

Double _ here, so this doesn't work.

However, how does this web interface works? I see a few PHP scripts, but they don't seem to be essential for the operation of the Web interface. There's a lot of JS though. Does it communicate with the server somehow?

I'm surprised that no interpreter like PHP, Lua or Python is needed here for the server side, that's why I'm asking.

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#8 lore raw

PATCH 1/1 package: add knxweb

Hi thomas,

Le 30/10/2012 13:55, Thomas Petazzoni a ?crit :

Quoted 12 lines

Dear Gregory Hermant,

Quoted 9 lines · Gregory Hermant
package/knxweb/knxweb.mk new file +3 -0
new file mode 100644
index 0000000..5ca1760
@@ -0,0 +1,20 @@
+#############################################################
+#
+# knxweb
Quoted 8 lines

package/knxweb/knxweb.mk line 9

Quoted 6 lines
package/knxweb/knxweb.mk new file +6 -0
+#
+#############################################################
+
+KNXWEB_VERSION = 0.6.1
+KNXWEB_SOURCE = knxweb-$(KNXWEB_VERSION).tar.gz
+KNXWEB_SITE = http://sourceforge.net/projects/linknx/files/knxweb/knxweb-0.6.1/

The tarball has no license information, this is quite annoying.

How can we manage this kind of package in buildroot ?

Quoted 12 lines

package/knxweb/knxweb.mk line 18

Quoted 9 lines
package/knxweb/knxweb.mk new file +8 -0
+define KNXWEB_INSTALL_TARGET_CMDS
+	mkdir -p $(TARGET_DIR)/var/www
+	cp -rdpf $(@D)/* $(TARGET_DIR)/var/www
+endef
+
+define KNXWEB__UNINSTALL_TARGET_CMDS
+	rm -rf $(TARGET_DIR)/var/www/
+endef

Double _ here, so this doesn't work.

Quoted 5 lines

However, how does this web interface works? I see a few PHP scripts, but they don't seem to be essential for the operation of the Web interface. There's a lot of JS though. Does it communicate with the server somehow?

knxweb needs a web server with PHP support.

Quoted 8 lines

I'm surprised that no interpreter like PHP, Lua or Python is needed here for the server side, that's why I'm asking.

Thanks,

Thomas

gregory

#9 lore raw

PATCH 1/1 package: add knxweb

Quoted 6 lines · Gr?gory Hermant

Hi thomas,

Le 30/10/2012 13:55, Thomas Petazzoni a ?crit :

Quoted 3 lines

Dear Gregory Hermant,

On Tue, 30 Oct 2012 13:24:03 +0100, Gregory Hermant wrote:

Quoted 15 lines
Quoted 7 lines
Quoted 7 lines
package/knxweb/knxweb.mk new file +1 -0
new file mode 100644
index 0000000..5ca1760
@@ -0,0 +1,20 @@
+#############################################################
Quoted 8 lines

package/knxweb/knxweb.mk line 9

Quoted 8 lines
package/knxweb/knxweb.mk new file +8 -0
+#
+# knxweb
+#
+#############################################################
+
+KNXWEB_VERSION = 0.6.1
+KNXWEB_SOURCE = knxweb-$(KNXWEB_VERSION).tar.gz
+KNXWEB_SITE = http://sourceforge.net/projects/linknx/files/knxweb/knxweb-0.6.1/

This URL doesn't work - it should be
http://downloads.sourceforge.net/project/linknx/knxweb/knxweb-0.6

For this case, you better refactor
KNXWEB_VERSION_MAJOR = 0.6
KNXWEB_VERSION = $(KNXWEB_VERSION_MAJOR).1
KNXWEB_SITE = http://downloads.sourceforge.net/project/linknx/knxweb/knxweb-$(KNXWEB_VERSION_MAJOR)

Note that you can remove KNXWEB_SOURCE, it is the default.

Quoted 4 lines
Quoted 2 lines

The tarball has no license information, this is quite annoying.

How can we manage this kind of package in buildroot ?

There's no solution, it's just annoying. Or actually, it's more than annoying:
since no explicit permission is given to copy the code, any use beyond simply downloading it is illegal... So I guess you should put:

KNXWEB_LICENSE = none (no permission is given)

Quoted 12 lines
Quoted 12 lines

package/knxweb/knxweb.mk line 18

Quoted 9 lines
package/knxweb/knxweb.mk new file +8 -0
+define KNXWEB_INSTALL_TARGET_CMDS
+	mkdir -p $(TARGET_DIR)/var/www
+	cp -rdpf $(@D)/* $(TARGET_DIR)/var/www
+endef
+
+define KNXWEB__UNINSTALL_TARGET_CMDS
+	rm -rf $(TARGET_DIR)/var/www/
+endef

Double _ here, so this doesn't work.

Quoted 9 lines
Quoted 5 lines

However, how does this web interface works? I see a few PHP scripts, but they don't seem to be essential for the operation of the Web interface. There's a lot of JS though. Does it communicate with the server somehow?

knxweb needs a web server with PHP support.

Quoted 2 lines

I'm surprised that no interpreter like PHP, Lua or Python is needed here for the server side, that's why I'm asking.

At the moment we can't select or depend on a web server. Selecting PHP is
possible, however, so I think you should add that to Config.in (not to the .mk file because there is no build-time dependency)

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#10 lore raw

PATCH 1/1 package: add libpthsem

In reply to Gregory Hermant

Dear Gregory Hermant,

Quoted 1 line · Gregory Hermant

+LIBPTHSEM_AUTORECONF = YES

Really needed?

Quoted 1 line

+LIBPTHSEM_INSTALL_TARGET = YES

Not needed.

Otherwise, looks good.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com