Skip to contentSkip to conversation

rtc: i.MX dryice: Add devicetree support

PATCH Superseded Sascha Hauer 2 participants 3 messages Sep 25, 2012 – Nov 2, 2012

Subsystems (3)
Device tree bindings Arm i.MX and Layerscape Real time clock (RTC)
lore
Share & tools
lore

Sascha Hauer

author maintainer
#0 lore raw

PATCH v2 1/1 rtc: i.MX dryice: Add devicetree support

Add devicetree probing, fixing some whitespace damage along the way.

Signed-off-by Sascha Hauer <[email protected]>

---

changes since v1:

- document 'intrerrupts' property as mandatory, because the driver needs it.

 Documentation/devicetree/bindings/rtc/imx-di.txt |   19 +++++++++++++++++++
 drivers/rtc/rtc-imxdi.c                          |   12 +++++++++---
 2 files changed, 28 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/rtc/imx-di.txt
Documentation/devicetree/bindings/rtc/imx-di.txt new file +19 -0
new file mode 100644
index 0000000..42b92b5
@@ -0,0 +1,19 @@
+* i.MX25 dryice Real Time Clock controller
+
+This RTC is part of the i.MX25 dryice module. Documentation for this
+unit is not publically available. This binding only makes use of the
+RTC.
+
+Required properties:
+- compatible: should be "fsl,imx25-rtc"
+- reg: physical base address of the controller and length of memory mapped
+  region.
+- interrupts: interrupt source for the dryice module
+
+Example:
+
+	dryice at 53ffc000 {
+		compatible = "fsl,imx25-dryice", "fsl,imx25-rtc";
+		reg = <0x53ffc000 0x4000>;
+		interrupts = <25>;
+	};
drivers/rtc/rtc-imxdi.c +9 -3
index 891cd6c..b2fe920 100644
@@ -493,11 +493,17 @@ static int __devexit dryice_rtc_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id of_dryice_rtc_match[] = {
+	{ .compatible = "fsl,imx25-rtc", },
+	{ },
+};
+
 static struct platform_driver dryice_rtc_driver = {
 	.driver = {
-		   .name = "imxdi_rtc",
-		   .owner = THIS_MODULE,
-		   },
+		.name = "imxdi_rtc",
+		.owner = THIS_MODULE,
+		.of_match_table = of_dryice_rtc_match,
+	},
 	.remove = __devexit_p(dryice_rtc_remove),
 };
Signature · 1 line
1.7.10.4
author maintainer
#2 lore raw

PATCH v2 1/1 rtc: i.MX dryice: Add devicetree support

In reply to Sascha Hauer

Alessandro,

Everything fine with this patch? If yes, could you apply it?

Thanks
Sascha

Quoted 68 lines · Sascha Hauer

Add devicetree probing, fixing some whitespace damage along the way.

Signed-off-by Sascha Hauer <[email protected]>

---

changes since v1:

- document 'intrerrupts' property as mandatory, because the driver needs it.

 Documentation/devicetree/bindings/rtc/imx-di.txt |   19 +++++++++++++++++++
 drivers/rtc/rtc-imxdi.c                          |   12 +++++++++---
 2 files changed, 28 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/rtc/imx-di.txt
Documentation/devicetree/bindings/rtc/imx-di.txt new file +19 -0
new file mode 100644
index 0000000..42b92b5
@@ -0,0 +1,19 @@
+* i.MX25 dryice Real Time Clock controller
+
+This RTC is part of the i.MX25 dryice module. Documentation for this
+unit is not publically available. This binding only makes use of the
+RTC.
+
+Required properties:
+- compatible: should be "fsl,imx25-rtc"
+- reg: physical base address of the controller and length of memory mapped
+  region.
+- interrupts: interrupt source for the dryice module
+
+Example:
+
+	dryice at 53ffc000 {
+		compatible = "fsl,imx25-dryice", "fsl,imx25-rtc";
+		reg = <0x53ffc000 0x4000>;
+		interrupts = <25>;
+	};
drivers/rtc/rtc-imxdi.c +9 -3
index 891cd6c..b2fe920 100644
@@ -493,11 +493,17 @@ static int __devexit dryice_rtc_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id of_dryice_rtc_match[] = {
+	{ .compatible = "fsl,imx25-rtc", },
+	{ },
+};
+
 static struct platform_driver dryice_rtc_driver = {
 	.driver = {
-		   .name = "imxdi_rtc",
-		   .owner = THIS_MODULE,
-		   },
+		.name = "imxdi_rtc",
+		.owner = THIS_MODULE,
+		.of_match_table = of_dryice_rtc_match,
+	},
 	.remove = __devexit_p(dryice_rtc_remove),
 };
Signature · 1 line
1.7.10.4
Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |