incorrect GPT entry validation?
Hi,
A user reported problems with libblkid incorrectly reporting (or not reporting) tags for some partitions on a GPT formatted disk. I was able to reproduce it:
- created a 10G disk on a VM
- initialized it with GPT (using gdisk), created 5 entries
- formatted each of them with ext4
blkid correctly reads the first 2 entries on the disk, but then starts reporting corrupted GPT entries (seen via LIBBLKID_DEBUG=0xffff):
https://dev.archlinux.org/~dreisner/blkid_bad.txt
It's interesting to note that blkid will _always_ read 2 entries before reporting corruption, i.e.
# blkid -c /dev/null /dev/vdd{4,5,2}This shows full info for /dev/vdd4 and /dev/vdd5, but nothing for /dev/vdd2.
Commenting out the final crc validation in libblkid/src/partitions/gpt.c and rebuilding lets blkid continue on and it happily prints everything:
https://dev.archlinux.org/~dreisner/blkid_no_validate.txt
Of course this is entirely wrong, but I'm not familiar at all with the internals of libblkid or GPT to understand what's misbehaving.
As an aside, I was sadly unable to create the same layout using the shiny new fdisk:
Command (m for help): g
Command (m for help): n
Partition number (1-128): 1
First sector (34-20971486, default 34):
Using default value 34
Last sector (34-20971486, default 20971486): 2G
Value out of range.
Last sector (34-20971486, default 20971486): +2G
Created partition 1
Command (m for help): n
Partition number (1-128): 2
First sector (4194305-20971486, default 4194305): +2G Value out of range.
First sector (4194305-20971486, default 4194305): +1G Value out of range.
First sector (4194305-20971486, default 4194305): +1M Value out of range.
Cheers,
Dave
Karel Zak
maintainerQuoted 6 lines · Dave Reisner
Hi,
A user reported problems with libblkid incorrectly reporting (or not reporting) tags for some partitions on a GPT formatted disk. I was able to reproduce it:
Quoted 8 lines
- created a 10G disk on a VM
- initialized it with GPT (using gdisk), created 5 entries
- formatted each of them with ext4blkid correctly reads the first 2 entries on the disk, but then starts reporting corrupted GPT entries (seen via LIBBLKID_DEBUG=0xffff):
It would be nice to have the debug output.
Please, send me begin of the device:
# dd if=/dev/vdd of=img count=1 bs=1Mib
# gzip -9 imgQuoted 2 lines
It's interesting to note that blkid will _always_ read 2 entries before reporting corruption, i.e.
Hmm... sounds like in-memory buffer corruption libblkid caches the data from the device).
Quoted 1 line
# blkid -c /dev/null /dev/vdd{4,5,2}Are you able to reproduce the bug by "blkid -p -o udev" ?
Karel
Signature · 2 lines
Karel Zak <[email protected]> http://karelzak.blogspot.com
Quoted 6 lines · Karel Zak
It would be nice to have the debug output.
Please, send me begin of the device:
# dd if=/dev/vdd of=img count=1 bs=1Mib # gzip -9 img
Attached as img.gz. (I reported this bug originally, on this partition table.)
Quoted 1 line
Are you able to reproduce the bug by "blkid -p -o udev" ?
Yes, still can reproduce it with blkid -c /dev/null -p -o udev /dev/sda*. (Log attached.)
Signature · 1 line
Mantas Mikulėnas
Karel Zak
maintainerQuoted 2 lines · Dave Reisner
blkid correctly reads the first 2 entries on the disk, but then starts reporting corrupted GPT entries (seen via LIBBLKID_DEBUG=0xffff):
We have two GPT headers... and the third pass have nothing to parse :-)
This is the bug:
swap_efi_guid(&e->unique_partition_guid);
swap_efi_guid(&e->partition_type_guid);the "e" is persistent buffer.
Fixed. Thanks!
Karel
Signature · 2 lines
Karel Zak <[email protected]> http://karelzak.blogspot.com