Skip to contentSkip to conversation

add spi command

PATCH Applied Jean-Christophe PLAGNIOL-VILLARD 2 participants 4 messages Nov 5, 2012 – Nov 12, 2012 SPI

lore
Share & tools
lore

Jean-Christophe PLAGNIOL-VILLARD

author
#0 lore raw

v4 cover add spi command

HI,

v4:
do not touch the atmel_spi

v3:
call setup before accesing the device
This was working properly on at91 as the driver is wrong. It call setup for every transfer. I will fix the atmel_spi.

v2:
add default return usage
use memory_display

while debugging a spi issue I found we have a i2c commands but no spi command

So introduce one

The following changes since commit 56371f4e8446d04d2a5608dd5890fd87a50f888e:

iomux-imx35: add missing comma in pad definition (2012-11-01 16:32:12 +0100)

are available in the git repository at:

git://git.jcrosoft.org/barebox.git delivery/command_spi

for you to fetch changes up to 268e3d4f67da35571159fd096c62fa2e660783b0:

introduce spi command (2012-11-05 11:13:25 +0800)

----------------------------------------------------------------
Jean-Christophe PLAGNIOL-VILLARD (2):
spi: introduce spi_get_master
introduce spi command

 commands/Kconfig  |    6 ++++++
 commands/Makefile |    1 +
 commands/spi.c    |  132 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/spi/spi.c |   12 ++++++++++++
 include/spi/spi.h |    2 ++
 5 files changed, 153 insertions(+)
 create mode 100644 commands/spi.c

Best Regards,
J.

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

author
#1 lore raw

PATCH v4 1/2 spi: introduce spi_get_master

so we can request a master usefull for the spi command

Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
---
 drivers/spi/spi.c |   12 ++++++++++++
 include/spi/spi.h |    2 ++
 2 files changed, 14 insertions(+)
drivers/spi/spi.c +12 -0
index 44040e5..6a5bd6d 100644
@@ -219,6 +219,18 @@ int spi_register_master(struct spi_master *master)
 }
 EXPORT_SYMBOL(spi_register_master);
 
+struct spi_master *spi_get_master(int bus)
+{
+	struct spi_master* m;
+
+	list_for_each_entry(m, &spi_master_list, list) {
+		if (m->bus_num == bus)
+			return m;
+	}
+
+	return NULL;
+}
+
 int spi_sync(struct spi_device *spi, struct spi_message *message)
 {
 	return spi->master->transfer(spi, message);
include/spi/spi.h +2 -0
index 1773ca2..d6570a4 100644
@@ -432,6 +432,8 @@ static inline ssize_t spi_w8r8(struct spi_device *spi, u8 cmd)
 
 extern struct bus_type spi_bus;
 
+struct spi_master *spi_get_master(int bus);
+
 static inline int spi_register_driver(struct driver_d *drv)
 {
 	drv->bus = &spi_bus;
Signature · 7 lines
1.7.10.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
author
#2 lore raw

PATCH v4 2/2 introduce spi command

usefull to debug spi

The command allow to read/write on a spi device

Usage: spi [OPTION] [data to write 0xXX]
write/read spi device.

  -b <bus_num>  spi bus number (default = 0)
  -r <count>    to read
  -c <cs>       chip select (default = 0)
  -m <mode>     spi mode (default = 0)
  -f <hz>       max_speed_hz (default = 1MHz)
  -w <bit>      bits_per_word (default = 8)
  -v            verbose
Signed-off-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
---
 commands/Kconfig  |    6 +++
 commands/Makefile |    1 +
 commands/spi.c    |  132 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 139 insertions(+)
 create mode 100644 commands/spi.c
commands/Kconfig +6 -0
index 16706d3..f7cbd67 100644
@@ -597,6 +597,12 @@ config CMD_I2C
 	  include i2c_probe, i2c_read and i2c_write commands to communicate
 	  on i2c bus.
 
+config CMD_SPI
+	bool
+	depends on SPI
+	prompt "spi command"
+	help
+
 config CMD_LED
 	bool
 	depends on LED
commands/Makefile +1 -0
index 610be55..19d496e 100644
@@ -55,6 +55,7 @@ obj-$(CONFIG_USB_GADGET_SERIAL)	+= usbserial.o
 obj-$(CONFIG_CMD_GPIO)		+= gpio.o
 obj-$(CONFIG_CMD_UNCOMPRESS)	+= uncompress.o
 obj-$(CONFIG_CMD_I2C)		+= i2c.o
+obj-$(CONFIG_CMD_SPI)		+= spi.o
 obj-$(CONFIG_CMD_UBI)		+= ubi.o
 obj-$(CONFIG_CMD_MENU)		+= menu.o
 obj-$(CONFIG_CMD_PASSWD)	+= passwd.o
commands/spi.c new file +132 -0

132 lines not on this page · raw message

Signature · 7 lines
1.7.10.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Applied
#3 lore raw
In reply to Jean-Christophe PLAGNIOL-VILLARD
Quoted 14 lines · Jean-Christophe PLAGNIOL-VILLARD

HI,

v4:
do not touch the atmel_spi

v3:
call setup before accesing the device
This was working properly on at91 as the driver is wrong. It call setup for every transfer. I will fix the atmel_spi.

v2:
add default return usage
use memory_display

Quoted 6 lines

while debugging a spi issue I found we have a i2c commands but no spi command

So introduce one

The following changes since commit 56371f4e8446d04d2a5608dd5890fd87a50f888e:

Applied, thanks

Sascha

Quoted 32 lines

iomux-imx35: add missing comma in pad definition (2012-11-01 16:32:12 +0100)

are available in the git repository at:

git://git.jcrosoft.org/barebox.git delivery/command_spi

for you to fetch changes up to 268e3d4f67da35571159fd096c62fa2e660783b0:

introduce spi command (2012-11-05 11:13:25 +0800)

----------------------------------------------------------------
Jean-Christophe PLAGNIOL-VILLARD (2):
spi: introduce spi_get_master
introduce spi command

 commands/Kconfig  |    6 ++++++
 commands/Makefile |    1 +
 commands/spi.c    |  132 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/spi/spi.c |   12 ++++++++++++
 include/spi/spi.h |    2 ++
 5 files changed, 153 insertions(+)
 create mode 100644 commands/spi.c

Best Regards,
J.

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox