Skip to contentSkip to conversation

lcdproc: bump version to 0.5.6

PATCH New spdawson at gmail.com 2 participants 3 messages Nov 6, 2012 – Nov 11, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lcdproc: bump version to 0.5.6

From: Simon Dawson <[email protected]>

---
 .../lcdproc/lcdproc-0.5.5-fix-menu-segfault.patch   |   19 -------------------
 package/lcdproc/lcdproc.mk                          |    2 +-
 2 files changed, 1 insertion(+), 20 deletions(-)
 delete mode 100644 package/lcdproc/lcdproc-0.5.5-fix-menu-segfault.patch
package/lcdproc/lcdproc-0.5.5-fix-menu-segfault.patch deleted +0 -19
deleted file mode 100644
index f0ebe2d..0000000
@@ -1,19 +0,0 @@
-Trying to add a menu item using menu_add_item causes a segmentation fault
-in the LCDd server. This is caused by a read beyond the end of an array.
-
-This patch adds a safety check on the size of the argument array.
-
-Signed-off-by: Simon Dawson <[email protected]>
-
-diff -Nurp a/server/commands/menu_commands.c b/server/commands/menu_commands.c
---- a/server/commands/menu_commands.c	2011-08-14 13:29:16.000000000 +0100
-+++ b/server/commands/menu_commands.c	2012-10-04 22:19:07.997409193 +0100
-@@ -198,7 +198,7 @@ menu_add_item_func(Client *c, int argc,
- 
- 	/* call menu_set_item() with a temporarily allocated argv
- 	 * to process the remaining options */
--	if ((argc > 5) || (argv[4][0] == '-')) {
-+	if ((argc > 5) || ((argc == 5) && argv[4][0] == '-')) {
- 		// menu_add_item <menuid> <newitemid> <type> [<text>]
- 		// menu_set_item <menuid> <itemid> {<option>}+
- 		int i, j;
package/lcdproc/lcdproc.mk +1 -1
index 7914c85..aa204f1 100644
@@ -3,7 +3,7 @@
 # lcdproc
 #
 #############################################################
-LCDPROC_VERSION = 0.5.5
+LCDPROC_VERSION = 0.5.6
 LCDPROC_SOURCE = lcdproc-$(LCDPROC_VERSION).tar.gz
 LCDPROC_SITE = http://downloads.sourceforge.net/project/lcdproc/lcdproc/$(LCDPROC_VERSION)
 LCDPROC_LICENSE = GPLv2+
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 lcdproc: bump version to 0.5.6

Hello Simon,

Quoted 8 lines · spdawson at gmail.com

From: Simon Dawson <[email protected]>

---
 .../lcdproc/lcdproc-0.5.5-fix-menu-segfault.patch   |   19 -------------------
 package/lcdproc/lcdproc.mk                          |    2 +-
 2 files changed, 1 insertion(+), 20 deletions(-)
 delete mode 100644 package/lcdproc/lcdproc-0.5.5-fix-menu-segfault.patch

There are apparently build issues with lcdproc 0.5.6. Not sure if they are new or if they were present in older versions. See
http://autobuild.buildroot.org/results/9967bc20a6094e836c4c18ff2cd30edef143bb8e/build-end.log.
Basically, lcdproc uses -I<foo>/host/usr/include -L<foo>/host/usr/lib to build things for the target.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 lcdproc: bump version to 0.5.6

Hi Thomas.

Quoted 5 lines · Thomas Petazzoni

There are apparently build issues with lcdproc 0.5.6. Not sure if they are new or if they were present in older versions. See
http://autobuild.buildroot.org/results/9967bc20a6094e836c4c18ff2cd30edef143bb8e/build-end.log.
Basically, lcdproc uses -I<foo>/host/usr/include -L<foo>/host/usr/lib to build things for the target.

Okay; I'll have a look. (I must have missed this problem because I'm applying quite a large local patch to lcdproc, which necessitates an autoreconf.)

Simon.