ath5k: precedence error in ath5k_hw_nic_wakeup()

PATCH New Dan Carpenter 1 participant 1 message Nov 14, 2012

Subsystems (2)

Kernel janitors Atheros ATH5K wireless driver

lore

Share & tools

lore

Dan Carpenter

author

2012-11-14 08:23 UTC #0 lore raw

PATCH 1/1 ath5k: precedence error in ath5k_hw_nic_wakeup()

'|' has higher precedence than ?:. Since AR5K_PHY_TURBO_MODE is 0x1 and "AR5K_PHY_TURBO_MODE | (ah->ah_radio = AR5K_RF2425)" is true then we always set turbo to zero.

Signed-off-by Dan Carpenter <[email protected]>

---
Static analysis fix. I don't have a way to test this.

drivers/net/wireless/ath/ath5k/reset.c +3 -3

index 0c2dd47..4084b10 100644
@@ -789,9 +789,9 @@ ath5k_hw_nic_wakeup(struct ath5k_hw *ah, struct ieee80211_channel *channel)
 		 * (I don't think it supports 44MHz) */
 		/* On 2425 initvals TURBO_SHORT is not present */
 		if (ah->ah_bwmode = AR5K_BWMODE_40MHZ) {
-			turbo = AR5K_PHY_TURBO_MODE |
-				(ah->ah_radio = AR5K_RF2425) ? 0 :
-				AR5K_PHY_TURBO_SHORT;
+			turbo = AR5K_PHY_TURBO_MODE;
+			if (ah->ah_radio != AR5K_RF2425)
+				turbo |= AR5K_PHY_TURBO_SHORT;
 		} else if (ah->ah_bwmode != AR5K_BWMODE_DEFAULT) {
 			if (ah->ah_radio = AR5K_RF5413) {
 				mode |= (ah->ah_bwmode = AR5K_BWMODE_10MHZ) ?