Skip to contentSkip to conversation

M68K: eb_cpu5282: general update and enhanced board support

PATCH Superseded Jens Scharsig (BuS Elektronik) 2 participants 5 messages Oct 29, 2012 – Nov 14, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 M68K: eb_cpu5282: general update and enhanced board support

From: "Jens Scharsig (BuS Elektronik)" <[email protected]>

- update clock settings for higher perfomance
- change standard baud rate to 115200
- fix flash base address
- remove unused defines
- add I2C support
- switch form board dependent flash to cfi
- remove board dependent flash code
- use sdram bank 0 instead of bank 1 on boot
- enable on board frame buffer instead external
- remove fake mac address form config
- add watchdog support
- add status led support

---
 board/BuS/eb_cpu5282/Makefile     |    2 +-
 board/BuS/eb_cpu5282/cfm_flash.c  |  212 -------------------
 board/BuS/eb_cpu5282/cfm_flash.h  |   40 ----
 board/BuS/eb_cpu5282/config.mk    |   27 ---
 board/BuS/eb_cpu5282/eb_cpu5282.c |  102 ++++++---
 board/BuS/eb_cpu5282/flash.c      |  415 -------------------------------------
 boards.cfg                        |    2 +-
 include/configs/eb_cpu5282.h      |  101 +++++----
 8 files changed, 142 insertions(+), 759 deletions(-)
 delete mode 100644 board/BuS/eb_cpu5282/cfm_flash.c
 delete mode 100644 board/BuS/eb_cpu5282/cfm_flash.h
 delete mode 100644 board/BuS/eb_cpu5282/config.mk
 delete mode 100644 board/BuS/eb_cpu5282/flash.c
board/BuS/eb_cpu5282/Makefile +1 -1
index 0f14699..ac860c1 100644
@@ -25,7 +25,7 @@ include $(TOPDIR)/config.mk
 
 LIB	= $(obj)lib$(BOARD).o
 
-COBJS	= $(BOARD).o cfm_flash.o flash.o
+COBJS	= $(BOARD).o
 
 SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))
board/BuS/eb_cpu5282/cfm_flash.c deleted +0 -212

212 lines not on this page · raw message

board/BuS/eb_cpu5282/cfm_flash.h deleted +0 -40
deleted file mode 100644
index ed4e794..0000000
@@ -1,40 +0,0 @@
-/*
- * Basic Flash Driver for Freescale MCF 5282 internal FLASH
- *
- * (C) Copyright 2005 BuS Elektronik GmbH & Co.KG <[email protected]>
- *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- */
-
-#ifndef __CFM_FLASH_H_
-#define __CFM_FLASH_H_
-
-#define	FREESCALE_MANUFACT 0xFACFFACF
-#define	FREESCALE_ID_MCF5281 0x5281
-#define	FREESCALE_ID_MCF5282 0x5282
-
-extern void cfm_flash_print_info (flash_info_t * info);
-extern int cfm_flash_erase_sector (flash_info_t * info, int sector);
-extern void cfm_flash_init (flash_info_t * info);
-extern int cfm_flash_write_buff (flash_info_t * info, uchar * src, ulong addr, ulong cnt);
-#ifdef CONFIG_SYS_FLASH_PROTECTION
-extern int cfm_flash_protect(flash_info_t * info,long sector,int prot);
-#endif
-
-#endif
board/BuS/eb_cpu5282/config.mk deleted +0 -27
deleted file mode 100644
index 18fb84e..0000000
@@ -1,27 +0,0 @@
-#
-# (C) Copyright 2000-2003
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
-# Coldfire contribution by Bernhard Kuhn <[email protected]>
-#
-# See file CREDITS for list of people who contributed to this
-# project.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
-# MA 02111-1307 USA
-#
-
-ifndef CONFIG_SYS_TEXT_BASE
-CONFIG_SYS_TEXT_BASE = 0xFE000000
-endif
board/BuS/eb_cpu5282/eb_cpu5282.c +74 -28

153 lines not on this page · raw message

board/BuS/eb_cpu5282/flash.c deleted +0 -415

415 lines not on this page · raw message

boards.cfg +1 -1
index 7c1fc74..07699f7 100644
@@ -361,7 +361,7 @@ M5235EVB                     m68k        mcf523x     m5235evb            freesca
 M5235EVB_Flash32             m68k        mcf523x     m5235evb            freescale      -           M5235EVB:NORFLASH_PS32BIT,SYS_TEXT_BASE=0xFFC00000
 cobra5272                    m68k        mcf52x2     cobra5272           -
 idmr                         m68k        mcf52x2
-eb_cpu5282                   m68k        mcf52x2     eb_cpu5282          BuS            -           eb_cpu5282:SYS_TEXT_BASE=0xFFE00000
+eb_cpu5282                   m68k        mcf52x2     eb_cpu5282          BuS            -           eb_cpu5282:SYS_TEXT_BASE=0xFF000000
 eb_cpu5282_internal          m68k        mcf52x2     eb_cpu5282          BuS            -           eb_cpu5282:SYS_TEXT_BASE=0xF0000000
 TASREG                       m68k        mcf52x2     tasreg              esd
 M5208EVBE                    m68k        mcf52x2     m5208evbe           freescale
include/configs/eb_cpu5282.h +66 -35

208 lines not on this page · raw message

Signature · 1 line
1.7.10.4
#1 lore raw

PATCH v2 1/1 M68K: eb_cpu5282: general update and enhanced board support

From: "Jens Scharsig (BuS Elektronik)" <[email protected]>

- update clock settings for higher perfomance
- change standard baud rate to 115200
- fix flash base address
- remove unused defines
- add I2C support
- switch form board dependent flash to cfi
- remove board dependent flash code
- use sdram bank 0 instead of bank 1 on boot
- enable on board frame buffer instead external
- remove fake mac address form config
- add watchdog support
- add status led support

---
changes since V1:

remove autodetect video, don't work on all hardware revisions

 board/BuS/eb_cpu5282/Makefile     |    2 +-
 board/BuS/eb_cpu5282/cfm_flash.c  |  212 -------------------
 board/BuS/eb_cpu5282/cfm_flash.h  |   40 ----
 board/BuS/eb_cpu5282/config.mk    |   27 ---
 board/BuS/eb_cpu5282/eb_cpu5282.c |  110 +++++++---
 board/BuS/eb_cpu5282/flash.c      |  415 -------------------------------------
 boards.cfg                        |    2 +-
 include/configs/eb_cpu5282.h      |  102 +++++----
 8 files changed, 146 insertions(+), 764 deletions(-)
 delete mode 100644 board/BuS/eb_cpu5282/cfm_flash.c
 delete mode 100644 board/BuS/eb_cpu5282/cfm_flash.h
 delete mode 100644 board/BuS/eb_cpu5282/config.mk
 delete mode 100644 board/BuS/eb_cpu5282/flash.c
board/BuS/eb_cpu5282/Makefile +1 -1
index 0f14699..ac860c1 100644
@@ -25,7 +25,7 @@ include $(TOPDIR)/config.mk
 
 LIB	= $(obj)lib$(BOARD).o
 
-COBJS	= $(BOARD).o cfm_flash.o flash.o
+COBJS	= $(BOARD).o
 
 SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))
board/BuS/eb_cpu5282/cfm_flash.c deleted +0 -212

212 lines not on this page · raw message

board/BuS/eb_cpu5282/cfm_flash.h deleted +0 -40
deleted file mode 100644
index ed4e794..0000000
@@ -1,40 +0,0 @@
-/*
- * Basic Flash Driver for Freescale MCF 5282 internal FLASH
- *
- * (C) Copyright 2005 BuS Elektronik GmbH & Co.KG <[email protected]>
- *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- * MA 02111-1307 USA
- */
-
-#ifndef __CFM_FLASH_H_
-#define __CFM_FLASH_H_
-
-#define	FREESCALE_MANUFACT 0xFACFFACF
-#define	FREESCALE_ID_MCF5281 0x5281
-#define	FREESCALE_ID_MCF5282 0x5282
-
-extern void cfm_flash_print_info (flash_info_t * info);
-extern int cfm_flash_erase_sector (flash_info_t * info, int sector);
-extern void cfm_flash_init (flash_info_t * info);
-extern int cfm_flash_write_buff (flash_info_t * info, uchar * src, ulong addr, ulong cnt);
-#ifdef CONFIG_SYS_FLASH_PROTECTION
-extern int cfm_flash_protect(flash_info_t * info,long sector,int prot);
-#endif
-
-#endif
board/BuS/eb_cpu5282/config.mk deleted +0 -27
deleted file mode 100644
index 18fb84e..0000000
@@ -1,27 +0,0 @@
-#
-# (C) Copyright 2000-2003
-# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
-# Coldfire contribution by Bernhard Kuhn <[email protected]>
-#
-# See file CREDITS for list of people who contributed to this
-# project.
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License as
-# published by the Free Software Foundation; either version 2 of
-# the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
-# MA 02111-1307 USA
-#
-
-ifndef CONFIG_SYS_TEXT_BASE
-CONFIG_SYS_TEXT_BASE = 0xFE000000
-endif
board/BuS/eb_cpu5282/eb_cpu5282.c +78 -32

168 lines not on this page · raw message

board/BuS/eb_cpu5282/flash.c deleted +0 -415

415 lines not on this page · raw message

boards.cfg +1 -1
index 7c1fc74..07699f7 100644
@@ -361,7 +361,7 @@ M5235EVB                     m68k        mcf523x     m5235evb            freesca
 M5235EVB_Flash32             m68k        mcf523x     m5235evb            freescale      -           M5235EVB:NORFLASH_PS32BIT,SYS_TEXT_BASE=0xFFC00000
 cobra5272                    m68k        mcf52x2     cobra5272           -
 idmr                         m68k        mcf52x2
-eb_cpu5282                   m68k        mcf52x2     eb_cpu5282          BuS            -           eb_cpu5282:SYS_TEXT_BASE=0xFFE00000
+eb_cpu5282                   m68k        mcf52x2     eb_cpu5282          BuS            -           eb_cpu5282:SYS_TEXT_BASE=0xFF000000
 eb_cpu5282_internal          m68k        mcf52x2     eb_cpu5282          BuS            -           eb_cpu5282:SYS_TEXT_BASE=0xF0000000
 TASREG                       m68k        mcf52x2     tasreg              esd
 M5208EVBE                    m68k        mcf52x2     m5208evbe           freescale
include/configs/eb_cpu5282.h +66 -36

209 lines not on this page · raw message

Signature · 1 line
1.7.10.4
#2 lore raw

PATCH v2 1/1 M68K: eb_cpu5282: general update and enhanced board support

Hello,

I have seen this patch is marked as "Changes Requested" in patchwork. But I have never get a request or comment. Is there an real reason for this state?

regards Jens

Am 2012-10-30 11:46, schrieb Jens Scharsig (BuS Elektronik):

Quoted 15 lines

From: "Jens Scharsig (BuS Elektronik)" <[email protected]>

- update clock settings for higher perfomance
- change standard baud rate to 115200
- fix flash base address
- remove unused defines
- add I2C support
- switch form board dependent flash to cfi
- remove board dependent flash code
- use sdram bank 0 instead of bank 1 on boot
- enable on board frame buffer instead external
- remove fake mac address form config
- add watchdog support
- add status led support

#3 lore raw

PATCH v2 1/1 M68K: eb_cpu5282: general update and enhanced board support

Hello Jens,

On Wed, 14 Nov 2012 11:26:59 +0100
<[email protected]> wrote:
..

Quoted 3 lines

I have seen this patch is marked as "Changes Requested" in patchwork. But I have never get a request or comment. Is there an real reason for this state?

I also do not see any such requests on the list, so it must have happened by an accident. I'll change the patch status in patchwork.

Thanks,
Anatolij

#4 lore raw

PATCH v2 1/1 M68K: eb_cpu5282: general update and enhanced board support

In reply to Jens Scharsig (BuS Elektronik)

Hi,

Quoted 21 lines · On Tue, 30 Oct 2012 11:46:05 +0100 "Jens Scharsig (BuS Elektronik)"…

From: "Jens Scharsig (BuS Elektronik)" <[email protected]>

- update clock settings for higher perfomance
- change standard baud rate to 115200
- fix flash base address
- remove unused defines
- add I2C support
- switch form board dependent flash to cfi
- remove board dependent flash code
- use sdram bank 0 instead of bank 1 on boot
- enable on board frame buffer instead external
- remove fake mac address form config
- add watchdog support
- add status led support

---
changes since V1:

remove autodetect video, don't work on all hardware revisions

Quoted 14 lines
 board/BuS/eb_cpu5282/Makefile     |    2 +-
 board/BuS/eb_cpu5282/cfm_flash.c  |  212 -------------------
 board/BuS/eb_cpu5282/cfm_flash.h  |   40 ----
 board/BuS/eb_cpu5282/config.mk    |   27 ---
 board/BuS/eb_cpu5282/eb_cpu5282.c |  110 +++++++---
 board/BuS/eb_cpu5282/flash.c      |  415 -------------------------------------
 boards.cfg                        |    2 +-
 include/configs/eb_cpu5282.h      |  102 +++++----
 8 files changed, 146 insertions(+), 764 deletions(-)
 delete mode 100644 board/BuS/eb_cpu5282/cfm_flash.c
 delete mode 100644 board/BuS/eb_cpu5282/cfm_flash.h
 delete mode 100644 board/BuS/eb_cpu5282/config.mk
 delete mode 100644 board/BuS/eb_cpu5282/flash.c

Applied to staging/agust at denx.de after fixing a build warning and some small style issues. Please next time use tools/checkpatch.pl for checking the patches before submission. Thanks!

Anatolij