Skip to contentSkip to conversation

Documentation: correct argument list for of_platform_populate correction to match of_platform.h prototype

PATCH New Chaiken, Alison 4 participants 4 messages Nov 15, 2012 – Nov 21, 2012 Device tree bindings

lore
Share & tools
lore

Chaiken, Alison

author
#0 lore raw

PATCH 1/1 Documentation: correct argument list for of_platform_populate correction to match of_platform.h prototype

Quoted 1 line

From fd4450ac6bdcf62a84b0d029b36506e7fd567688 Mon Sep 17 00:00:00 2001

From: Alison Chaiken <[email protected]>
Date: Thu, 1 Nov 2012 01:12:38 -0700
Subject: [PATCH] Argument list for of_platform_populate correction to match of_platform.h prototype

Signed-off-by Alison Chaiken <[email protected]>
---
 Documentation/devicetree/usage-model.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/devicetree/usage-model.txt +1 -1
index c5a8009..daa56a2 100644
@@ -347,7 +347,7 @@ later), which will happily live at the base of the Linux /sys/devices
  tree.  Therefore, if a DT node is at the root of the tree, then it
  really probably is best registered as a platform_device.
  
-Linux board support code calls of_platform_populate(NULL, NULL, NULL)
+Linux board support code calls of_platform_populate(NULL, NULL, NULL, NULL)
  to kick off discovery of devices at the root of the tree.  The
  parameters are all NULL because when starting from the root of the
  tree, there is no need to provide a starting node (the first NULL), a
Signature · 1 line
 1.7.1
#1 lore raw

PATCH 1/1 Documentation: correct argument list for of_platform_populate correction to match of_platform.h prototype

Hello.

Quoted 4 lines · Alison

From fd4450ac6bdcf62a84b0d029b36506e7fd567688 Mon Sep 17 00:00:00 2001
From: Alison Chaiken <[email protected]>
Date: Thu, 1 Nov 2012 01:12:38 -0700
Subject: [PATCH] Argument list for of_platform_populate correction to match of_platform.h prototype

The above header is not needed.

Quoted 10 lines
Signed-off-by Alison Chaiken <[email protected]>
---
  Documentation/devicetree/usage-model.txt |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/devicetree/usage-model.txt +0 -0
index c5a8009..daa56a2 100644

Documentation/devicetree/usage-model.txt later), which will happily live at the base of the Linux /sys/devices · line 353

Quoted 8 lines
Documentation/devicetree/usage-model.txt +1 -1
@@ -347,7 +347,7 @@ later), which will happily live at the base of the Linux /sys/devices
  tree.  Therefore, if a DT node is at the root of the tree, then it
  really probably is best registered as a platform_device.
 
-Linux board support code calls of_platform_populate(NULL, NULL, NULL)
+Linux board support code calls of_platform_populate(NULL, NULL, NULL, NULL)
  to kick off discovery of devices at the root of the tree.  The
  parameters are all NULL because when starting from the root of the
  tree, there is no need to provide a starting node (the first NULL), a

Looks like the patch is whitespace spoiled, i.e. a space is added to each
line starting with a space.

WBR, Sergei

#2 lore raw

PATCH 1/1 Documentation: correct argument list for of_platform_populate correction to match of_platform.h prototype

In reply to Chaiken, Alison
Quoted 6 lines · Alison

From fd4450ac6bdcf62a84b0d029b36506e7fd567688 Mon Sep 17 00:00:00 2001
From: Alison Chaiken <[email protected]>
Date: Thu, 1 Nov 2012 01:12:38 -0700
Subject: [PATCH] Argument list for of_platform_populate correction to match of_platform.h prototype

Signed-off-by Alison Chaiken <[email protected]>

Hi Alison,

Congratulations on your first patch on the arm mailing list!

The patch looks obviously correct to me, so

Acked-by Arnd Bergmann <[email protected]>

Sergei already mentioned that the email was whitespace broken and had extra lines on top, which can happen when you use thunderbird for sending the patch. See Documentation/email-clients.txt for how to deal with this. My usual recommendation is to use git-send-email.

It also helps to include all maintainers that might be responsible for picking up the patch. In this case, there are three maintainers:
Grant Likely and Rob Herring (both doing device tree) and Rob Landley (for Documentation). There are also two mailing lists, linux-doc at vger.kernel.org and devicetree-discuss at lists.ozlabs.org.

Adding all of the above to Cc increases the chances of someone actually applying the patch. Unfortunately not all of us get to apply patches we receive as fast as we should, and patches like yours could get applied by any of the three people. In doubt, you can always Cc everyone that scripts/get_maintainer.pl suggests, but if you know the people well, you can also trim down that list.

Arnd

Applied
#3 lore raw

PATCH 1/1 Documentation: correct argument list for of_platform_populate correction to match of_platform.h prototype

Quoted 8 lines · Arnd Bergmann
Quoted 6 lines · Alison

From fd4450ac6bdcf62a84b0d029b36506e7fd567688 Mon Sep 17 00:00:00 2001
From: Alison Chaiken <[email protected]>
Date: Thu, 1 Nov 2012 01:12:38 -0700
Subject: [PATCH] Argument list for of_platform_populate correction to match of_platform.h prototype

Signed-off-by Alison Chaiken <[email protected]>
Quoted 7 lines

Hi Alison,

Congratulations on your first patch on the arm mailing list!

The patch looks obviously correct to me, so

Acked-by Arnd Bergmann <[email protected]>

Applied, thanks.