Skip to contentSkip to conversation

drm/i915: Enable DP audio for Haswell

PATCH Applied Takashi Iwai 3 participants 3 messages Nov 19, 2012 – Nov 20, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/i915: Enable DP audio for Haswell

This patch adds the missing code to send ELD for Haswell DisplayPort, based on Xingchao's original patch.

A test was performed with HSW-D machine and NEC EA232Wmi DP monitor.

---
v1->v2: Fixed a typo

 drivers/gpu/drm/i915/intel_ddi.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/gpu/drm/i915/intel_ddi.c +9 -0
index 58f50eb..d706d53 100644
@@ -669,6 +669,15 @@ static void intel_ddi_mode_set(struct drm_encoder *encoder,
 			break;
 		}
 
+		if (intel_dp->has_audio) {
+			DRM_DEBUG_DRIVER("DP audio on pipe %c on DDI\n",
+					 pipe_name(intel_crtc->pipe));
+
+			/* write eld */
+			DRM_DEBUG_DRIVER("DP audio: write eld information\n");
+			intel_write_eld(encoder, adjusted_mode);
+		}
+
 		intel_dp_init_link_config(intel_dp);
 
 	} else if (type == INTEL_OUTPUT_HDMI) {
Signature · 1 line
1.8.0
Reviewed-by on v2 1/1
#1 lore raw

2012/11/19 Takashi Iwai <[email protected]>:

Quoted 7 lines

This patch adds the missing code to send ELD for Haswell DisplayPort, based on Xingchao's original patch.

A test was performed with HSW-D machine and NEC EA232Wmi DP monitor.

Quoted 33 lines

---
v1->v2: Fixed a typo

 drivers/gpu/drm/i915/intel_ddi.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/gpu/drm/i915/intel_ddi.c +9 -1
index 58f50eb..d706d53 100644
@@ -669,6 +669,15 @@ static void intel_ddi_mode_set(struct drm_encoder *encoder,
                        break;
                }
 
+               if (intel_dp->has_audio) {
+                       DRM_DEBUG_DRIVER("DP audio on pipe %c on DDI\n",
+                                        pipe_name(intel_crtc->pipe));
+
+                       /* write eld */
+                       DRM_DEBUG_DRIVER("DP audio: write eld information\n");
+                       intel_write_eld(encoder, adjusted_mode);
+               }
+
                intel_dp_init_link_config(intel_dp);
 
        } else if (type == INTEL_OUTPUT_HDMI) {
--

1.8.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 1 line
Paulo Zanoni
#2 lore raw
Quoted 10 lines · Paulo Zanoni

2012/11/19 Takashi Iwai <[email protected]>:

Quoted 7 lines

This patch adds the missing code to send ELD for Haswell DisplayPort, based on Xingchao's original patch.

A test was performed with HSW-D machine and NEC EA232Wmi DP monitor.

Queued for -next, thanks for the patch.
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch