Skip to contentSkip to conversation

xtensa: disable libffi for Xtensa

PATCH New Chris Zankel 3 participants 4 messages Nov 20, 2012 – Nov 21, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 xtensa: disable libffi for Xtensa

Xtensa currently doesn't support libffi.

---
 package/libffi/Config.in |    1 +
 1 file changed, 1 insertion(+)
package/libffi/Config.in +1 -0
index 7211f8f..4afb669 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBFFI
 	bool "libffi"
+	depends on !BR2_xtensa
 	help
 	  The libffi library provides a portable, high level
 	  programming interface to various calling conventions. This
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 3/3 xtensa: disable libffi for Xtensa

Hi Chris,

Quoted 12 lines · Chris Zankel

Xtensa currently doesn't support libffi.

---
 package/libffi/Config.in |    1 +
 1 file changed, 1 insertion(+)
package/libffi/Config.in +0 -0
index 7211f8f..4afb669 100644

package/libffi/Config.in line 6

Quoted 6 lines
package/libffi/Config.in +1 -0
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBFFI
 	bool "libffi"
+	depends on !BR2_xtensa
 	help
 	  The libffi library provides a portable, high level
 	  programming interface to various calling conventions. This

You need to recursively propagate this 'depends' to all packages selecting BR2_PACKAGE_LIBFFI. This is due to a limitation of kconfig that doesn't check whether a package is actually selectable.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 3/3 xtensa: disable libffi for Xtensa

Hi Baruch,

Quoted 10 lines · Baruch Siach

Hi Chris,

Quoted 7 lines · Chris Zankel

Xtensa currently doesn't support libffi.

---
 package/libffi/Config.in |    1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

package/libffi/Config.in line 6

Quoted 11 lines
package/libffi/Config.in +1 -0
index 7211f8f..4afb669 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBFFI
 	bool "libffi"
+	depends on !BR2_xtensa
 	help
 	  The libffi library provides a portable, high level
 	  programming interface to various calling conventions. This

You need to recursively propagate this 'depends' to all packages selecting BR2_PACKAGE_LIBFFI. This is due to a limitation of kconfig that doesn't check whether a package is actually selectable.

Ah, good to know. Thanks. Will create another patch.

Cheers!
-Chris

#3 lore raw

PATCH 3/3 xtensa: disable libffi for Xtensa

Dear Chris Zankel,

Quoted 5 lines · Chris Zankel
Quoted 3 lines

You need to recursively propagate this 'depends' to all packages selecting BR2_PACKAGE_LIBFFI. This is due to a limitation of kconfig that doesn't check whether a package is actually selectable.

Ah, good to know. Thanks. Will create another patch.

No, don't do it. You will become crazy before you get to the end of it. libffi is a dependency for glib and python, and glib in turn has a crazy number of reverse dependencies, themselves having other reverse dependencies. You would have to add a depends on !BR2_xtensa on dozens and dozens of packages.

This is a known limitation of kconfig, which we have discussed in length during the last Buildroot Developer Days, see point 6) in
http://elinux.org/Buildroot:DeveloperDaysELCE2012#Details_of_the_discussion.

For now, I think it's better to just leave libffi as it is, until we find a good way of solving the entire problem. We know that we should ignore those autobuilders failures.

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com