Skip to contentSkip to conversation

ivtv: ivtv-driver: Replace 'flush_work_sync()'

PATCH In review Mauro Carvalho Chehab 2 participants 3 messages Nov 21, 2012 – Jan 7, 2013

Subsystems (2)
Media (V4L/DVB) Ivtv VIDEO4LINUX driver
lore
Share & tools
lore

Mauro Carvalho Chehab

author
#0 lore raw

PATCH 1/1 ivtv: ivtv-driver: Replace 'flush_work_sync()'

Hi Andy,

I'm understanding that you'll be reviewing this patch. So, I'm marking it as under_review at patchwork.

Thanks,
Mauro

Forwarded message:

Date: Wed, 24 Oct 2012 10:14:16 -0200
From: Fabio Estevam <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected], Fabio Estevam <[email protected]>
Subject: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'

From: Fabio Estevam <[email protected]>

Since commit 43829731d (workqueue: deprecate flush[_delayed]_work_sync()), flush_work() should be used instead of flush_work_sync().

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/media/pci/ivtv/ivtv-driver.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/pci/ivtv/ivtv-driver.c +1 -1
index 74e9a50..5d0a5df 100644
@@ -304,7 +304,7 @@ static void request_modules(struct ivtv *dev)
 
 static void flush_request_modules(struct ivtv *dev)
 {
-	flush_work_sync(&dev->request_module_wk);
+	flush_work(&dev->request_module_wk);
 }
 #else
 #define request_modules(dev)
Signature · 11 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Regards,
Mauro
author
#1 lore raw

Em Wed, 21 Nov 2012 15:28:09 -0200
Mauro Carvalho Chehab <[email protected]> escreveu:

Quoted 4 lines

Hi Andy,

I'm understanding that you'll be reviewing this patch. So, I'm marking it as under_review at patchwork.

-ENOANSWER. Let me apply it, in order to fix the warning.

Quoted 36 lines

Thanks,
Mauro

Forwarded message:

Date: Wed, 24 Oct 2012 10:14:16 -0200
From: Fabio Estevam <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected], Fabio Estevam <[email protected]>
Subject: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'

From: Fabio Estevam <[email protected]>

Since commit 43829731d (workqueue: deprecate flush[_delayed]_work_sync()), flush_work() should be used instead of flush_work_sync().

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/media/pci/ivtv/ivtv-driver.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/pci/ivtv/ivtv-driver.c +1 -1
index 74e9a50..5d0a5df 100644
@@ -304,7 +304,7 @@ static void request_modules(struct ivtv *dev)
 
 static void flush_request_modules(struct ivtv *dev)
 {
-	flush_work_sync(&dev->request_module_wk);
+	flush_work(&dev->request_module_wk);
 }
 #else
 #define request_modules(dev)
Signature · 2 lines
Cheers,
Mauro
maintainer Acked-by
#2 lore raw
Quoted 9 lines · Mauro Carvalho Chehab

Em Wed, 21 Nov 2012 15:28:09 -0200
Mauro Carvalho Chehab <[email protected]> escreveu:

Quoted 4 lines

Hi Andy,

I'm understanding that you'll be reviewing this patch. So, I'm marking it as under_review at patchwork.

-ENOANSWER. Let me apply it, in order to fix the warning.

Ooops. Sorry about that.

Strictly speaking, I think the patch introduces a race condition that is extremely unlikely to be encountered, and it likely wouldn't have terrible consequences anyway.

For the normal end-user, it will never be a problem.

FWIW:

Acked-by Andy Walls <[email protected]>

Regards,
Andy

Quoted 38 lines
Quoted 36 lines

Thanks,
Mauro

Forwarded message:

Date: Wed, 24 Oct 2012 10:14:16 -0200
From: Fabio Estevam <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected], Fabio Estevam <[email protected]>
Subject: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'

From: Fabio Estevam <[email protected]>

Since commit 43829731d (workqueue: deprecate flush[_delayed]_work_sync()), flush_work() should be used instead of flush_work_sync().

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/media/pci/ivtv/ivtv-driver.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/pci/ivtv/ivtv-driver.c +1 -1
index 74e9a50..5d0a5df 100644
@@ -304,7 +304,7 @@ static void request_modules(struct ivtv *dev)
 
 static void flush_request_modules(struct ivtv *dev)
 {
-	flush_work_sync(&dev->request_module_wk);
+	flush_work(&dev->request_module_wk);
 }
 #else
 #define request_modules(dev)