Fix bash completion when `egrep` is aliased to `egrep --color=always`

Hello all,

attached patch fixes bash completion when egrep is aliased to egrep --color=always.

Comments are welcomed.

Regards, Adam

Adam Tkac, Red Hat, Inc.

From: Adam Tkac <[email protected]>
Date: Thu, 22 Nov 2012 16:34:58 +0100
Subject: [PATCH] Fix bash completion when egrep is aliased to `egrep
--color=always`

Originally reported as https://bugzilla.redhat.com/show_bug.cgi?id=863780

---
 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

index bc0657a..47613f9 100644
@@ -565,7 +565,7 @@ __git_complete_strategy ()
 __git_list_all_commands ()
 {
 	local i IFS=" "$'\n'
-	for i in $(git help -a|egrep '^  [a-zA-Z0-9]')
+	for i in $(git help -a|egrep --color=never '^  [a-zA-Z0-9]')
 	do
 		case $i in
 		*--*)             : helper pattern;;

1.8.0

To avoid any aliases, it may be better to use
\egrep

This could be worthwhile for all utilities used by the script.

Just a thought.

Marc

Good idea, thanks. Improved patch is attached.

Regards, Adam

Adam Tkac, Red Hat, Inc.

From: Adam Tkac <[email protected]>
Date: Thu, 22 Nov 2012 16:34:58 +0100
Subject: [PATCH] If egrep is aliased, temporary disable it in
bash.completion

Originally reported as https://bugzilla.redhat.com/show_bug.cgi?id=863780

---
 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

index 0960acc..79073c2 100644
@@ -565,7 +565,7 @@ __git_complete_strategy ()
 __git_list_all_commands ()
 {
 	local i IFS=" "$'\n'
-	for i in $(git help -a|egrep '^  [a-zA-Z0-9]')
+	for i in $(git help -a| \egrep '^  [a-zA-Z0-9]')
 	do
 		case $i in
 		*--*)             : helper pattern;;

1.8.0

It is custom on this list to mail the patches, rather than attaching them, so people can review your changes in-line. You can read more about it in in git/Documentation/SubmittingPatches.

Cheers,
Frans