extcon: arizona: Only set GPIO if it has been requested
PATCH 1/1 extcon: arizona: Only set GPIO if it has been requested
The micd_pol GPIO is only requested if we've specified one greater than 0 so apply the same test before we set it.
--- drivers/extcon/extcon-arizona.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/extcon/extcon-arizona.c +3 -2
@@ -85,8 +85,9 @@ static void arizona_extcon_set_mode(struct arizona_extcon_info *info, int mode) {struct arizona *arizona = info->arizona; -gpio_set_value_cansleep (arizona->pdata.micd_pol_gpio, - info->micd_modes[mode].gpio); +if (arizona->pdata.micd_pol_gpio >0 ) +gpio_set_value_cansleep (arizona->pdata.micd_pol_gpio, + info->micd_modes[mode].gpio);regmap_update_bits (arizona->regmap,ARIZONA_MIC_DETECT_1 ,ARIZONA_MICD_BIAS_SRC_MASK , info->micd_modes[mode].bias);
Signature · 1 line
1.7.10.4
Chanwoo Choi
maintainerQuoted 13 lines · Mark Brown
The
micd_polGPIO is only requested if we've specified one greater than 0 so apply the same test before we set it.Signed-off-by Mark Brown <[email protected]>--- drivers/extcon/extcon-arizona.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/extcon/extcon-arizona.c +0
-0
drivers/extcon/extcon-arizona.c static void arizona_extcon_set_mode(struct arizona_extcon_info *info, int mode) · line 90
Quoted 8 lines
drivers/extcon/extcon-arizona.c +3
-2@@ -85,8 +85,9 @@ static void arizona_extcon_set_mode(struct arizona_extcon_info *info, int mode) {struct arizona *arizona = info->arizona; -gpio_set_value_cansleep (arizona->pdata.micd_pol_gpio, - info->micd_modes[mode].gpio); +if (arizona->pdata.micd_pol_gpio >0 ) +gpio_set_value_cansleep (arizona->pdata.micd_pol_gpio, + info->micd_modes[mode].gpio);
Why not use gpio_is_valid() function to test arizona->pdata.micd_pol_gpio ?
Quoted 7 lines · Chanwoo Choi
drivers/extcon/extcon-arizona.c static void arizona_extcon_set_mode(struct arizona_extcon_info *info, int mode) · line 90
Quoted 3 lines · Mark Brown
drivers/extcon/extcon-arizona.c +3
-0+if (arizona->pdata.micd_pol_gpio >0 ) +gpio_set_value_cansleep (arizona->pdata.micd_pol_gpio, + info->micd_modes[mode].gpio);Why not use
gpio_is_valid()function to testarizona->pdata.micd_pol_gpio?
Zero is normally a valid GPIO (since it's an index into a big array after all) but this is unhelpful when checking to see if someone filled in platform data as it's also the default value for uninitialised member variables. It's much more likely that someone didn't fill in a GPIO than that GPIO 0 got assigned to this.
Chanwoo Choi
maintainerQuoted 9 lines · Mark Brown
Quoted 7 lines · Chanwoo Choi
drivers/extcon/extcon-arizona.c static void arizona_extcon_set_mode(struct arizona_extcon_info *info, int mode) · line 90
Quoted 3 lines · Mark Brown
drivers/extcon/extcon-arizona.c +3
-0+if (arizona->pdata.micd_pol_gpio >0 ) +gpio_set_value_cansleep (arizona->pdata.micd_pol_gpio, + info->micd_modes[mode].gpio);Why not use
gpio_is_valid()function to testarizona->pdata.micd_pol_gpio?
Quoted 5 lines
Zero is normally a valid GPIO (since it's an index into a big array after all) but this is unhelpful when checking to see if someone filled in platform data as it's also the default value for uninitialised member variables. It's much more likely that someone didn't fill in a GPIO than that GPIO 0 got assigned to this.
OK, Applied it.
You can check it after some minutes.
- git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git (for-next branch)
Thanks,
Chanwoo Choi