Skip to contentSkip to conversation

cifs: Add handling of blank password option

PATCH Applied Jesper Nilsson 2 participants 2 messages Nov 29, 2012

Subsystems (2)
SMB client (CIFS) Kernel SMB3 server (ksmbd)
lore
Share & tools
lore

Jesper Nilsson

author
#0 lore raw

PATCH 1/1 cifs: Add handling of blank password option

The option to have a blank "pass=" already exists, and with a password specified both "pass=%s" and "password=%s" are supported. Also, both blank "user=" and "username=" are supported, making "password=" the odd man out.

Signed-off-by Jesper Nilsson <[email protected]>
---
 fs/cifs/connect.c | 1 +
 1 file changed, 1 insertion(+)
fs/cifs/connect.c +1 -0
index 5c670b9..c83f5b65 100644
@@ -186,6 +186,7 @@ static const match_table_t cifs_mount_option_tokens = {
 	{ Opt_user, "user=%s" },
 	{ Opt_user, "username=%s" },
 	{ Opt_blank_pass, "pass=" },
+	{ Opt_blank_pass, "password=" },
 	{ Opt_pass, "pass=%s" },
 	{ Opt_pass, "password=%s" },
 	{ Opt_blank_ip, "ip=" },
Signature · 6 lines
1.8.0.rc0.18.gf84667d


/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- [email protected]
Applied
#1 lore raw

merged into cifs-2.6.git

Quoted 29 lines · Jesper Nilsson

The option to have a blank "pass=" already exists, and with a password specified both "pass=%s" and "password=%s" are supported. Also, both blank "user=" and "username=" are supported, making "password=" the odd man out.

Signed-off-by Jesper Nilsson <[email protected]>
---
 fs/cifs/connect.c | 1 +
 1 file changed, 1 insertion(+)
fs/cifs/connect.c +1 -1
index 5c670b9..c83f5b65 100644
@@ -186,6 +186,7 @@ static const match_table_t cifs_mount_option_tokens = {
        { Opt_user, "user=%s" },
        { Opt_user, "username=%s" },
        { Opt_blank_pass, "pass=" },
+       { Opt_blank_pass, "password=" },
        { Opt_pass, "pass=%s" },
        { Opt_pass, "password=%s" },
        { Opt_blank_ip, "ip=" },
--

1.8.0.rc0.18.gf84667d

/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]

Signature · 3 lines
Thanks,

Steve