cifs: Change default security error message

PATCH In review Jesper Nilsson 3 participants 7 messages Nov 29, 2012 – Dec 3, 2012

Subsystems (2)

SMB client (CIFS) Kernel SMB3 server (ksmbd)

lore

Share & tools

lore

Jesper Nilsson

author

2012-11-29 17:30 UTC #0 lore raw

PATCH 1/1 cifs: Change default security error message

Hi!

Connecting with a default security mechanism prompts an KERN_ERROR output warning to the user that the default mechanism will be changed in Linux 3.3.

We're now at 3.7, so we either could remove the warning completely (if the default has been changed), or we could bump the number to what our current target for the change is.

The below patch changes the cERROR (which turns into a printk with KERN_ERROR) into a straight printk with KERN_WARNING and changes the text to indicate that it was changed in 3.3.

I expect that the patch is incorrect and that we should choose another of the alternative solutions above, but I'd like to get some input on this.

Not-Signed-off-by Jesper Nilsson <[email protected]>

---

fs/cifs/connect.c +3 -3

index c83f5b65..968456f 100644
@@ -2480,9 +2480,9 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
 	supported for many years, time to update default security mechanism */
 	if ((volume_info->secFlg == 0) && warned_on_ntlm == false) {
 		warned_on_ntlm = true;
-		cERROR(1, "default security mechanism requested.  The default "
-			"security mechanism will be upgraded from ntlm to "
-			"ntlmv2 in kernel release 3.3");
+		printk(KERN_WARNING "default security mechanism requested.  "
+			"The default security mechanism was changed "
+			" from ntlm to ntlmv2 in kernel release 3.3");
 	}
 	ses->overrideSecFlg = volume_info->secFlg;

/^JN - Jesper Nilsson

Signature · 1 line

               Jesper Nilsson -- [email protected]

This has already been changed in the cifs-2.6.git for-next branch. We had run into problems with Apple Server with ntlmv2 so it took longer than expected to test it, and it was too late for 3.7 so the patch to move to ntlmssp encapsulated ntlmv2 which removes this warning is in cifs-2.6.git and queued for 3.8

Quoted 47 lines · Jesper Nilsson

Hi!
Connecting with a default security mechanism prompts an KERN_ERROR output warning to the user that the default mechanism will be changed in Linux 3.3.
We're now at 3.7, so we either could remove the warning completely (if the default has been changed), or we could bump the number to what our current target for the change is.
The below patch changes the cERROR (which turns into a printk with KERN_ERROR) into a straight printk with KERN_WARNING and changes the text to indicate that it was changed in 3.3.
I expect that the patch is incorrect and that we should choose another of the alternative solutions above, but I'd like to get some input on this.
Not-Signed-off-by Jesper Nilsson <[email protected]>
---
fs/cifs/connect.c +3 -3
index c83f5b65..968456f 100644
@@ -2480,9 +2480,9 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
        supported for many years, time to update default security mechanism */
        if ((volume_info->secFlg == 0) && warned_on_ntlm == false) {
                warned_on_ntlm = true;
-               cERROR(1, "default security mechanism requested.  The default "
-                       "security mechanism will be upgraded from ntlm to "
-                       "ntlmv2 in kernel release 3.3");
+               printk(KERN_WARNING "default security mechanism requested.  "
+                       "The default security mechanism was changed "
+                       " from ntlm to ntlmv2 in kernel release 3.3");
        }
        ses->overrideSecFlg = volume_info->secFlg;
 
/^JN - Jesper Nilsson
--
Jesper Nilsson -- [email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 3 lines

Thanks,

Steve

Jesper Nilsson

author

2012-11-29 18:47 UTC #2 lore raw

Quoted 5 lines · Steve French

This has already been changed in the cifs-2.6.git for-next branch. We had run into problems with Apple Server with ntlmv2 so it took longer than expected to test it, and it was too late for 3.7 so the patch to move to ntlmssp encapsulated ntlmv2 which removes this warning is in cifs-2.6.git and queued for 3.8

Oh excellent. What´s the git url for the cifs-tree? The one referred to in MAINTAINERS doesn´t seem to work.

T: git git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6.git

Or possibly I´m missing something. :-)

Thanks,

/^JN - Jesper Nilsson

Signature · 1 line

               Jesper Nilsson -- [email protected]

Jesper Nilsson

author

2012-12-03 10:36 UTC #3 lore raw

PATCH 1/1 MAINTAINERS: Fix cifs-tree git url

The cifs-tree is no longer found on kernel.org,
but linux-next uses the tree on samba.org, so use that instead.

Signed-off-by Jesper Nilsson <[email protected]>

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

MAINTAINERS +1 -1

index 244b2f2..60d0e35 100644
@@ -2009,7 +2009,7 @@ L:	[email protected]
 L:	samba-technical-w/[email protected] (moderated for non-subscribers)
 W:	http://linux-cifs.samba.org/
 Q:	http://patchwork.ozlabs.org/project/linux-cifs-client/list/
-T:	git git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6.git
+T:	git git://git.samba.org/sfrench/cifs-2.6.git
 S:	Supported
 F:	Documentation/filesystems/cifs.txt
 F:	fs/cifs/

Signature · 6 lines

1.7.11.7


/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- [email protected]

Jeff Layton

2012-11-29 18:25 UTC #4 lore raw

In reply to Jesper Nilsson

Quoted 40 lines · On Thu, 29 Nov 2012 18:30:53 +0100 Jesper Nilsson…

Hi!
Connecting with a default security mechanism prompts an KERN_ERROR output warning to the user that the default mechanism will be changed in Linux 3.3.
We're now at 3.7, so we either could remove the warning completely (if the default has been changed), or we could bump the number to what our current target for the change is.
The below patch changes the cERROR (which turns into a printk with KERN_ERROR) into a straight printk with KERN_WARNING and changes the text to indicate that it was changed in 3.3.
I expect that the patch is incorrect and that we should choose another of the alternative solutions above, but I'd like to get some input on this.
Not-Signed-off-by Jesper Nilsson <[email protected]>
---
fs/cifs/connect.c +3 -3
index c83f5b65..968456f 100644
@@ -2480,9 +2480,9 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
 	supported for many years, time to update default security mechanism */
 	if ((volume_info->secFlg == 0) && warned_on_ntlm == false) {
 		warned_on_ntlm = true;
-		cERROR(1, "default security mechanism requested.  The default "
-			"security mechanism will be upgraded from ntlm to "
-			"ntlmv2 in kernel release 3.3");
+		printk(KERN_WARNING "default security mechanism requested.  "
+			"The default security mechanism was changed "
+			" from ntlm to ntlmv2 in kernel release 3.3");
 	}
 	ses->overrideSecFlg = volume_info->secFlg;
 

Quoted 1 line

/^JN - Jesper Nilsson

I think this warning has lived long enough and needs to go away. Steve supposedly has a patch that finally makes this change, but it hasn't been sent to the list yet... Steve?

Signature · 1 line

Jeff Layton <[email protected]>

Steve French

2012-11-29 18:54 UTC #5 lore raw

Quoted 43 lines · Jeff Layton

Quoted 40 lines · On Thu, 29 Nov 2012 18:30:53 +0100 Jesper Nilsson…
Hi!
Connecting with a default security mechanism prompts an KERN_ERROR output warning to the user that the default mechanism will be changed in Linux 3.3.
We're now at 3.7, so we either could remove the warning completely (if the default has been changed), or we could bump the number to what our current target for the change is.
The below patch changes the cERROR (which turns into a printk with KERN_ERROR) into a straight printk with KERN_WARNING and changes the text to indicate that it was changed in 3.3.
I expect that the patch is incorrect and that we should choose another of the alternative solutions above, but I'd like to get some input on this.
Not-Signed-off-by Jesper Nilsson <[email protected]>
---
fs/cifs/connect.c +3 -3
index c83f5b65..968456f 100644
@@ -2480,9 +2480,9 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
      supported for many years, time to update default security mechanism */
      if ((volume_info->secFlg == 0) && warned_on_ntlm == false) {
              warned_on_ntlm = true;
-             cERROR(1, "default security mechanism requested.  The default "
-                     "security mechanism will be upgraded from ntlm to "
-                     "ntlmv2 in kernel release 3.3");
+             printk(KERN_WARNING "default security mechanism requested.  "
+                     "The default security mechanism was changed "
+                     " from ntlm to ntlmv2 in kernel release 3.3");
      }
      ses->overrideSecFlg = volume_info->secFlg;
 

Quoted 5 lines

Quoted 1 line
/^JN - Jesper Nilsson
I think this warning has lived long enough and needs to go away. Steve supposedly has a patch that finally makes this change, but it hasn't been sent to the list yet... Steve?

It was posted to list on November 25th (and you even included it in your git tree on samba.org ?!)

Signature · 3 lines

Thanks,

Steve

Jeff Layton

2012-11-29 20:36 UTC #6 lore raw

Quoted 44 lines · On Thu, 29 Nov 2012 12:54:41 -0600 Steve French…

Quoted 43 lines · Jeff Layton
Quoted 40 lines · On Thu, 29 Nov 2012 18:30:53 +0100 Jesper Nilsson…
Hi!
Connecting with a default security mechanism prompts an KERN_ERROR output warning to the user that the default mechanism will be changed in Linux 3.3.
We're now at 3.7, so we either could remove the warning completely (if the default has been changed), or we could bump the number to what our current target for the change is.
The below patch changes the cERROR (which turns into a printk with KERN_ERROR) into a straight printk with KERN_WARNING and changes the text to indicate that it was changed in 3.3.
I expect that the patch is incorrect and that we should choose another of the alternative solutions above, but I'd like to get some input on this.
Not-Signed-off-by Jesper Nilsson <[email protected]>
---
fs/cifs/connect.c +3 -3
index c83f5b65..968456f 100644
@@ -2480,9 +2480,9 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
      supported for many years, time to update default security mechanism */
      if ((volume_info->secFlg == 0) && warned_on_ntlm == false) {
              warned_on_ntlm = true;
-             cERROR(1, "default security mechanism requested.  The default "
-                     "security mechanism will be upgraded from ntlm to "
-                     "ntlmv2 in kernel release 3.3");
+             printk(KERN_WARNING "default security mechanism requested.  "
+                     "The default security mechanism was changed "
+                     " from ntlm to ntlmv2 in kernel release 3.3");
      }
      ses->overrideSecFlg = volume_info->secFlg;
 

Quoted 9 lines

Quoted 5 lines
Quoted 1 line
/^JN - Jesper Nilsson
I think this warning has lived long enough and needs to go away. Steve supposedly has a patch that finally makes this change, but it hasn't been sent to the list yet... Steve?
It was posted to list on November 25th (and you even included it in your git tree on samba.org ?!)

Oops, my mistake. You're quite correct...

Signature · 1 line

Jeff Layton <[email protected]>