Skip to contentSkip to conversation

gpio: pl061: remove old comment

PATCH New Baruch Siach 3 participants 3 messages Nov 22, 2012 – Nov 30, 2012 GPIO

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 gpio: pl061: remove old comment

Since 3ab524754 (gpio: pl061: convert to use generic irq chip) we only have one spinlock in struct pl061_gpio.

Cc Rob Herring <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 drivers/gpio/gpio-pl061.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/gpio/gpio-pl061.c +1 -6
index b4b5da4..2b2e73c 100644
@@ -48,12 +48,7 @@ struct pl061_context_save_regs {
 #endif
 
 struct pl061_gpio {
-	/* Each of the two spinlocks protects a different set of hardware
-	 * regiters and data structurs. This decouples the code of the IRQ from
-	 * the GPIO code. This also makes the case of a GPIO routine call from
-	 * the IRQ code simpler.
-	 */
-	spinlock_t		lock;		/* GPIO registers */
+	spinlock_t		lock;
 
 	void __iomem		*base;
 	int			irq_base;
Signature · 1 line
1.7.10.4
Applied
#2 lore raw

PATCH 1/1 gpio: pl061: remove old comment

In reply to Baruch Siach
Quoted 5 lines · Baruch Siach

Since 3ab524754 (gpio: pl061: convert to use generic irq chip) we only have one spinlock in struct pl061_gpio.

Cc Rob Herring <[email protected]>
Signed-off-by Baruch Siach <[email protected]>

Applied, thanks.

g.

Quoted 25 lines
---
 drivers/gpio/gpio-pl061.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/gpio/gpio-pl061.c +1 -6
index b4b5da4..2b2e73c 100644
@@ -48,12 +48,7 @@ struct pl061_context_save_regs {
 #endif
 
 struct pl061_gpio {
-	/* Each of the two spinlocks protects a different set of hardware
-	 * regiters and data structurs. This decouples the code of the IRQ from
-	 * the GPIO code. This also makes the case of a GPIO routine call from
-	 * the IRQ code simpler.
-	 */
-	spinlock_t		lock;		/* GPIO registers */
+	spinlock_t		lock;
 
 	void __iomem		*base;
 	int			irq_base;
Signature · 1 line
1.7.10.4
Signature · 2 lines
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.