ARM/MXS/i.MX28: distinguish POR and wake-up event correctly
PATCH 1/1 ARM/MXS/i.MX28: distinguish POR and wake-up event correctly
When the built-in RTC in the i.MX28 is programmed to wake-up the SoC, the RTC reports two events: RST and WAKE. RST is okay in this case, because the PMIC was really powered down. But the real event is the WAKE from the RTC and should have precedence over the RST event. So, report the WAKE event for this special case.
Signed-off-by Juergen Beisert <[email protected]>
drivers/watchdog/im28wd.c +11 -0
@@ -82,6 +82,17 @@ static void __maybe_unused imx28_detect_reset_source(const struct imx28_wd *p)if (reg &MXS_RTC_PERSISTENT0_EXT_RST ) {writel (MXS_RTC_PERSISTENT0_EXT_RST , p->regs +MXS_RTC_PERSISTENT0 +MXS_RTC_CLR_ADDR ); +/* +* if the RTC has woken up the SoC, additionally the ALARM_WAKE +* bit is set. This bit should have precedence, because it +* reports the real event, why we are here. +*/ +if (reg &MXS_RTC_PERSISTENT0_ALARM_WAKE ) { +writel (MXS_RTC_PERSISTENT0_ALARM_WAKE , + p->regs +MXS_RTC_PERSISTENT0 +MXS_RTC_CLR_ADDR ); +set_reset_source (RESET_WKE ); +return ; + }set_reset_source (RESET_POR );return ; }
Signature · 7 lines
Pengutronix e.K. | Juergen Beisert | Linux Solutions for Science and Industry | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Sascha Hauer
AppliedQuoted 7 lines · Juergen Beisert
When the built-in RTC in the i.MX28 is programmed to wake-up the SoC, the RTC reports two events: RST and WAKE. RST is okay in this case, because the PMIC was really powered down. But the real event is the WAKE from the RTC and should have precedence over the RST event. So, report the WAKE event for this special case.
Signed-off-by Juergen Beisert <[email protected]>
Applied, thanks
Sascha
Quoted 34 lines
drivers/watchdog/im28wd.c +11
-0@@ -82,6 +82,17 @@ static void __maybe_unused imx28_detect_reset_source(const struct imx28_wd *p)if (reg &MXS_RTC_PERSISTENT0_EXT_RST ) {writel (MXS_RTC_PERSISTENT0_EXT_RST , p->regs +MXS_RTC_PERSISTENT0 +MXS_RTC_CLR_ADDR ); +/* +* if the RTC has woken up the SoC, additionally the ALARM_WAKE +* bit is set. This bit should have precedence, because it +* reports the real event, why we are here. +*/ +if (reg &MXS_RTC_PERSISTENT0_ALARM_WAKE ) { +writel (MXS_RTC_PERSISTENT0_ALARM_WAKE , + p->regs +MXS_RTC_PERSISTENT0 +MXS_RTC_CLR_ADDR ); +set_reset_source (RESET_WKE ); +return ; + }set_reset_source (RESET_POR );return ; }Signature · 8 lines
-- Pengutronix e.K. | Juergen Beisert | Linux Solutions for Science and Industry | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox