Drop executable flag for man pages
PATCH 1/1 Drop executable flag for man pages
--- man/Makefile.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
man/Makefile.in +2 -2
@@ -21,11 +21,11 @@ install: all if [ ! -d ${DESTDIR}/${mandir}/man8 ]; then \ install -d ${DESTDIR}/${mandir}/man8 ; \ fi - install -m755 ${MAN8} ${DESTDIR}/${mandir}/man8 + install -m655 ${MAN8} ${DESTDIR}/${mandir}/man8 if [ ! -d ${DESTDIR}/${mandir}/man5 ]; then \ install -d ${DESTDIR}/${mandir}/man5 ; \ fi - install -m755 ${MAN5} ${DESTDIR}/${mandir}/man5 + install -m655 ${MAN5} ${DESTDIR}/${mandir}/man5 clean:
Signature · 1 line
1.7.11.7
PATCH 1/1 Drop executable flag for man pages
Quoted 15 lines · Jan Pokorn?
Reported-by rpmlint <http://rpmlint.zarb.org/cgi-bin/trac.cgi>Signed-off-by Jan Pokorn? <[email protected]>--- man/Makefile.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)man/Makefile.in +0
-0@@ -21,11 +21,11 @@ install: all if [ ! -d ${DESTDIR}/${mandir}/man8 ]; then \ install -d ${DESTDIR}/${mandir}/man8 ; \ fi
man/Makefile.in install: all · line 31
Quoted 10 lines
man/Makefile.in +2
-2- install -m755 ${MAN8} ${DESTDIR}/${mandir}/man8 + install -m655 ${MAN8} ${DESTDIR}/${mandir}/man8 if [ ! -d ${DESTDIR}/${mandir}/man5 ]; then \ install -d ${DESTDIR}/${mandir}/man5 ; \ fi - install -m755 ${MAN5} ${DESTDIR}/${mandir}/man5 + install -m655 ${MAN5} ${DESTDIR}/${mandir}/man5 clean:
Should be 644, not 655.
-- Lon
PATCH 1/1 Drop executable flag for man pages
Quoted 24 lines · Lon Hohberger
Quoted 23 lines · Jan Pokorn?
Reported-by rpmlint <http://rpmlint.zarb.org/cgi-bin/trac.cgi>Signed-off-by Jan Pokorn? <[email protected]>--- man/Makefile.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)man/Makefile.in +2
-2@@ -21,11 +21,11 @@ install: all if [ ! -d ${DESTDIR}/${mandir}/man8 ]; then \ install -d ${DESTDIR}/${mandir}/man8 ; \ fi - install -m755 ${MAN8} ${DESTDIR}/${mandir}/man8 + install -m655 ${MAN8} ${DESTDIR}/${mandir}/man8 if [ ! -d ${DESTDIR}/${mandir}/man5 ]; then \ install -d ${DESTDIR}/${mandir}/man5 ; \ fi - install -m755 ${MAN5} ${DESTDIR}/${mandir}/man5 + install -m655 ${MAN5} ${DESTDIR}/${mandir}/man5
Quoted 4 lines
man/Makefile.in install: all · line 31
Quoted 2 lines
man/Makefile.in +0
-0clean:Should be 644, not 655.
Agreed; caused by paying too much attention to rpmlint check as opposed to the case itself :) Looks like the order of checks there would deserve to be reversed. But even in its current form, 655 would be spotted.
I was to argue that 444 would be even saner (lvm2 and device-mapper do this in RHEL, for example), but for some reason it seems non-standard to mark something root-non-writeable (Debian:[1], Fedora:N/A).
[1] http://www.debian.org/doc/debian-policy/ch-files.html#s-permissions-owners
Signature · 1 line
Jan