Skip to contentSkip to conversation

Enable ehci and ohci devices for exynos5250

PATCH Superseded Vivek Gautam 3 participants 11 messages Nov 8, 2012 – Dec 6, 2012

Subsystems (5)
Device tree bindings Arm (32-bit) USB Arm sub-architectures +1 more subsystems

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Vivek Gautam

author
#0 lore raw

v2 cover Enable ehci and ohci devices for exynos5250

Changes from v1:
- Changed the device node names from 'ehci' and 'ohci' to 'usb@12110000' and 'usb@12120000' as per discussion for the change 'http://www.spinics.net/lists/linux-usb/msg73993.html'
- Rebased on for-next branch of linux-samsung.

Vivek Gautam (2):
ARM: Exynos5250: Enabling ehci-s5p driver
ARM: Exynos5250: Enabling ohci-exynos driver

 .../devicetree/bindings/usb/exynos-usb.txt         |   40 ++++++++++++++++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts          |    4 ++
 arch/arm/boot/dts/exynos5250.dtsi                  |   12 ++++++
 arch/arm/mach-exynos/include/mach/map.h            |    2 +
 arch/arm/mach-exynos/mach-exynos5-dt.c             |    4 ++
 5 files changed, 62 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt
Signature · 1 line
1.7.6.5
author
#1 lore raw

PATCH v2 1/2 ARM: Exynos5250: Enabling ehci-s5p driver

Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus.

Signed-off-by Vivek Gautam <[email protected]>
Acked-by Jingoo Han <[email protected]>
---
 .../devicetree/bindings/usb/exynos-usb.txt         |   25 ++++++++++++++++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts          |    4 +++
 arch/arm/boot/dts/exynos5250.dtsi                  |    6 ++++
 arch/arm/mach-exynos/include/mach/map.h            |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c             |    2 +
 5 files changed, 38 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt
Documentation/devicetree/bindings/usb/exynos-usb.txt new file +25 -0
new file mode 100644
index 0000000..833f5cf
@@ -0,0 +1,25 @@
+Samsung Exynos SoC USB controller
+
+The USB devices interface with USB controllers on Exynos SOCs.
+The device node has following properties.
+
+EHCI
+Required properties:
+ - compatible: should be "samsung,exynos-ehci" for USB 2.0
+   EHCI controller in host mode.
+ - reg: physical base address of the controller and length of memory mapped
+   region.
+ - interrupts: interrupt number to the cpu.
+
+Optional properties:
+ - samsung,vbus-gpio:  if present, specifies the GPIO that
+   needs to be pulled up for the bus to be powered.
+
+Example:
+
+	usb at 12110000 {
+		compatible = "samsung,exynos-ehci";
+		reg = <0x12110000 0x100>;
+		interrupts = <0 71 0>;
+		samsung,vbus-gpio = <&gpx2 6 1 3 3>;
+	};
arch/arm/boot/dts/exynos5250-smdk5250.dts +4 -0
index 405009c..7c8064f 100644
@@ -193,4 +193,8 @@
 	hdmi {
 		hpd-gpio = <&gpx3 7 0xf 1 3>;
 	};
+
+	usb at 12110000 {
+		samsung,vbus-gpio = <&gpx2 6 1 3 3>;
+	};
 };
arch/arm/boot/dts/exynos5250.dtsi +6 -0
index cf6a02d..2995445 100644
@@ -238,6 +238,12 @@
 		#size-cells = <0>;
 	};
 
+	usb at 12110000 {
+		compatible = "samsung,exynos-ehci";
+		reg = <0x12110000 0x100>;
+		interrupts = <0 71 0>;
+	};
+
 	amba {
 		#address-cells = <1>;
 		#size-cells = <1>;
arch/arm/mach-exynos/include/mach/map.h +1 -0
index ef4958b..9a86b99 100644
@@ -197,6 +197,7 @@
 #define EXYNOS4_PA_EHCI			0x12580000
 #define EXYNOS4_PA_OHCI			0x12590000
 #define EXYNOS4_PA_HSPHY		0x125B0000
+#define EXYNOS5_PA_EHCI			0x12110000
 #define EXYNOS4_PA_MFC			0x13400000
 
 #define EXYNOS4_PA_UART			0x13800000
arch/arm/mach-exynos/mach-exynos5-dt.c +2 -0
index ed37273..f60994e 100644
@@ -86,6 +86,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
 				"exynos5-hdmi", NULL),
 	OF_DEV_AUXDATA("samsung,exynos5-mixer", 0x14450000,
 				"exynos5-mixer", NULL),
+	OF_DEV_AUXDATA("samsung,exynos-ehci", EXYNOS5_PA_EHCI,
+					"s5p-ehci", NULL),
 	{},
 };
Signature · 1 line
1.7.6.5
#2 lore raw

PATCH v2 1/2 ARM: Exynos5250: Enabling ehci-s5p driver

Hi all,

Quoted 92 lines · Vivek Gautam

Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus.

Signed-off-by Vivek Gautam <[email protected]>
Acked-by Jingoo Han <[email protected]>
---
 .../devicetree/bindings/usb/exynos-usb.txt         |   25 ++++++++++++++++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts          |    4 +++
 arch/arm/boot/dts/exynos5250.dtsi                  |    6 ++++
 arch/arm/mach-exynos/include/mach/map.h            |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c             |    2 +
 5 files changed, 38 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt
Documentation/devicetree/bindings/usb/exynos-usb.txt new file +25 -0
new file mode 100644
index 0000000..833f5cf
@@ -0,0 +1,25 @@
+Samsung Exynos SoC USB controller
+
+The USB devices interface with USB controllers on Exynos SOCs.
+The device node has following properties.
+
+EHCI
+Required properties:
+ - compatible: should be "samsung,exynos-ehci" for USB 2.0
+   EHCI controller in host mode.
+ - reg: physical base address of the controller and length of memory mapped
+   region.
+ - interrupts: interrupt number to the cpu.
+
+Optional properties:
+ - samsung,vbus-gpio:  if present, specifies the GPIO that
+   needs to be pulled up for the bus to be powered.
+
+Example:
+
+       usb at 12110000 {
+               compatible = "samsung,exynos-ehci";
+               reg = <0x12110000 0x100>;
+               interrupts = <0 71 0>;
+               samsung,vbus-gpio = <&gpx2 6 1 3 3>;
+       };
arch/arm/boot/dts/exynos5250-smdk5250.dts +4 -0
index 405009c..7c8064f 100644
@@ -193,4 +193,8 @@
        hdmi {
                hpd-gpio = <&gpx3 7 0xf 1 3>;
        };
+
+       usb at 12110000 {
+               samsung,vbus-gpio = <&gpx2 6 1 3 3>;
+       };
 };
arch/arm/boot/dts/exynos5250.dtsi +6 -0
index cf6a02d..2995445 100644
@@ -238,6 +238,12 @@
                #size-cells = <0>;
        };
 
+       usb at 12110000 {
+               compatible = "samsung,exynos-ehci";
+               reg = <0x12110000 0x100>;
+               interrupts = <0 71 0>;
+       };
+
        amba {
                #address-cells = <1>;
                #size-cells = <1>;
arch/arm/mach-exynos/include/mach/map.h +1 -0
index ef4958b..9a86b99 100644
@@ -197,6 +197,7 @@
 #define EXYNOS4_PA_EHCI                        0x12580000
 #define EXYNOS4_PA_OHCI                        0x12590000
 #define EXYNOS4_PA_HSPHY               0x125B0000
+#define EXYNOS5_PA_EHCI                        0x12110000
 #define EXYNOS4_PA_MFC                 0x13400000
 
 #define EXYNOS4_PA_UART                        0x13800000
arch/arm/mach-exynos/mach-exynos5-dt.c +0 -0
index ed37273..f60994e 100644

arch/arm/mach-exynos/mach-exynos5-dt.c static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = { · line 90

Quoted 5 lines
arch/arm/mach-exynos/mach-exynos5-dt.c +2 -0
@@ -86,6 +86,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
                                "exynos5-hdmi", NULL),
        OF_DEV_AUXDATA("samsung,exynos5-mixer", 0x14450000,
                                "exynos5-mixer", NULL),
+       OF_DEV_AUXDATA("samsung,exynos-ehci", EXYNOS5_PA_EHCI,
+                                       "s5p-ehci", NULL),

missed the alignment here :-(

Quoted 10 lines
arch/arm/mach-exynos/mach-exynos5-dt.c +0 -1
        {},
 };
 
--

1.7.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Thanks & Regards
Vivek

author
#3 lore raw

PATCH v2 1/2 ARM: Exynos5250: Enabling ehci-s5p driver

Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus.

Signed-off-by Vivek Gautam <[email protected]>
Acked-by Jingoo Han <[email protected]>
---
 .../devicetree/bindings/usb/exynos-usb.txt         |   25 ++++++++++++++++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts          |    4 +++
 arch/arm/boot/dts/exynos5250.dtsi                  |    6 ++++
 arch/arm/mach-exynos/include/mach/map.h            |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c             |    2 +
 5 files changed, 38 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt
Documentation/devicetree/bindings/usb/exynos-usb.txt new file +25 -0
new file mode 100644
index 0000000..833f5cf
@@ -0,0 +1,25 @@
+Samsung Exynos SoC USB controller
+
+The USB devices interface with USB controllers on Exynos SOCs.
+The device node has following properties.
+
+EHCI
+Required properties:
+ - compatible: should be "samsung,exynos-ehci" for USB 2.0
+   EHCI controller in host mode.
+ - reg: physical base address of the controller and length of memory mapped
+   region.
+ - interrupts: interrupt number to the cpu.
+
+Optional properties:
+ - samsung,vbus-gpio:  if present, specifies the GPIO that
+   needs to be pulled up for the bus to be powered.
+
+Example:
+
+	usb@12110000 {
+		compatible = "samsung,exynos-ehci";
+		reg = <0x12110000 0x100>;
+		interrupts = <0 71 0>;
+		samsung,vbus-gpio = <&gpx2 6 1 3 3>;
+	};
arch/arm/boot/dts/exynos5250-smdk5250.dts +4 -0
index 405009c..7c8064f 100644
@@ -193,4 +193,8 @@
 	hdmi {
 		hpd-gpio = <&gpx3 7 0xf 1 3>;
 	};
+
+	usb@12110000 {
+		samsung,vbus-gpio = <&gpx2 6 1 3 3>;
+	};
 };
arch/arm/boot/dts/exynos5250.dtsi +6 -0
index cf6a02d..2995445 100644
@@ -238,6 +238,12 @@
 		#size-cells = <0>;
 	};
 
+	usb@12110000 {
+		compatible = "samsung,exynos-ehci";
+		reg = <0x12110000 0x100>;
+		interrupts = <0 71 0>;
+	};
+
 	amba {
 		#address-cells = <1>;
 		#size-cells = <1>;
arch/arm/mach-exynos/include/mach/map.h +1 -0
index ef4958b..9a86b99 100644
@@ -197,6 +197,7 @@
 #define EXYNOS4_PA_EHCI			0x12580000
 #define EXYNOS4_PA_OHCI			0x12590000
 #define EXYNOS4_PA_HSPHY		0x125B0000
+#define EXYNOS5_PA_EHCI			0x12110000
 #define EXYNOS4_PA_MFC			0x13400000
 
 #define EXYNOS4_PA_UART			0x13800000
arch/arm/mach-exynos/mach-exynos5-dt.c +2 -0
index ed37273..89fa624 100644
@@ -86,6 +86,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
 				"exynos5-hdmi", NULL),
 	OF_DEV_AUXDATA("samsung,exynos5-mixer", 0x14450000,
 				"exynos5-mixer", NULL),
+	OF_DEV_AUXDATA("samsung,exynos-ehci", EXYNOS5_PA_EHCI,
+				"s5p-ehci", NULL),
 	{},
 };
Signature · 1 line
1.7.6.5
#4 lore raw

PATCH v2 1/2 ARM: Exynos5250: Enabling ehci-s5p driver

Hi Kukjin,

Quoted 3 lines · Vivek Gautam

Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus.

Any thoughts about this please ?

Quoted 104 lines
Signed-off-by Vivek Gautam <[email protected]>
Acked-by Jingoo Han <[email protected]>
---
 .../devicetree/bindings/usb/exynos-usb.txt         |   25 ++++++++++++++++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts          |    4 +++
 arch/arm/boot/dts/exynos5250.dtsi                  |    6 ++++
 arch/arm/mach-exynos/include/mach/map.h            |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c             |    2 +
 5 files changed, 38 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt
Documentation/devicetree/bindings/usb/exynos-usb.txt new file +25 -0
new file mode 100644
index 0000000..833f5cf
@@ -0,0 +1,25 @@
+Samsung Exynos SoC USB controller
+
+The USB devices interface with USB controllers on Exynos SOCs.
+The device node has following properties.
+
+EHCI
+Required properties:
+ - compatible: should be "samsung,exynos-ehci" for USB 2.0
+   EHCI controller in host mode.
+ - reg: physical base address of the controller and length of memory mapped
+   region.
+ - interrupts: interrupt number to the cpu.
+
+Optional properties:
+ - samsung,vbus-gpio:  if present, specifies the GPIO that
+   needs to be pulled up for the bus to be powered.
+
+Example:
+
+       usb at 12110000 {
+               compatible = "samsung,exynos-ehci";
+               reg = <0x12110000 0x100>;
+               interrupts = <0 71 0>;
+               samsung,vbus-gpio = <&gpx2 6 1 3 3>;
+       };
arch/arm/boot/dts/exynos5250-smdk5250.dts +4 -0
index 405009c..7c8064f 100644
@@ -193,4 +193,8 @@
        hdmi {
                hpd-gpio = <&gpx3 7 0xf 1 3>;
        };
+
+       usb at 12110000 {
+               samsung,vbus-gpio = <&gpx2 6 1 3 3>;
+       };
 };
arch/arm/boot/dts/exynos5250.dtsi +6 -0
index cf6a02d..2995445 100644
@@ -238,6 +238,12 @@
                #size-cells = <0>;
        };
 
+       usb at 12110000 {
+               compatible = "samsung,exynos-ehci";
+               reg = <0x12110000 0x100>;
+               interrupts = <0 71 0>;
+       };
+
        amba {
                #address-cells = <1>;
                #size-cells = <1>;
arch/arm/mach-exynos/include/mach/map.h +1 -0
index ef4958b..9a86b99 100644
@@ -197,6 +197,7 @@
 #define EXYNOS4_PA_EHCI                        0x12580000
 #define EXYNOS4_PA_OHCI                        0x12590000
 #define EXYNOS4_PA_HSPHY               0x125B0000
+#define EXYNOS5_PA_EHCI                        0x12110000
 #define EXYNOS4_PA_MFC                 0x13400000
 
 #define EXYNOS4_PA_UART                        0x13800000
arch/arm/mach-exynos/mach-exynos5-dt.c +2 -1
index ed37273..89fa624 100644
@@ -86,6 +86,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
                                "exynos5-hdmi", NULL),
        OF_DEV_AUXDATA("samsung,exynos5-mixer", 0x14450000,
                                "exynos5-mixer", NULL),
+       OF_DEV_AUXDATA("samsung,exynos-ehci", EXYNOS5_PA_EHCI,
+                               "s5p-ehci", NULL),
        {},
 };
 
--

1.7.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
Thanks & Regards
Vivek
#5 lore raw

PATCH v2 1/2 ARM: Exynos5250: Enabling ehci-s5p driver

In reply to Vivek Gautam
Quoted 20 lines · Vivek Gautam

Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus.

Signed-off-by Vivek Gautam <[email protected]>
Acked-by Jingoo Han <[email protected]>
---
 .../devicetree/bindings/usb/exynos-usb.txt         |   25 ++++++++++++++++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts          |    4 +++
 arch/arm/boot/dts/exynos5250.dtsi                  |    6 ++++
 arch/arm/mach-exynos/include/mach/map.h            |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c             |    2 +
 5 files changed, 38 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt
Documentation/devicetree/bindings/usb/exynos-usb.txt new file +0 -0
new file mode 100644
index 0000000..833f5cf

Documentation/devicetree/bindings/usb/exynos-usb.txt line 8

Quoted 8 lines
Documentation/devicetree/bindings/usb/exynos-usb.txt new file +8 -0
@@ -0,0 +1,25 @@
+Samsung Exynos SoC USB controller
+
+The USB devices interface with USB controllers on Exynos SOCs.
+The device node has following properties.
+
+EHCI
+Required properties:
+ - compatible: should be "samsung,exynos-ehci" for USB 2.0

Ditto here. Please be specific in compatible strings. "samsung,exynos5250-ehci"

Otherwise the binding looks fine to me.

g.

#6 lore raw

PATCH v2 1/2 ARM: Exynos5250: Enabling ehci-s5p driver

Quoted 32 lines · Grant Likely
Quoted 20 lines · Vivek Gautam

Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus.

Signed-off-by Vivek Gautam <[email protected]>
Acked-by Jingoo Han <[email protected]>
---
 .../devicetree/bindings/usb/exynos-usb.txt         |   25 ++++++++++++++++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts          |    4 +++
 arch/arm/boot/dts/exynos5250.dtsi                  |    6 ++++
 arch/arm/mach-exynos/include/mach/map.h            |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c             |    2 +
 5 files changed, 38 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt
Documentation/devicetree/bindings/usb/exynos-usb.txt new file +0 -0
new file mode 100644
index 0000000..833f5cf

Documentation/devicetree/bindings/usb/exynos-usb.txt line 8

Quoted 8 lines
Documentation/devicetree/bindings/usb/exynos-usb.txt new file +8 -0
@@ -0,0 +1,25 @@
+Samsung Exynos SoC USB controller
+
+The USB devices interface with USB controllers on Exynos SOCs.
+The device node has following properties.
+
+EHCI
+Required properties:
+ - compatible: should be "samsung,exynos-ehci" for USB 2.0

Ditto here. Please be specific in compatible strings. "samsung,exynos5250-ehci"

Quoted 2 lines

Otherwise the binding looks fine to me.

Again here, the compatible string is added as per "drivers/usb/host/ehci-s5p.c", since same driver works across exynos. Please suggest do we need driver side change also to accomodate this ?

Quoted 6 lines

g.

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss at lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Signature · 2 lines
Thanks & Regards
Vivek
author
#7 lore raw

PATCH v2 2/2 ARM: Exynos5250: Enabling ohci-exynos driver

In reply to Vivek Gautam

Adding OHCI device tree node for Exynos5250 along with the device base address.

Signed-off-by Vivek Gautam <[email protected]>
Acked-by Jingoo Han <[email protected]>
---
 .../devicetree/bindings/usb/exynos-usb.txt         |   15 +++++++++++++++
 arch/arm/boot/dts/exynos5250.dtsi                  |    6 ++++++
 arch/arm/mach-exynos/include/mach/map.h            |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c             |    2 ++
 4 files changed, 24 insertions(+), 0 deletions(-)
Documentation/devicetree/bindings/usb/exynos-usb.txt +15 -0
index 833f5cf..5ff3def1 100644
@@ -23,3 +23,18 @@ Example:
 		interrupts = <0 71 0>;
 		samsung,vbus-gpio = <&gpx2 6 1 3 3>;
 	};
+
+OHCI
+Required properties:
+ - compatible: should be "samsung,exynos-ohci" for USB 2.0
+   OHCI companion controller in host mode.
+ - reg: physical base address of the controller and length of memory mapped
+   region.
+ - interrupts: interrupt number to the cpu.
+
+Example:
+	usb@12120000 {
+		compatible = "samsung,exynos-ohci";
+		reg = <0x12120000 0x100>;
+		interrupts = <0 71 0>;
+	};
arch/arm/boot/dts/exynos5250.dtsi +6 -0
index 2995445..f18abe0 100644
@@ -244,6 +244,12 @@
 		interrupts = <0 71 0>;
 	};
 
+	usb@12120000 {
+		compatible = "samsung,exynos-ohci";
+		reg = <0x12120000 0x100>;
+		interrupts = <0 71 0>;
+	};
+
 	amba {
 		#address-cells = <1>;
 		#size-cells = <1>;
arch/arm/mach-exynos/include/mach/map.h +1 -0
index 9a86b99..471ffaf 100644
@@ -198,6 +198,7 @@
 #define EXYNOS4_PA_OHCI			0x12590000
 #define EXYNOS4_PA_HSPHY		0x125B0000
 #define EXYNOS5_PA_EHCI			0x12110000
+#define EXYNOS5_PA_OHCI			0x12120000
 #define EXYNOS4_PA_MFC			0x13400000
 
 #define EXYNOS4_PA_UART			0x13800000
arch/arm/mach-exynos/mach-exynos5-dt.c +2 -0
index f60994e..6348acb 100644
@@ -88,6 +88,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
 				"exynos5-mixer", NULL),
 	OF_DEV_AUXDATA("samsung,exynos-ehci", EXYNOS5_PA_EHCI,
 					"s5p-ehci", NULL),
+	OF_DEV_AUXDATA("samsung,exynos-ohci", EXYNOS5_PA_OHCI,
+					"exynos-ohci", NULL),
 	{},
 };
Signature · 1 line
1.7.6.5
#8 lore raw

PATCH v2 2/2 ARM: Exynos5250: Enabling ohci-exynos driver

Hi all,

Quoted 69 lines · Vivek Gautam

Adding OHCI device tree node for Exynos5250 along with the device base address.

Signed-off-by Vivek Gautam <[email protected]>
Acked-by Jingoo Han <[email protected]>
---
 .../devicetree/bindings/usb/exynos-usb.txt         |   15 +++++++++++++++
 arch/arm/boot/dts/exynos5250.dtsi                  |    6 ++++++
 arch/arm/mach-exynos/include/mach/map.h            |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c             |    2 ++
 4 files changed, 24 insertions(+), 0 deletions(-)
Documentation/devicetree/bindings/usb/exynos-usb.txt +15 -0
index 833f5cf..5ff3def1 100644
@@ -23,3 +23,18 @@ Example:
                interrupts = <0 71 0>;
                samsung,vbus-gpio = <&gpx2 6 1 3 3>;
        };
+
+OHCI
+Required properties:
+ - compatible: should be "samsung,exynos-ohci" for USB 2.0
+   OHCI companion controller in host mode.
+ - reg: physical base address of the controller and length of memory mapped
+   region.
+ - interrupts: interrupt number to the cpu.
+
+Example:
+       usb at 12120000 {
+               compatible = "samsung,exynos-ohci";
+               reg = <0x12120000 0x100>;
+               interrupts = <0 71 0>;
+       };
arch/arm/boot/dts/exynos5250.dtsi +6 -0
index 2995445..f18abe0 100644
@@ -244,6 +244,12 @@
                interrupts = <0 71 0>;
        };
 
+       usb at 12120000 {
+               compatible = "samsung,exynos-ohci";
+               reg = <0x12120000 0x100>;
+               interrupts = <0 71 0>;
+       };
+
        amba {
                #address-cells = <1>;
                #size-cells = <1>;
arch/arm/mach-exynos/include/mach/map.h +1 -0
index 9a86b99..471ffaf 100644
@@ -198,6 +198,7 @@
 #define EXYNOS4_PA_OHCI                        0x12590000
 #define EXYNOS4_PA_HSPHY               0x125B0000
 #define EXYNOS5_PA_EHCI                        0x12110000
+#define EXYNOS5_PA_OHCI                        0x12120000
 #define EXYNOS4_PA_MFC                 0x13400000
 
 #define EXYNOS4_PA_UART                        0x13800000
arch/arm/mach-exynos/mach-exynos5-dt.c +0 -0
index f60994e..6348acb 100644

arch/arm/mach-exynos/mach-exynos5-dt.c static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = { · line 92

Quoted 5 lines
arch/arm/mach-exynos/mach-exynos5-dt.c +2 -0
@@ -88,6 +88,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
                                "exynos5-mixer", NULL),
        OF_DEV_AUXDATA("samsung,exynos-ehci", EXYNOS5_PA_EHCI,
                                        "s5p-ehci", NULL),
+       OF_DEV_AUXDATA("samsung,exynos-ohci", EXYNOS5_PA_OHCI,
+                                       "exynos-ohci", NULL),

missed the alignment here :-(

Quoted 10 lines
arch/arm/mach-exynos/mach-exynos5-dt.c +0 -1
        {},
 };
 
--

1.7.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Thanks & Regards
Vivek

author
#9 lore raw

PATCH v2 2/2 ARM: Exynos5250: Enabling ohci-exynos driver

Adding OHCI device tree node for Exynos5250 along with the device base address.

Signed-off-by Vivek Gautam <[email protected]>
Acked-by Jingoo Han <[email protected]>
---
 .../devicetree/bindings/usb/exynos-usb.txt         |   15 +++++++++++++++
 arch/arm/boot/dts/exynos5250.dtsi                  |    6 ++++++
 arch/arm/mach-exynos/include/mach/map.h            |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c             |    2 ++
 4 files changed, 24 insertions(+), 0 deletions(-)
Documentation/devicetree/bindings/usb/exynos-usb.txt +15 -0
index 833f5cf..5ff3def1 100644
@@ -23,3 +23,18 @@ Example:
 		interrupts = <0 71 0>;
 		samsung,vbus-gpio = <&gpx2 6 1 3 3>;
 	};
+
+OHCI
+Required properties:
+ - compatible: should be "samsung,exynos-ohci" for USB 2.0
+   OHCI companion controller in host mode.
+ - reg: physical base address of the controller and length of memory mapped
+   region.
+ - interrupts: interrupt number to the cpu.
+
+Example:
+	usb at 12120000 {
+		compatible = "samsung,exynos-ohci";
+		reg = <0x12120000 0x100>;
+		interrupts = <0 71 0>;
+	};
arch/arm/boot/dts/exynos5250.dtsi +6 -0
index 2995445..f18abe0 100644
@@ -244,6 +244,12 @@
 		interrupts = <0 71 0>;
 	};
 
+	usb at 12120000 {
+		compatible = "samsung,exynos-ohci";
+		reg = <0x12120000 0x100>;
+		interrupts = <0 71 0>;
+	};
+
 	amba {
 		#address-cells = <1>;
 		#size-cells = <1>;
arch/arm/mach-exynos/include/mach/map.h +1 -0
index 9a86b99..471ffaf 100644
@@ -198,6 +198,7 @@
 #define EXYNOS4_PA_OHCI			0x12590000
 #define EXYNOS4_PA_HSPHY		0x125B0000
 #define EXYNOS5_PA_EHCI			0x12110000
+#define EXYNOS5_PA_OHCI			0x12120000
 #define EXYNOS4_PA_MFC			0x13400000
 
 #define EXYNOS4_PA_UART			0x13800000
arch/arm/mach-exynos/mach-exynos5-dt.c +2 -0
index 89fa624..c03f3dd 100644
@@ -88,6 +88,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
 				"exynos5-mixer", NULL),
 	OF_DEV_AUXDATA("samsung,exynos-ehci", EXYNOS5_PA_EHCI,
 				"s5p-ehci", NULL),
+	OF_DEV_AUXDATA("samsung,exynos-ohci", EXYNOS5_PA_OHCI,
+				"exynos-ohci", NULL),
 	{},
 };
Signature · 1 line
1.7.6.5
#10 lore raw

PATCH v2 2/2 ARM: Exynos5250: Enabling ohci-exynos driver

Hi Kukjin,

Quoted 3 lines · Vivek Gautam

Adding OHCI device tree node for Exynos5250 along with the device base address.

Any thoughts about this please ?

Quoted 81 lines
Signed-off-by Vivek Gautam <[email protected]>
Acked-by Jingoo Han <[email protected]>
---
 .../devicetree/bindings/usb/exynos-usb.txt         |   15 +++++++++++++++
 arch/arm/boot/dts/exynos5250.dtsi                  |    6 ++++++
 arch/arm/mach-exynos/include/mach/map.h            |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c             |    2 ++
 4 files changed, 24 insertions(+), 0 deletions(-)
Documentation/devicetree/bindings/usb/exynos-usb.txt +15 -0
index 833f5cf..5ff3def1 100644
@@ -23,3 +23,18 @@ Example:
                interrupts = <0 71 0>;
                samsung,vbus-gpio = <&gpx2 6 1 3 3>;
        };
+
+OHCI
+Required properties:
+ - compatible: should be "samsung,exynos-ohci" for USB 2.0
+   OHCI companion controller in host mode.
+ - reg: physical base address of the controller and length of memory mapped
+   region.
+ - interrupts: interrupt number to the cpu.
+
+Example:
+       usb at 12120000 {
+               compatible = "samsung,exynos-ohci";
+               reg = <0x12120000 0x100>;
+               interrupts = <0 71 0>;
+       };
arch/arm/boot/dts/exynos5250.dtsi +6 -0
index 2995445..f18abe0 100644
@@ -244,6 +244,12 @@
                interrupts = <0 71 0>;
        };
 
+       usb at 12120000 {
+               compatible = "samsung,exynos-ohci";
+               reg = <0x12120000 0x100>;
+               interrupts = <0 71 0>;
+       };
+
        amba {
                #address-cells = <1>;
                #size-cells = <1>;
arch/arm/mach-exynos/include/mach/map.h +1 -0
index 9a86b99..471ffaf 100644
@@ -198,6 +198,7 @@
 #define EXYNOS4_PA_OHCI                        0x12590000
 #define EXYNOS4_PA_HSPHY               0x125B0000
 #define EXYNOS5_PA_EHCI                        0x12110000
+#define EXYNOS5_PA_OHCI                        0x12120000
 #define EXYNOS4_PA_MFC                 0x13400000
 
 #define EXYNOS4_PA_UART                        0x13800000
arch/arm/mach-exynos/mach-exynos5-dt.c +2 -1
index 89fa624..c03f3dd 100644
@@ -88,6 +88,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
                                "exynos5-mixer", NULL),
        OF_DEV_AUXDATA("samsung,exynos-ehci", EXYNOS5_PA_EHCI,
                                "s5p-ehci", NULL),
+       OF_DEV_AUXDATA("samsung,exynos-ohci", EXYNOS5_PA_OHCI,
+                               "exynos-ohci", NULL),
        {},
 };
 
--

1.7.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
Thanks & Regards
Vivek