Skip to contentSkip to conversation

ext4: unneeded variable in ext4_try_add_inline_entry()

PATCH Applied Dan Carpenter 2 participants 2 messages Dec 5, 2012 – Dec 6, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext4: unneeded variable in ext4_try_add_inline_entry()

We never actually use "backup_buf" so I have removed it.

fs/ext4/inline.c +1 -2
index 1fe0cc4..26e4218 100644
@@ -1224,7 +1224,7 @@ int ext4_try_add_inline_entry(handle_t *handle, struct dentry *dentry,
 			      struct inode *inode)
 {
 	int ret, inline_size;
-	void *inline_start, *backup_buf = NULL;
+	void *inline_start;
 	struct ext4_iloc iloc;
 	struct inode *dir = dentry->d_parent->d_inode;
 
@@ -1276,7 +1276,6 @@ int ext4_try_add_inline_entry(handle_t *handle, struct dentry *dentry,
 	ret = ext4_convert_inline_data_nolock(handle, dir, &iloc);
 
 out:
-	kfree(backup_buf);
 	ext4_mark_inode_dirty(handle, dir);
 	up_write(&EXT4_I(dir)->xattr_sem);
 	brelse(iloc.bh);
maintainer Applied
#1 lore raw
Quoted 3 lines · Dan Carpenter

We never actually use "backup_buf" so I have removed it.

I've merged this into the inline data patches; thanks for reporting it!

- Ted