EXYNOS5: Add FDT support for USB

Adding fdt support to ehci-exynos in order to parse register base addresses from the device node.

Signed-off-by Vivek Gautam <[email protected]>

Signed-off-by Rajeshwari Shinde <[email protected]>

---
Chnages in V2:
- Removed checkpatch errors.

 drivers/usb/host/ehci-exynos.c |   59

++++++++++++++++++++++++++++++++++++--- 1 files changed, 54 insertions(+), 5 deletions(-)

(quoted diff) +0 -0

b/drivers/usb/host/ehci-exynos.c index 9f0ed06..f9189a5 100644

drivers/usb/host/ehci-exynos.c +5 -0

@@ -21,6 +21,8 @@
  */
 
 #include <common.h>
+#include <fdtdec.h>
+#include <libfdt.h>
 #include <usb.h>
 #include <asm/arch/cpu.h>
 #include <asm/arch/ehci.h>

@@ -28,6 +30,9 @@
 #include <asm/arch/power.h>
 #include "ehci.h"
 
+/* Declare global data pointer */
+DECLARE_GLOBAL_DATA_PTR;
+
 /* Setup the EHCI host controller. */
 static void setup_usb_phy(struct exynos_usb_phy *usb)
 {

@@ -86,12 +91,39 @@ static void reset_usb_phy(struct exynos_usb_phy *usb)
  */
 int ehci_hcd_init(int index, struct ehci_hccr **hccr, struct ehci_hcor

Dear Rajeshwari Shinde,

Quoted 48 lines

Adding fdt support to ehci-exynos in order to parse register base addresses from the device node.

Signed-off-by Vivek Gautam <[email protected]>

Signed-off-by Rajeshwari Shinde <[email protected]>

---
Chnages in V2:
- Removed checkpatch errors.

 drivers/usb/host/ehci-exynos.c |   59

++++++++++++++++++++++++++++++++++++--- 1 files changed, 54 insertions(+), 5 deletions(-)

(quoted diff) +0 -0

b/drivers/usb/host/ehci-exynos.c index 9f0ed06..f9189a5 100644

drivers/usb/host/ehci-exynos.c +13 -1

@@ -21,6 +21,8 @@
  */
 
 #include <common.h>
+#include <fdtdec.h>
+#include <libfdt.h>
 #include <usb.h>
 #include <asm/arch/cpu.h>
 #include <asm/arch/ehci.h>

@@ -28,6 +30,9 @@
 #include <asm/arch/power.h>
 #include "ehci.h"
 
+/* Declare global data pointer */
+DECLARE_GLOBAL_DATA_PTR;
+
 /* Setup the EHCI host controller. */
 static void setup_usb_phy(struct exynos_usb_phy *usb)
 {

@@ -86,12 +91,39 @@ static void reset_usb_phy(struct exynos_usb_phy *usb)
  */
 int ehci_hcd_init(int index, struct ehci_hccr **hccr, struct ehci_hcor
 **hcor) {
-     struct exynos_usb_phy *usb;
+     struct exynos_usb_phy *usb = NULL;
+     unsigned int *hcd = NULL;
+     unsigned int node;
+
+     node = fdtdec_next_compatible(gd->fdt_blob, 0,
+                                     COMPAT_SAMSUNG_EXYNOS_EHCI);
+     if (node <= 0) {
+             debug("EHCI: Can't get device tree node for ehci\n");

[...]

error output should be really puts() or printf() ...

You can also use errno.h instead of -1.

Rest is good

Quoted 3 lines

[...]

error output should be really puts() or printf() ...

Ick that bloats the code badly for an uncommon case. Would really prefer to avoid this.

Quoted 1 line

You can also use errno.h instead of -1.

True, it might help debugging, although many times it is hard to map the error onto a suitable number designed for Linux. This 'return -1' is pretty common in U-Boot (generic error).

Dear Simon Glass,

[...]

Quoted 2 lines

Quoted 2 lines

[...]

Quoted 4 lines

Quoted 1 line

error output should be really puts() or printf() ...

Ick that bloats the code badly for an uncommon case. Would really prefer to avoid this.

What do you mean? Are you saying this debug() is correct and this is triggered often? How come?

Quoted 6 lines

Quoted 2 lines

You can also use errno.h instead of -1.

True, it might help debugging, although many times it is hard to map the error onto a suitable number designed for Linux. This 'return -1' is pretty common in U-Boot (generic error).

I know, but it'd be nice if this changed. Just a suggestion.

Best regards,
Marek Vasut

Hi Marek,

Quoted 6 lines · Marek Vasut

Dear Simon Glass,

[...]

Quoted 2 lines

Quoted 2 lines

[...]

Quoted 7 lines

Quoted 4 lines

Quoted 1 line

error output should be really puts() or printf() ...

Ick that bloats the code badly for an uncommon case. Would really prefer to avoid this.

What do you mean? Are you saying this debug() is correct and this is triggered often? How come?

I mean that debug() in a driver does not generate any code unless DEBUG is defined in that module. The way I do it is when I have a problem in a module I define DEBUG there, which makes all the messages work. But then in the normal case (when not debugging) the code size is not bloated by messages.

So I much prefer debug() to printf() for uncommon messages in drivers, etc.

Quoted 6 lines

Quoted 5 lines

Quoted 1 line

You can also use errno.h instead of -1.

True, it might help debugging, although many times it is hard to map the error onto a suitable number designed for Linux. This 'return -1' is pretty common in U-Boot (generic error).

Quoted 1 line

I know, but it'd be nice if this changed. Just a suggestion.

Yes agreed. I recently had a driver which could fail in about 12 different places (different stages of hardware init), so I just created an enum for 12 errors. It wouldn't have been sensible in that case to try and fail to map those onto the errno errors, but in many cases (with fewer error conditions) it would be useful.

This patch adds the device node required for USB

Signed-off-by Vivek Gautam <[email protected]>

---
Chnages in V2:
- None

 arch/arm/dts/exynos5250.dtsi |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

arch/arm/dts/exynos5250.dtsi +0 -0

index 2073ef2..dc727fc 100644
@@ -143,4 +143,11 @@
 		reg = <0x131b0000 0x30>;