Skip to contentSkip to conversation

b43-fwcutter: pack correct ucode for brcmsmac fw

PATCH New Hauke Mehrtens 2 participants 4 messages Dec 6, 2012 – Dec 7, 2012

lore
Share & tools
lore

Hauke Mehrtens

author
#0 lore raw

PATCH 1/1 b43-fwcutter: pack correct ucode for brcmsmac fw

brcmsmac supports only lcn-phy core with core rev 24 and no n-phy cores with core rev 24, so pack the correct ucode image into the firmware package.

Signed-off-by Hauke Mehrtens <[email protected]>
---
 fwcutter/fwcutter.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fwcutter/fwcutter.c +2 -2
index 6f5788c..e9082f9 100644
@@ -449,7 +449,7 @@ static int brcmsmac_name_to_idx(const char *name)
 		return D11N0INITVALS16;
 	} else if (strcmp("ucode16_mimo", name) == 0) {
 		return D11UCODE_OVERSIGHT16_MIMO;
-	} else if (strcmp("ucode24_mimo", name) == 0) {
+	} else if (strcmp("ucode24_lcn", name) == 0) {
 		return D11UCODE_OVERSIGHT24_LCN;
 	}
 	return 0;

@@ -459,7 +459,7 @@ static int brcmsmac_name_to_size_idx(const char *name)
 {
 	if (strcmp("ucode16_mimo", name) == 0) {
 		return D11UCODE_OVERSIGHT16_MIMOSZ;
-	} else if (strcmp("ucode24_mimo", name) == 0) {
+	} else if (strcmp("ucode24_lcn", name) == 0) {
 		return D11UCODE_OVERSIGHT24_LCNSZ;
 	}
 	return 0;
Signature · 1 line
1.7.10.4
Applied
#1 lore raw

PATCH 1/1 b43-fwcutter: pack correct ucode for brcmsmac fw

Quoted 5 lines · On Thu, 6 Dec 2012 22:44:58 +0100 Hauke Mehrtens <[email protected]> wrote:

brcmsmac supports only lcn-phy core with core rev 24 and no n-phy cores with core rev 24, so pack the correct ucode image into the firmware package.

Signed-off-by Hauke Mehrtens <[email protected]>

Thanks, applied.

Should a new version be released?

Signature · 10 lines
Greetings, Michael.

PGP encryption is encouraged / 908D8B0E
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20121207/15797c10/attachment.sig>
author
#2 lore raw

PATCH 1/1 b43-fwcutter: pack correct ucode for brcmsmac fw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 7 lines · Michael B?sch
Quoted 4 lines · On Thu, 6 Dec 2012 22:44:58 +0100 Hauke Mehrtens <[email protected]> wrote:

brcmsmac supports only lcn-phy core with core rev 24 and no n-phy cores with core rev 24, so pack the correct ucode image into the firmware package.

Quoted 6 lines
Quoted 1 line
Signed-off-by Hauke Mehrtens <[email protected]>

Thanks, applied.

Should a new version be released?

Yes I thing a new release would be nice, as the wrong firmware will probably not work and could cause people some trouble.

Hauke
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQIcBAEBAgAGBQJQwhVrAAoJEIZ0px9YPRMymAwP/0/4KPUe+YlLQWuUU9xxVqo9 c0Bzd8NAeahnJlZ0oRT9xW9GC1YiwvqPhdi2xrw/xWm75m9hBa0pYDzpLnbMlIH4 LhjICx+I+GVZBQAKOK/3RVDpZDylOoMIffPGSXe/FHr92TR8a0UaQWTDL4PojFiK X6m/gQYYp6MQuwra36rwC+E/oEbJ8E+tYXpvhs+OR1qMFce8qrgsWusJDH2fbLu6 CgeprpKS2QauM/FoR9RAlVRBvri5dDSrL3xCdCrTw+F3BjyyVHw9DT8CVdnImLLI qNnzxD+ATpWrahg+xJutKk+JLW5LbzUSXf5YpAfktXEIOiFD3hhPZ0a82lA1mqaZ JKp6y83cPHihGyzBcoMWzpuoEK7t4MaVoy+4mwfawpoXSbsVtjrhVjR2rA2XoQ6F rtdIz8lT9qgr1aZFYqBQx4x+ux59+ktXeKZVk7/hzp0zwhJj9HCLVk2flo7baY2+ AvCYOcq9qB3PW7BBaPFos82uKVsSzmEopKeGgyjmWu18t2RGH5zGztne2NNRbTv+ h3EiURv9Iq2xZfuraXSdKqhtbFnU+CRqlKIjJDElWQkXWfVq5wG88tJa01SQ9ru1 l6Tx1TxSt6QANyXHBTP9s17hGWHZfkXsLOj8lOdE3mH2Jk106X4RqFPRTwHwlWjI AA9KNwpwiAO88HWWE/S1
=U0KB
-----END PGP SIGNATURE-----

#3 lore raw

PATCH 1/1 b43-fwcutter: pack correct ucode for brcmsmac fw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 2 lines · On Fri, 07 Dec 2012 17:12:35 +0100 Hauke Mehrtens <[email protected]> wrote:

Yes I thing a new release would be nice, as the wrong firmware will probably not work and could cause people some trouble.

ok cool. I released 017.

- --
Greetings, Michael.

PGP encryption is encouraged / 908D8B0E
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBAgAGBQJQwjPvAAoJEPUyvh2QjYsOvqgQAMTuuItRe8MIyPqgv0kohc6V DmXSXk7N4xJWrxcxdVv4tqdeXjnW/23PxpGk629tt3+yH3C+xEFooJKmCxqfvxtm UQF5SVENX2FAfMIrbo2vILIIx3n1YnoG/xSf8NDMNJG8dHi5dC1zc6l1x6z5I3Pl +5ADb2yT7SgyvrMGGo6G5nL3UbdsdtDVAG+e7AmEHBFioTkGWe/MgKVLrDIKwcHR EFjE97LC4CD/6nAiQ9WWLW5GddoflcwYkVZ6z0WDj3FJTDUq/Z+gzoQZ5YoS6P/v nzOmQESId+ilt8bHnTUw6sHtQ4ohV1gUpd6Sr/hKchdq0GLOi9N0ZfCRxY6/CugB wVkzji3YbRoiJpNV0xdvTONjq8XgB6agYM7syGFYWhiz2qAchDsdv2FFf1Nxz775 1xHsYd+8f1HywcHWxsC9C9okud+4WkzctddCo8Cf4XuI/pboDgyxvvuv3ZEmA8CM MEXdtG3Qv/KP5v5xUOfTfONum/ab3R2NF5pam16Chvw1oZY/VuLNt66AdG+IvF74 fdnl0sd/OP2ErLV2gWVO2bBjat2w70ox5ot4XMB9baz3TQZgO7yTj4nj90PYm1UK 97SBGhyFbgHVQl6PmilmWzo7fGIoyr2CWjC6BGYfqyLS4RZYh0kI9W2Ldn5s+luc eqfHKgXejlLC2v5Hb2bT
=kwMB
-----END PGP SIGNATURE-----