Skip to contentSkip to conversation

serial_pl011: Set RTS during initialization

PATCH In review Rob Herring 3 participants 3 messages Dec 3, 2012 – Dec 7, 2012

lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 serial_pl011: Set RTS during initialization

From: Joshua Housh <[email protected]>

If the pl011 is connected to another device which has hardware flow-control on, characters are never received by the pl011. Asserting RTS when flow-control is off will have no effect.

This is in line with how Linux behaves.

Signed-off-by Joshua Housh <[email protected]>
---
 drivers/serial/serial_pl01x.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/serial/serial_pl01x.c +2 -2
index b331be7..dfdba9f 100644
@@ -163,8 +163,8 @@ static int pl01x_serial_init(void)
 	}
 #endif
 	/* Finally, enable the UART */
-	writel(UART_PL011_CR_UARTEN | UART_PL011_CR_TXE | UART_PL011_CR_RXE,
-	       &regs->pl011_cr);
+	writel(UART_PL011_CR_UARTEN | UART_PL011_CR_TXE | UART_PL011_CR_RXE |
+	       UART_PL011_CR_RTS, &regs->pl011_cr);
 
 	return 0;
 }
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 serial_pl011: Set RTS during initialization

Hi Rob, Joshua,

Quoted 7 lines

From: Joshua Housh <[email protected]>

If the pl011 is connected to another device which has hardware flow-control on, characters are never received by the pl011. Asserting RTS when flow-control is off will have no effect.

This is in line with how Linux behaves.

[...]

Tested-by Marek Vasut <[email protected]>

Best regards,
Marek Vasut

#2 lore raw
In reply to Rob Herring
Quoted 10 lines · Rob Herring

From: Joshua Housh <[email protected]>

If the pl011 is connected to another device which has hardware flow-control on, characters are never received by the pl011. Asserting RTS when flow-control is off will have no effect.

This is in line with how Linux behaves.

Signed-off-by Joshua Housh <[email protected]>
Tested-by Marek Vasut <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121207/7dab7c25/attachment.pgp>