Skip to contentSkip to conversation

mfd: tps80031: MFD_TPS80031 needs to select REGMAP_IRQ

PATCH Applied Axel Lin 3 participants 3 messages Dec 5, 2012 – Dec 9, 2012 Multifunction devices (MFD)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 mfd: tps80031: MFD_TPS80031 needs to select REGMAP_IRQ

This driver uses regmap_irq APIs, thus need to select REGMAP_IRQ. IRQ_DOMAIN will be selected if select REGMAP_IRQ, thus remove it here.

This fixes below build errors:

drivers/built-in.o: In function `tps80031_remove':
drivers/mfd/tps80031.c:534: undefined reference to regmap_del_irq_chip' drivers/built-in.o: In function tps80031_irq_init':
drivers/mfd/tps80031.c:305: undefined reference to regmap_add_irq_chip' drivers/built-in.o: In function tps80031_probe':
drivers/mfd/tps80031.c:496: undefined reference to regmap_irq_get_domain' drivers/mfd/tps80031.c:512: undefined reference to regmap_del_irq_chip'
make: *** [vmlinux] Error 1

Signed-off-by Axel Lin <[email protected]>
---
 drivers/mfd/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/Kconfig +1 -1
index 09d43a9..1c0abd4 100644
@@ -269,7 +269,7 @@ config MFD_TPS80031
 	depends on I2C=y && GENERIC_HARDIRQS
 	select MFD_CORE
 	select REGMAP_I2C
-	select IRQ_DOMAIN
+	select REGMAP_IRQ
 	help
 	  If you say yes here you get support for the Texas Instruments
 	  TPS80031/ TPS80032 Fully Integrated Power Management with Power
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Axel Lin

This driver uses regmap_irq APIs, thus need to select REGMAP_IRQ. IRQ_DOMAIN will be selected if select REGMAP_IRQ, thus remove it here.

This fixes below build errors:

drivers/built-in.o: In function `tps80031_remove':
drivers/mfd/tps80031.c:534: undefined reference to regmap_del_irq_chip' drivers/built-in.o: In function tps80031_irq_init':
drivers/mfd/tps80031.c:305: undefined reference to regmap_add_irq_chip' drivers/built-in.o: In function tps80031_probe':
drivers/mfd/tps80031.c:496: undefined reference to regmap_irq_get_domain' drivers/mfd/tps80031.c:512: undefined reference to regmap_del_irq_chip'
make: *** [vmlinux] Error 1

Quoted 1 line
Signed-off-by Axel Lin<[email protected]>
Acked-by Laxman Dewangan <[email protected]>
Applied
#2 lore raw
In reply to Axel Lin

Hi Axel,

Quoted 14 lines · Axel Lin

This driver uses regmap_irq APIs, thus need to select REGMAP_IRQ. IRQ_DOMAIN will be selected if select REGMAP_IRQ, thus remove it here.

This fixes below build errors:

drivers/built-in.o: In function `tps80031_remove':
drivers/mfd/tps80031.c:534: undefined reference to regmap_del_irq_chip' drivers/built-in.o: In function tps80031_irq_init':
drivers/mfd/tps80031.c:305: undefined reference to regmap_add_irq_chip' drivers/built-in.o: In function tps80031_probe':
drivers/mfd/tps80031.c:496: undefined reference to regmap_irq_get_domain' drivers/mfd/tps80031.c:512: undefined reference to regmap_del_irq_chip'
make: *** [vmlinux] Error 1

Quoted 4 lines
Signed-off-by Axel Lin <[email protected]>
---
 drivers/mfd/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied as well, thanks.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/