Skip to contentSkip to conversation

scsi:gdth.c: fix compilation warning

PATCH In review Cong Ding 1 participant 3 messages Dec 3, 2012 – Jan 18, 2013 SCSI

lore
Share & tools
lore

Cong Ding

author
#0 lore raw

PATCH 1/1 scsi:gdth.c: fix compilation warning

We do not allow old-style function definition. Always spell foo(void) if a function does not take any parameters.

---
 drivers/scsi/gdth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/gdth.c +1 -1
index 5d72274..950c095 100644
@@ -204,7 +204,7 @@ static char strbuf[MAX_SERBUF+1];
 #else
 #define COM_BASE 0x3f8
 #endif
-static void ser_init()
+static void ser_init(void)
 {
     unsigned port=COM_BASE;
 
Signature · 1 line
1.7.4.5
author
#1 lore raw

ping!

- cong

Quoted 24 lines · Cong Ding

We do not allow old-style function definition. Always spell foo(void) if a function does not take any parameters.

---
 drivers/scsi/gdth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/gdth.c +1 -1
index 5d72274..950c095 100644
@@ -204,7 +204,7 @@ static char strbuf[MAX_SERBUF+1];
 #else
 #define COM_BASE 0x3f8
 #endif
-static void ser_init()
+static void ser_init(void)
 {
     unsigned port=COM_BASE;
 
Signature · 1 line
1.7.4.5
author
#2 lore raw
In reply to Cong Ding

Hi all, is this still in the queue or...?

- cong

Quoted 24 lines · Cong Ding

We do not allow old-style function definition. Always spell foo(void) if a function does not take any parameters.

---
 drivers/scsi/gdth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/gdth.c +1 -2
index 5d72274..950c095 100644
@@ -204,7 +204,7 @@ static char strbuf[MAX_SERBUF+1];
 #else
 #define COM_BASE 0x3f8
 #endif
-static void ser_init()
+static void ser_init(void)
 {
     unsigned port=COM_BASE;
 
--

1.7.4.5