Skip to contentSkip to conversation

block2mtd: throttle writes by calling balance_dirty_pages_ratelimited.

PATCH Applied NeilBrown 2 participants 2 messages Dec 12, 2012 – Dec 13, 2012

Subsystems (2)
Memory technology devices (MTD) BLOCK2MTD driver
lore
Share & tools
lore

NeilBrown

author
#0 lore raw

PATCH 1/1 block2mtd: throttle writes by calling balance_dirty_pages_ratelimited.

If you create a block2mtd device that is larger than main memory, and write to all of it, then lots of pages will be dirtied but they will never be flushed out as nothing calls any variant of balance_dirty_pages.

It would be nice to call set_page_dirty_balance(), but that isn't exported, so just call balance_dirty_pages_ratelimited() directly.

Signed-off-by NeilBrown <[email protected]>
drivers/mtd/devices/block2mtd.c +2 -0
index 681e2ee..2c3e8e7 100644
@@ -62,6 +62,7 @@ static int _block2mtd_erase(struct block2mtd_dev *dev, loff_t to, size_t len)
 				memset(page_address(page), 0xff, PAGE_SIZE);
 				set_page_dirty(page);
 				unlock_page(page);
+				balance_dirty_pages_ratelimited(mapping);
 				break;
 			}
 

@@ -152,6 +153,7 @@ static int _block2mtd_write(struct block2mtd_dev *dev, const u_char *buf,
 			memcpy(page_address(page) + offset, buf, cpylen);
 			set_page_dirty(page);
 			unlock_page(page);
+			balance_dirty_pages_ratelimited(mapping);
 		}
 		page_cache_release(page);
Applied
#1 lore raw
Quoted 10 lines · NeilBrown

If you create a block2mtd device that is larger than main memory, and write to all of it, then lots of pages will be dirtied but they will never be flushed out as nothing calls any variant of balance_dirty_pages.

It would be nice to call set_page_dirty_balance(), but that isn't exported, so just call balance_dirty_pages_ratelimited() directly.

Signed-off-by NeilBrown <[email protected]>

Pushed to l2-mtd.git, thanks!

Signature · 2 lines
Best Regards,
Artem Bityutskiy