Skip to contentSkip to conversation

watchdog: imx2_wdt: Select the driver via ARCH_MXC

PATCH In review Fabio Estevam 3 participants 6 messages Jul 2, 2012 – Dec 12, 2012 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 watchdog: imx2_wdt: Select the driver via ARCH_MXC

From: Fabio Estevam <[email protected]>

With device tree support in place, we should not use IMX_HAVE_PLATFORM_IMX2_WDT as a dependency for selecting the imx2_wdt driver.

Use ARCH_MXC symbol instead, so that the driver can be even selected by a device-tree only SoC, such as i.MX6.

---
 drivers/watchdog/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/watchdog/Kconfig +1 -1
index 277ecbc..f821f2f 100644
@@ -341,7 +341,7 @@ config MAX63XX_WATCHDOG
 
 config IMX2_WDT
 	tristate "IMX2+ Watchdog"
-	depends on IMX_HAVE_PLATFORM_IMX2_WDT
+	depends on ARCH_MXC
 	help
 	  This is the driver for the hardware watchdog
 	  on the Freescale IMX2 and later processors.
Signature · 1 line
1.7.1
#1 lore raw
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

With device tree support in place, we should not use IMX_HAVE_PLATFORM_IMX2_WDT as a dependency for selecting the imx2_wdt driver.

Use ARCH_MXC symbol instead, so that the driver can be even selected by a device-tree only SoC, such as i.MX6.

Sascha/Shawn,

Any comments?

Regards,

Fabio Estevam

Acked-by
#2 lore raw
Quoted 6 lines · Fabio Estevam
Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

With device tree support in place, we should not use IMX_HAVE_PLATFORM_IMX2_WDT as a dependency for selecting the imx2_wdt driver.

Quoted 9 lines
Quoted 4 lines

Use ARCH_MXC symbol instead, so that the driver can be even selected by a device-tree only SoC, such as i.MX6.

Sascha/Shawn,

Any comments?

#3 lore raw

Wim,

Quoted 10 lines · Shawn Guo
Quoted 9 lines · Fabio Estevam
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

With device tree support in place, we should not use IMX_HAVE_PLATFORM_IMX2_WDT as a dependency for selecting the imx2_wdt driver.

Use ARCH_MXC symbol instead, so that the driver can be even selected by a device-tree only SoC, such as i.MX6.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Sascha/Shawn,

Any comments?

Could this one be applied, please?

Regards,

Fabio Estevam

#4 lore raw

Wim,

Ping?

Quoted 27 lines · Fabio Estevam

Wim,

Quoted 10 lines · Shawn Guo
Quoted 9 lines · Fabio Estevam
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

With device tree support in place, we should not use IMX_HAVE_PLATFORM_IMX2_WDT as a dependency for selecting the imx2_wdt driver.

Use ARCH_MXC symbol instead, so that the driver can be even selected by a device-tree only SoC, such as i.MX6.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Sascha/Shawn,

Any comments?

Could this one be applied, please?

Regards,

Fabio Estevam

#5 lore raw
In reply to Fabio Estevam

Hi Fabio,

Quoted 7 lines

With device tree support in place, we should not use IMX_HAVE_PLATFORM_IMX2_WDT as a dependency for selecting the imx2_wdt driver.

Use ARCH_MXC symbol instead, so that the driver can be even selected by a device-tree only SoC, such as i.MX6.

Added to linux-watchdog-next.

Kind regards,
Wim.