Skip to contentSkip to conversation

arch/x86/kvm/irq.c:46:18: warning: unused variable 's'

PATCH New kbuild test robot 2 participants 3 messages Dec 14, 2012

Subsystems (3)
lore
Share & tools
lore

kbuild test robot

author build bot
#0 lore raw
tree:   git://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
head:   0f888f5acd0cd806d4fd9f4067276b3855a13309
commit: f3200d00ea42e485772ff92d6d649aa8eeb640c0 [3/13] KVM: inject ExtINT interrupt before APIC interrupts
config: make ARCH=x86_64 allmodconfig

All warnings:

arch/x86/kvm/irq.c: In function 'kvm_cpu_has_interrupt':
arch/x86/kvm/irq.c:46:18: warning: unused variable 's' [-Wunused-variable] arch/x86/kvm/irq.c: In function 'kvm_cpu_get_interrupt':
arch/x86/kvm/irq.c:63:18: warning: unused variable 's' [-Wunused-variable]

vim +/s +46 arch/x86/kvm/irq.c

85f455f7 drivers/kvm/irq.c  Eddie Dong      2007-07-06  30  /*
3d80840d arch/x86/kvm/irq.c Marcelo Tosatti 2008-04-11  31   * check if there are pending timer events
3d80840d arch/x86/kvm/irq.c Marcelo Tosatti 2008-04-11  32   * to be processed.
3d80840d arch/x86/kvm/irq.c Marcelo Tosatti 2008-04-11  33   */
3d80840d arch/x86/kvm/irq.c Marcelo Tosatti 2008-04-11  34  int kvm_cpu_has_pending_timer(struct kvm_vcpu *vcpu)
3d80840d arch/x86/kvm/irq.c Marcelo Tosatti 2008-04-11  35  {
23e7a794 arch/x86/kvm/irq.c Jason Wang      2010-08-27  36  	return apic_has_pending_timer(vcpu);
3d80840d arch/x86/kvm/irq.c Marcelo Tosatti 2008-04-11  37  }
3d80840d arch/x86/kvm/irq.c Marcelo Tosatti 2008-04-11  38  EXPORT_SYMBOL(kvm_cpu_has_pending_timer);
3d80840d arch/x86/kvm/irq.c Marcelo Tosatti 2008-04-11  39  
3d80840d arch/x86/kvm/irq.c Marcelo Tosatti 2008-04-11  40  /*
85f455f7 drivers/kvm/irq.c  Eddie Dong      2007-07-06  41   * check if there is pending interrupt without
85f455f7 drivers/kvm/irq.c  Eddie Dong      2007-07-06  42   * intack.
85f455f7 drivers/kvm/irq.c  Eddie Dong      2007-07-06  43   */
85f455f7 drivers/kvm/irq.c  Eddie Dong      2007-07-06  44  int kvm_cpu_has_interrupt(struct kvm_vcpu *v)
85f455f7 drivers/kvm/irq.c  Eddie Dong      2007-07-06  45  {
97222cc8 drivers/kvm/irq.c  Eddie Dong      2007-09-12 @46  	struct kvm_pic *s;
97222cc8 drivers/kvm/irq.c  Eddie Dong      2007-09-12  47  
8061823a arch/x86/kvm/irq.c Gleb Natapov    2009-04-21  48  	if (!irqchip_in_kernel(v->kvm))
923c61bb arch/x86/kvm/irq.c Gleb Natapov    2009-05-11  49  		return v->arch.interrupt.pending;
8061823a arch/x86/kvm/irq.c Gleb Natapov    2009-04-21  50  
f3200d00 arch/x86/kvm/irq.c Gleb Natapov    2012-12-10  51  	if (kvm_apic_accept_pic_intr(v) && pic_irqchip(v->kvm)->output)
f3200d00 arch/x86/kvm/irq.c Gleb Natapov    2012-12-10  52  		return pic_irqchip(v->kvm)->output;	/* PIC */
f3200d00 arch/x86/kvm/irq.c Gleb Natapov    2012-12-10  53  
f3200d00 arch/x86/kvm/irq.c Gleb Natapov    2012-12-10  54  	return kvm_apic_has_interrupt(v) != -1;	/* LAPIC */

---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation

#1 lore raw

KVM: remove unused variable. variable 's'

arch/x86/kvm/irq.c +0 -4
index ebd98d0..b111aee 100644
@@ -43,8 +43,6 @@ EXPORT_SYMBOL(kvm_cpu_has_pending_timer);
  */
 int kvm_cpu_has_interrupt(struct kvm_vcpu *v)
 {
-	struct kvm_pic *s;
-
 	if (!irqchip_in_kernel(v->kvm))
 		return v->arch.interrupt.pending;
 
@@ -60,8 +58,6 @@ EXPORT_SYMBOL_GPL(kvm_cpu_has_interrupt);
  */
 int kvm_cpu_get_interrupt(struct kvm_vcpu *v)
 {
-	struct kvm_pic *s;
-
 	if (!irqchip_in_kernel(v->kvm))
 		return v->arch.interrupt.nr;
 

--
Gleb.

#2 lore raw

PATCH 1/1 KVM: remove unused variable.

---

Resend with fixed subject.

arch/x86/kvm/irq.c +0 -4
index ebd98d0..b111aee 100644
@@ -43,8 +43,6 @@ EXPORT_SYMBOL(kvm_cpu_has_pending_timer);
  */
 int kvm_cpu_has_interrupt(struct kvm_vcpu *v)
 {
-	struct kvm_pic *s;
-
 	if (!irqchip_in_kernel(v->kvm))
 		return v->arch.interrupt.pending;
 
@@ -60,8 +58,6 @@ EXPORT_SYMBOL_GPL(kvm_cpu_has_interrupt);
  */
 int kvm_cpu_get_interrupt(struct kvm_vcpu *v)
 {
-	struct kvm_pic *s;
-
 	if (!irqchip_in_kernel(v->kvm))
 		return v->arch.interrupt.nr;
 

--
Gleb.