Skip to contentSkip to conversation

ARM: OMAP2+: Fix compillation error in mach-omap2/timer.c

PATCH New Peter Ujfalusi 3 participants 3 messages Dec 19, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Peter Ujfalusi

author
#0 lore raw

PATCH 1/1 ARM: OMAP2+: Fix compillation error in mach-omap2/timer.c

prom_add_property() has been renamed to of_add_property() This patch fixes the following comilation error:

arch/arm/mach-omap2/timer.c: In function ?omap_get_timer_dt?:
arch/arm/mach-omap2/timer.c:178:3: error: implicit declaration of function ?prom_add_property? [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[1]: *** [arch/arm/mach-omap2/timer.o] Error 1
make[1]: *** Waiting for unfinished jobs....

Signed-off-by Peter Ujfalusi <[email protected]>

---
Hi Tony,

today's mainline does not compile due to this API rename in of core. Not sure if we alreasy have fix for this pending.

Regards,
Peter

 arch/arm/mach-omap2/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-omap2/timer.c +1 -1
index 7016637..cece724 100644
@@ -175,7 +175,7 @@ static struct device_node * __init omap_get_timer_dt(struct of_device_id *match,
 			continue;
 		}
 
-		prom_add_property(np, &device_disabled);
+		of_add_property(np, &device_disabled);
 		return np;
 	}
Signature · 1 line
1.8.0.2
#1 lore raw

PATCH 1/1 ARM: OMAP2+: Fix compillation error in mach-omap2/timer.c

Hi Peter, Tony

Quoted 9 lines · Peter

prom_add_property() has been renamed to of_add_property() This patch fixes the following comilation error:

arch/arm/mach-omap2/timer.c: In function ?omap_get_timer_dt?:
arch/arm/mach-omap2/timer.c:178:3: error: implicit declaration of function ?prom_add_property? [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[1]: *** [arch/arm/mach-omap2/timer.o] Error 1
make[1]: *** Waiting for unfinished jobs....

Quoted 7 lines
Signed-off-by Peter Ujfalusi <[email protected]>

---
Hi Tony,

today's mainline does not compile due to this API rename in of core. Not sure if we alreasy have fix for this pending.

There following patches for needed to get omap2plus_defconfig build working

https://patchwork.kernel.org/patch/1810481/ - address the build breakage due to header file cleanup
https://patchwork.kernel.org/patch/1810441/ - address the prom_add_property() issue
http://marc.info/?l=linux-arm-kernel&m=135589966017628&w=2 - this crept in during a merge commit.

maintainer
#2 lore raw

PATCH 1/1 ARM: OMAP2+: Fix compillation error in mach-omap2/timer.c

Quoted 19 lines · Bedia, Vaibhav

Hi Peter, Tony

Quoted 16 lines · Peter

prom_add_property() has been renamed to of_add_property() This patch fixes the following comilation error:

arch/arm/mach-omap2/timer.c: In function ?omap_get_timer_dt?:
arch/arm/mach-omap2/timer.c:178:3: error: implicit declaration of function ?prom_add_property? [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[1]: *** [arch/arm/mach-omap2/timer.o] Error 1
make[1]: *** Waiting for unfinished jobs....

Signed-off-by Peter Ujfalusi <[email protected]>

---
Hi Tony,

today's mainline does not compile due to this API rename in of core. Not sure if we alreasy have fix for this pending.

Thanks applying.

Quoted 5 lines

There following patches for needed to get omap2plus_defconfig build working

https://patchwork.kernel.org/patch/1810481/ - address the build breakage due to header file cleanup
https://patchwork.kernel.org/patch/1810441/ - address the prom_add_property() issue
http://marc.info/?l=linux-arm-kernel&m=135589966017628&w=2 - this crept in during a merge commit.

Thanks all these should be queued up somewhere now.

Regards,

Tony