Add apf51 basic support
Subsystems (3)
PATCH 1/1 Add apf51 basic support
--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/imx51-apf51.dts | 68 +++++++++++++++++++++++++++++++++++++ arch/arm/boot/dts/imx51.dtsi | 30 ++++++++++++++++ 3 files changed, 100 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/imx51-apf51.dts
arch/arm/boot/dts/Makefile +2 -1
@@ -45,7 +45,8 @@ dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ msm8960-cdp.dtb dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \ armada-xp-db.dtb -dtb-$(CONFIG_ARCH_MXC) += imx51-babbage.dtb \ +dtb-$(CONFIG_ARCH_MXC) += imx51-apf51.dtb \ + imx51-babbage.dtb \ imx53-ard.dtb \ imx53-evk.dtb \ imx53-qsb.dtb \
arch/arm/boot/dts/imx51-apf51.dts new file +68 -0
68 lines not on this page · raw message
arch/arm/boot/dts/imx51.dtsi +30 -0
@@ -248,6 +248,29 @@ 260 0x80000000 /* MX51_PAD_NANDF_RDY_INT__FEC_TX_CLK */ >; }; + + pinctrl_fec_2: fecgrp-2 { + fsl,pins = < + 589 0x80000000 /* MX51_PAD_DI_GP3__FEC_TX_ER */ + 592 0x80000000 /* MX51_PAD_DI2_PIN4__FEC_CRS */ + 594 0x80000000 /* MX51_PAD_DI2_PIN2__FEC_MDC */ + 596 0x80000000 /* MX51_PAD_DI2_PIN3__FEC_MDIO */ + 598 0x80000000 /* MX51_PAD_DI2_DISP_CLK__FEC_RDATA1 */ + 602 0x80000000 /* MX51_PAD_DI_GP4__FEC_RDATA2 */ + 604 0x80000000 /* MX51_PAD_DISP2_DAT0__FEC_RDATA3 */ + 609 0x80000000 /* MX51_PAD_DISP2_DAT1__FEC_RX_ER */ + 618 0x80000000 /* MX51_PAD_DISP2_DAT6__FEC_TDATA1 */ + 623 0x80000000 /* MX51_PAD_DISP2_DAT7__FEC_TDATA2 */ + 628 0x80000000 /* MX51_PAD_DISP2_DAT8__FEC_TDATA3 */ + 634 0x80000000 /* MX51_PAD_DISP2_DAT9__FEC_TX_EN */ + 639 0x80000000 /* MX51_PAD_DISP2_DAT10__FEC_COL */ + 644 0x80000000 /* MX51_PAD_DISP2_DAT11__FEC_RX_CLK */ + 649 0x80000000 /* MX51_PAD_DISP2_DAT12__FEC_RX_DV */ + 653 0x80000000 /* MX51_PAD_DISP2_DAT13__FEC_TX_CLK */ + 657 0x80000000 /* MX51_PAD_DISP2_DAT14__FEC_RDATA0 */ + 662 0x80000000 /* MX51_PAD_DISP2_DAT15__FEC_TDATA0 */ + >; + }; }; ecspi1 {
@@ -324,6 +347,13 @@ 49 0x1c5 /* MX51_PAD_EIM_D24__UART3_CTS */ >; }; + + pinctrl_uart3_2: uart3grp-2 { + fsl,pins = < + 434 0x1c5 /* MX51_PAD_UART3_RXD__UART3_RXD */ + 430 0x1c5 /* MX51_PAD_UART3_TXD__UART3_TXD */ + >; + }; }; };
Signature · 1 line
1.7.10.4
Sascha Hauer
maintainerPATCH 1/1 Add apf51 basic support
Quoted 6 lines · Laurent Cans
Signed-off-by Laurent Cans <[email protected]>Signed-off-by Gwenhael Goavec-Merou <[email protected]>---
arch/arm/boot/dts/imx51-apf51.dts new file +3
-0+ clocks { + #address-cells = <1>; + #size-cells = <0>;
arch/arm/boot/dts/imx51-apf51.dts line 38
Quoted 10 lines
arch/arm/boot/dts/imx51-apf51.dts new file +10
-0+ + ckih1 { + compatible = "fsl,imx-ckih1", "fixed-clock"; + clock-frequency = <0>; + }; + + osc { + compatible = "fsl,imx-osc", "fixed-clock"; + clock-frequency = <33554432>; + };
These compatible properties shouldn't be necessary, right?
arch/arm/boot/dts/imx51-apf51.dts line 49
Quoted 11 lines
arch/arm/boot/dts/imx51-apf51.dts new file +11
-0+ }; + soc { + aips at 70000000 { /* aips-1 */ + spba at 70000000 { + uart3: serial at 7000c000 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_uart3_2>; + status = "okay"; + }; + }; + };
This (and the other nodes) can more eaasily be written as:
&uart3 {
...
};see arch/arm/boot/dts/omap5-evm.dts for a good example.
This has the advantage that you don't have to resemble the SoC layout in your board file.
Sascha
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH 1/1 Add apf51 basic support
2012/12/19 Sascha Hauer <[email protected]>:
Quoted 11 lines · Laurent Cans
Quoted 10 lines
Signed-off-by Laurent Cans <[email protected]>Signed-off-by Gwenhael Goavec-Merou <[email protected]>---
arch/arm/boot/dts/imx51-apf51.dts new file +7
-0+ clocks { + #address-cells = <1>; + #size-cells = <0>; + + ckih1 { + compatible = "fsl,imx-ckih1", "fixed-clock"; + clock-frequency = <0>;
Quoted 8 lines
arch/arm/boot/dts/imx51-apf51.dts line 38
Quoted 6 lines
arch/arm/boot/dts/imx51-apf51.dts new file +6
-0+ }; + + osc { + compatible = "fsl,imx-osc", "fixed-clock"; + clock-frequency = <33554432>; + };These compatible properties shouldn't be necessary, right?
Yes you are right. I will correct that.
Quoted 15 lines
arch/arm/boot/dts/imx51-apf51.dts line 49
Quoted 12 lines
arch/arm/boot/dts/imx51-apf51.dts new file +11
-0+ }; + soc { + aips at 70000000 { /* aips-1 */ + spba at 70000000 { + uart3: serial at 7000c000 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_uart3_2>; + status = "okay"; + }; + }; + };This (and the other nodes) can more eaasily be written as:
Quoted 8 lines
&uart3 { ... };see
arch/arm/boot/dts/omap5-evm.dtsfor a good example.This has the advantage that you don't have to resemble the SoC layout in your board file.
I will send v2 version of the patch during the week written with this new layout.
Thanks for the comments
Quoted 8 lines
Sascha
--
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH 1/1 Add apf51 basic support
In reply to Sascha HauerQuoted 11 lines · Sascha Hauer
Quoted 10 lines · Laurent Cans
Signed-off-by Laurent Cans <[email protected]>Signed-off-by Gwenhael Goavec-Merou <[email protected]>---
arch/arm/boot/dts/imx51-apf51.dts new file +7
-0+ clocks { + #address-cells = <1>; + #size-cells = <0>; + + ckih1 { + compatible = "fsl,imx-ckih1", "fixed-clock"; + clock-frequency = <0>;
Quoted 9 lines
arch/arm/boot/dts/imx51-apf51.dts line 38
Quoted 6 lines
arch/arm/boot/dts/imx51-apf51.dts new file +6
-0+ }; + + osc { + compatible = "fsl,imx-osc", "fixed-clock"; + clock-frequency = <33554432>; + };These compatible properties shouldn't be necessary, right?
Use node path instead? But imx51 clock driver is already using compatible property to identify the clocks.
Shawn
PATCH 1/1 Add apf51 basic support
2013/1/3 Shawn Guo <[email protected]>:
Quoted 21 lines · Sascha Hauer
Quoted 11 lines · Laurent Cans
Quoted 10 lines
Signed-off-by Laurent Cans <[email protected]>Signed-off-by Gwenhael Goavec-Merou <[email protected]>---
arch/arm/boot/dts/imx51-apf51.dts new file +7
-0+ clocks { + #address-cells = <1>; + #size-cells = <0>; + + ckih1 { + compatible = "fsl,imx-ckih1", "fixed-clock"; + clock-frequency = <0>;Quoted 9 lines
arch/arm/boot/dts/imx51-apf51.dts line 38
Quoted 6 lines
arch/arm/boot/dts/imx51-apf51.dts new file +6
-0+ }; + + osc { + compatible = "fsl,imx-osc", "fixed-clock"; + clock-frequency = <33554432>; + };These compatible properties shouldn't be necessary, right?
Quoted 5 lines
Use node path instead? But imx51 clock driver is already using compatible property to identify the clocks.
Shawn
Hi shawn,
I don't understand your remarks.
The method used to define clocks is incorrect? What is the recommended method to define clocks?
Laurent
PATCH 1/1 Add apf51 basic support
Quoted 25 lines · Laurent CANS
2013/1/3 Shawn Guo <[email protected]>:
Quoted 24 lines · Sascha Hauer
Quoted 11 lines · Laurent Cans
Quoted 10 lines
Signed-off-by Laurent Cans <[email protected]>Signed-off-by Gwenhael Goavec-Merou <[email protected]>---
arch/arm/boot/dts/imx51-apf51.dts new file +7
-0+ clocks { + #address-cells = <1>; + #size-cells = <0>; + + ckih1 { + compatible = "fsl,imx-ckih1", "fixed-clock"; + clock-frequency = <0>;Quoted 9 lines
arch/arm/boot/dts/imx51-apf51.dts line 38
Quoted 6 lines
arch/arm/boot/dts/imx51-apf51.dts new file +6
-0+ }; + + osc { + compatible = "fsl,imx-osc", "fixed-clock"; + clock-frequency = <33554432>; + };These compatible properties shouldn't be necessary, right?
Use node path instead? But imx51 clock driver is already using compatible property to identify the clocks.
Quoted 7 lines
Quoted 2 lines
Shawn
Hi shawn,
I don't understand your remarks.
Or I misunderstood Sascha's comment? I thought he was asking you to remove those compatible properties, and I do not understand how that would work, since clock code is looking for the node using the compatible property.
Shawn
Quoted 4 lines
The method used to define clocks is incorrect? What is the recommended method to define clocks?
Laurent
Sascha Hauer
maintainerPATCH 1/1 Add apf51 basic support
Quoted 29 lines · Shawn Guo
Quoted 28 lines · Laurent CANS
2013/1/3 Shawn Guo <[email protected]>:
Quoted 26 lines · Sascha Hauer
Quoted 11 lines · Laurent Cans
Quoted 10 lines
Signed-off-by Laurent Cans <[email protected]>Signed-off-by Gwenhael Goavec-Merou <[email protected]>---
arch/arm/boot/dts/imx51-apf51.dts new file +7
-0+ clocks { + #address-cells = <1>; + #size-cells = <0>; + + ckih1 { + compatible = "fsl,imx-ckih1", "fixed-clock"; + clock-frequency = <0>;Quoted 9 lines
arch/arm/boot/dts/imx51-apf51.dts line 38
Quoted 6 lines
arch/arm/boot/dts/imx51-apf51.dts new file +6
-0+ }; + + osc { + compatible = "fsl,imx-osc", "fixed-clock"; + clock-frequency = <33554432>; + };These compatible properties shouldn't be necessary, right?
Use node path instead? But imx51 clock driver is already using compatible property to identify the clocks.
Shawn
Quoted 8 lines
Quoted 4 lines
Hi shawn,
I don't understand your remarks.
Or I misunderstood Sascha's comment? I thought he was asking you to remove those compatible properties, and I do not understand how that would work, since clock code is looking for the node using the compatible property.
What I meant is that the compatible properties are already in the dtsi file and thus can be removed from the dts.
Sascha
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH 1/1 Add apf51 basic support
Quoted 3 lines · Sascha Hauer
What I meant is that the compatible properties are already in the dtsi file and thus can be removed from the dts.
Aha, sorry, I indeed misunderstood your comment.
Shawn