Skip to contentSkip to conversation

solos-pci: double lock in geos_gpio_store()

PATCH Applied Dan Carpenter 3 participants 3 messages Dec 20, 2012 – Dec 21, 2012 1 message not in the archive

Subsystems (3)
Networking Network drivers ATM
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 50d25b88.0QAOhrb1a/eK/hR1%[email protected]

Dan Carpenter

author
#1 lore raw

PATCH 1/1 solos-pci: double lock in geos_gpio_store()

There is a typo here so we do a double lock instead of an unlock.

Signed-off-by Dan Carpenter <[email protected]>

---
Only needed in linux-next. Introduced in f9baad02e7411d9 [14/17]
solos-pci: add GPIO support for newer versions on Geos board

drivers/atm/solos-pci.c +1 -1
index 473d808..7b95736 100644
@@ -531,7 +531,7 @@ static ssize_t geos_gpio_store(struct device *dev, struct device_attribute *attr
 	} else {
 		count = -EINVAL;
 	}
-	spin_lock_irq(&card->param_queue_lock);
+	spin_unlock_irq(&card->param_queue_lock);
 	return count;
 }
Acked-by on v1 1/1
#2 lore raw
Quoted 6 lines · Dan Carpenter

There is a typo here so we do a double lock instead of an unlock.

Signed-off-by Dan Carpenter <[email protected]>

---
Only needed in linux-next. Introduced in f9baad02e7411d9 [14/17]
solos-pci: add GPIO support for newer versions on Geos board

Ah, crap. That was my fault; it was part of my "improvement" to Nathan's patch. Sorry.

Acked-by David Woodhouse <[email protected]>
maintainer Applied
#3 lore raw

From: "Woodhouse, David" <[email protected]>
Date: Thu, 20 Dec 2012 09:22:26 +0000

Quoted 8 lines · Dan Carpenter
Quoted 6 lines

There is a typo here so we do a double lock instead of an unlock.

Signed-off-by Dan Carpenter <[email protected]>

---
Only needed in linux-next. Introduced in f9baad02e7411d9 [14/17]
solos-pci: add GPIO support for newer versions on Geos board

Quoted 4 lines

Ah, crap. That was my fault; it was part of my "improvement" to Nathan's patch. Sorry.

Acked-by David Woodhouse <[email protected]>

Applied.