Skip to contentSkip to conversation

carl9170: fix -EINVAL bailout during init with !CONFIG_MAC80211_MESH

PATCH In review Christian Lamparter 1 participant 2 messages Dec 22, 2012 1 message not in the archive CARL9170 Linux community wireless driver

lore
Share & tools
lore

Christian Lamparter

author maintainer
#0 lore raw

PATCH 1/1 carl9170: fix -EINVAL bailout during init with !CONFIG_MAC80211_MESH

Sean reported that as of 3.7, his AR9170 device no longer works because the driver fails during initialization. He noted this is due to:
"In carl9170/fw.c, ar->hw->wiphy is tagged with NL80211_IFTYPE_MESH_POINT support if the firmware has Content after Beacon Queuing. This is both in interface_modes and the only iface_combinations entry.

If CONFIG_MAC80211_MESH is not set, ieee80211_register_hw removes NL80211_IFTYPE_MESH_POINT from interface_modes, but not iface_combinations.

wiphy_register then checks to see if every interface type in every interface combination is in interface_modes. NL80211_IFTYPE_MESH_POINT was removed, so you get a WARN_ON warning and it returns -EINVAL, giving up."

Unfortunately, the iface_combination (types) feature bitmap in ieee80211_iface_limit is part of a const member in the ieee80211_iface_combination struct. Hence, the MESH_POINT feature flag can't be masked by wiphy_register in the same way as interface_modes in ieee80211_register_hw.

---
only compile tested.

---
 drivers/net/wireless/ath/carl9170/fw.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/carl9170/fw.c +5 -1
index aaebecd..63fd9af 100644
@@ -336,8 +336,12 @@ static int carl9170_fw(struct ar9170 *ar, const __u8 *data, size_t len)
 		if (SUPP(CARL9170FW_WLANTX_CAB)) {
 			if_comb_types |=
 				BIT(NL80211_IFTYPE_AP) |
-				BIT(NL80211_IFTYPE_MESH_POINT) |
 				BIT(NL80211_IFTYPE_P2P_GO);
+
+#ifdef CONFIG_MAC80211_MESH
+			if_comb_types |=
+				BIT(NL80211_IFTYPE_MESH_POINT);
+#endif /* CONFIG_MAC80211_MESH */
 		}
 	}
 
Signature · 1 line
1.7.10.4

A message that is not in the archive (sent off-list or not yet received): CAFR4Aqa3qVQaLGYDwmAvOm8S5=0DkwtsDXMVGUNuOLuvkeAAeA@mail.gmail.com

author maintainer Tested-by Sean Patrick Santos
#2 lore raw
Quoted 2 lines · On Saturday 22 December 2012 05:21:24 Sean Patrick Santos wrote:

I tested this patch and it solved my problem. The driver now works correctly without CONFIG_MAC80211_MESH.

Thank you for testing! I've readded John, so he can add this tag to the commmit:

Regards,

Christian