kconfig:lxdialog: remove duplicate code
PATCH 1/1 kconfig:lxdialog: remove duplicate code
dialog.h has two line the same below:
extern char dialog_input_result[];
This patch remove one of them.
--- scripts/kconfig/lxdialog/dialog.h | 1 - 1 file changed, 1 deletion(-)
scripts/kconfig/lxdialog/dialog.h +0 -1
@@ -221,7 +221,6 @@ int dialog_menu(const char *title, const char *prompt, const void *selected, int *s_scroll);int dialog_checklist (const char *title,const char *prompt,int height,int width,int list_height); -extern char dialog_input_result[];int dialog_inputbox (const char *title,const char *prompt,int height,int width,const char *init);
Signature · 1 line
1.7.11.1.116.g8228a23
Wang, All,
Quoted 5 lines · On Monday 17 December 2012 Wang YanQing wrote:
dialog.hhas two line the same below:
extern char dialog_input_result[];
This patch remove one of them.Signed-off-by Wang YanQing <[email protected]>
Quoted 20 lines
--- scripts/kconfig/lxdialog/dialog.h | 1 - 1 file changed, 1 deletion(-)scripts/kconfig/lxdialog/dialog.h +0
-1@@ -221,7 +221,6 @@ int dialog_menu(const char *title, const char *prompt, const void *selected, int *s_scroll);int dialog_checklist (const char *title,const char *prompt,int height,int width,int list_height); -extern char dialog_input_result[];int dialog_inputbox (const char *title,const char *prompt,int height,int width,const char *init);Signature · 1 line
1.7.11.1.116.g8228a23
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
Quoted 11 lines · Yann E. MORIN
Wang, All,
Quoted 5 lines · On Monday 17 December 2012 Wang YanQing wrote:
dialog.hhas two line the same below:
extern char dialog_input_result[];
This patch remove one of them.Signed-off-by Wang YanQing <[email protected]>Reviewed-by "Yann E. MORIN" <[email protected]>Tested-by "Yann E. MORIN" <[email protected]>
Michal, All.
Hi Michal, could you consider pick up this obvious right patch, and consider others' three patch I sented one week ago? I just don't want delay them to 2013, and they can get more test when they appear in next tree.
https://patchwork.kernel.org/patch/1887361/
https://patchwork.kernel.org/patch/1894341/
https://patchwork.kernel.org/patch/1887441/
Happy christmas!
Thanks.
Wang, All,
Quoted 8 lines · On Monday 24 December 2012 Wang YanQing wrote:
Quoted 7 lines · Yann E. MORIN
Wang, All,
Quoted 4 lines · On Monday 17 December 2012 Wang YanQing wrote:
dialog.hhas two line the same below:
extern char dialog_input_result[];
This patch remove one of them.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Wang YanQing <[email protected]>Reviewed-by "Yann E. MORIN" <[email protected]>Tested-by "Yann E. MORIN" <[email protected]>Michal, All.
Hi Michal, could you consider pick up this obvious right patch,
This code-duplication-removal patch could qualify for post-rc1.
Quoted 6 lines
and consider others' three patch I sented one week ago? I just don't want delay them to 2013, and they can get more test when they appear in next tree.
https://patchwork.kernel.org/patch/1887361/
https://patchwork.kernel.org/patch/1894341/
https://patchwork.kernel.org/patch/1887441/
It's too late for those: the merge window is closed, and they did not even went into Michal's tree, so they definitely do not qualify for post-rc1. We'll have to wait until the next merge window for inclusion.
Michal probably got caught by this shorter-than-usual merge window, and missed the deadline. :-/
Wang, I've queued them here, and will push them again to Michal, after the holidays season is over.
Merry Chrtistmas, and a Happy New Year to all! :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
Wang, All,
Quoted 1 line · On Tuesday 25 December 2012 Yann E. MORIN wrote:
On Monday 24 December 2012 Wang YanQing wrote:
[--SNIP--]
Quoted 6 lines
Quoted 6 lines
and consider others' three patch I sented one week ago? I just don't want delay them to 2013, and they can get more test when they appear in next tree.
https://patchwork.kernel.org/patch/1887361/
https://patchwork.kernel.org/patch/1894341/
https://patchwork.kernel.org/patch/1887441/
[--SNIP--]
Quoted 2 lines
Wang, I've queued them here, and will push them again to Michal, after the holidays season is over.
I've started gathering kconfig-related patches suitable for post-3.8 there:
git://gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next
They are browseable there:
https://www.gitorious.org/linux-kconfig/linux-kconfig/commits/yem-kconfig-for-next
I'll send a proper pull-request to Michal in a litle while.
Note: the autoritative tree for kconfig is Michal's. I'm only doing this gathering of patches in an attempt to not forget any, and to make Michal's life easier, if he finds it usefull to pull from there.
Branches in that tree are based off Michal's branches, and so will be rebased accordingly.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'