ASoC: sgtl5000: Fix maximum value for microphone gain
Subsystems (3)
Fabio Estevam
maintainerPATCH v2 1/1 ASoC: sgtl5000: Fix maximum value for microphone gain
From: Fabio Estevam <[email protected]>
sgtl5000 microphone gain only has 2 bits of resolution, so maximum value is 3.
Quoted 1 line
From Eric Nelson:
"We also found that for the microphones we have here (commodity PC boom mics) a default value of 2 for the gain gives the best results."
So change the default microphone gain as well.
---
Changes since v1:
- Add sgtl5000 into the Subject
sound/soc/codecs/sgtl5000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/sgtl5000.c +2 -2
@@ -401,7 +401,7 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = { 5, 1, 0),SOC_SINGLE_TLV ("Mic Volume" ,SGTL5000_CHIP_MIC_CTRL , - 0, 4, 0, mic_gain_tlv), + 0, 3, 0, mic_gain_tlv), };/* mute the codec used by alsa core */
@@ -1344,7 +1344,7 @@ static int sgtl5000_probe(struct snd_soc_codec *codec)SGTL5000_HP_ZCD_EN | SGTL5000_ADC_ZCD_EN); -snd_soc_write (codec,SGTL5000_CHIP_MIC_CTRL ,0 ); +snd_soc_write (codec,SGTL5000_CHIP_MIC_CTRL ,2 );/* * disable DAP
Signature · 1 line
1.7.9.5
sound/soc/codecs/sgtl5000.c static int sgtl5000_probe(struct snd_soc_codec *codec) · line 1347
Quoted 2 lines · Fabio Estevam
sound/soc/codecs/sgtl5000.c +1
-1-snd_soc_write (codec,SGTL5000_CHIP_MIC_CTRL ,0 ); +snd_soc_write (codec,SGTL5000_CHIP_MIC_CTRL ,2 );
Hrm, on second thoughts I see we're already changing the default so I applied this but we really should just change the driver to leave the device with whatever setting it powers on with - this is an example of the sort of thing we're trying to avoid.