Skip to contentSkip to conversation

ASoC: atmel-ssc: make it buildable on other architectures

PATCH Applied Joachim Eastwood 4 participants 4 messages Dec 8, 2012 – Dec 24, 2012

Subsystems (4)
Sound Char and misc drivers Arm/Microchip (AT91) SoC support Microchip ssc driver
lore
Share & tools
lore

Joachim Eastwood

author
#0 lore raw

PATCH 1/1 ASoC: atmel-ssc: make it buildable on other architectures

Not very useful on non AT91/AVR32 platforms but it provides more build coverage and prepares for ARM multiplatform.

Also fixes a truncated warning that would come when building on a 64-bit arch.

Signed-off-by Joachim Eastwood <[email protected]>

---

Hi Mark,

Sending it to you since seem like you're the last one who commited changes to the driver and the driver is mostly used on ASoC.

Tested on RM9200 and build tested on x86_64.

regards
Joachim Eastwood

 drivers/misc/Kconfig     | 2 +-
 drivers/misc/atmel-ssc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/misc/Kconfig +1 -1
index b151b7c..8f59d88 100644
@@ -192,7 +192,7 @@ config ICS932S401
 
 config ATMEL_SSC
 	tristate "Device driver for Atmel SSC peripheral"
-	depends on AVR32 || ARCH_AT91
+	depends on HAS_IOMEM
 	---help---
 	  This option enables device driver support for Atmel Synchronized
 	  Serial Communication peripheral (SSC).
drivers/misc/atmel-ssc.c +1 -1
index 158da5a..0cee274 100644
@@ -167,7 +167,7 @@ static int ssc_probe(struct platform_device *pdev)
 
 	/* disable all interrupts */
 	clk_enable(ssc->clk);
-	ssc_writel(ssc->regs, IDR, ~0UL);
+	ssc_writel(ssc->regs, IDR, -1);
 	ssc_readl(ssc->regs, SR);
 	clk_disable(ssc->clk);
Signature · 1 line
1.8.0
#1 lore raw

Hi Joachim Eastwood,

Quoted 42 lines · Joachim Eastwood

Not very useful on non AT91/AVR32 platforms but it provides more build coverage and prepares for ARM multiplatform.

Also fixes a truncated warning that would come when building on a 64-bit arch.

Signed-off-by Joachim Eastwood <[email protected]>

---

Hi Mark,

Sending it to you since seem like you're the last one who commited changes to the driver and the driver is mostly used on ASoC.

Tested on RM9200 and build tested on x86_64.

regards
Joachim Eastwood

  drivers/misc/Kconfig     | 2 +-
  drivers/misc/atmel-ssc.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
drivers/misc/Kconfig +1 -1
index b151b7c..8f59d88 100644
@@ -192,7 +192,7 @@ config ICS932S401
 
  config ATMEL_SSC
  	tristate "Device driver for Atmel SSC peripheral"
-	depends on AVR32 || ARCH_AT91
+	depends on HAS_IOMEM
  	---help---
  	  This option enables device driver support for Atmel Synchronized
  	  Serial Communication peripheral (SSC).
drivers/misc/atmel-ssc.c +0 -0
index 158da5a..0cee274 100644

drivers/misc/atmel-ssc.c static int ssc_probe(struct platform_device *pdev) · line 170

Quoted 5 lines
drivers/misc/atmel-ssc.c +1 -1
@@ -167,7 +167,7 @@ static int ssc_probe(struct platform_device *pdev)
 
  	/* disable all interrupts */
  	clk_enable(ssc->clk);
-	ssc_writel(ssc->regs, IDR, ~0UL);
+	ssc_writel(ssc->regs, IDR, -1);

I don't meet building warning on x86_64 machine. So, would you please explain more why need change this?

Best Regards,
Bo Shen

Quoted 4 lines
drivers/misc/atmel-ssc.c +0 -0
  	ssc_readl(ssc->regs, SR);
  	clk_disable(ssc->clk);
Acked-by on v1 1/1
#2 lore raw
In reply to Joachim Eastwood

On 12/08/2012 01:46 PM, Joachim Eastwood :

Quoted 7 lines

Not very useful on non AT91/AVR32 platforms but it provides more build coverage and prepares for ARM multiplatform.

Also fixes a truncated warning that would come when building on a 64-bit arch.

Signed-off-by Joachim Eastwood <[email protected]>

It if needs it to go forward:

Acked-by Nicolas Ferre <[email protected]>
Quoted 44 lines

---

Hi Mark,

Sending it to you since seem like you're the last one who commited changes to the driver and the driver is mostly used on ASoC.

Tested on RM9200 and build tested on x86_64.

regards
Joachim Eastwood

 drivers/misc/Kconfig     | 2 +-
 drivers/misc/atmel-ssc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/misc/Kconfig +1 -1
index b151b7c..8f59d88 100644
@@ -192,7 +192,7 @@ config ICS932S401
 
 config ATMEL_SSC
 	tristate "Device driver for Atmel SSC peripheral"
-	depends on AVR32 || ARCH_AT91
+	depends on HAS_IOMEM
 	---help---
 	  This option enables device driver support for Atmel Synchronized
 	  Serial Communication peripheral (SSC).
drivers/misc/atmel-ssc.c +1 -1
index 158da5a..0cee274 100644
@@ -167,7 +167,7 @@ static int ssc_probe(struct platform_device *pdev)
 
 	/* disable all interrupts */
 	clk_enable(ssc->clk);
-	ssc_writel(ssc->regs, IDR, ~0UL);
+	ssc_writel(ssc->regs, IDR, -1);
 	ssc_readl(ssc->regs, SR);
 	clk_disable(ssc->clk);
Signature · 1 line
Nicolas Ferre
Applied
#3 lore raw
In reply to Joachim Eastwood
Quoted 2 lines · Joachim Eastwood

Not very useful on non AT91/AVR32 platforms but it provides more build coverage and prepares for ARM multiplatform.

Applied, thanks.