Skip to contentSkip to conversation

drivers/platform/x86/thinkpad_acpi.c: Handle HKEY event 0x6040

PATCH In review Richard Hartmann 4 participants 12 messages Dec 26, 2012 – Feb 25, 2013 3 messages not in the archive x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/platform/x86/thinkpad_acpi.c: Handle HKEY event 0x6040

Handle HKEY event generated on AC power change. The current message asks users to submit data related to this event which leads to a lot of confusion and noise on the mailing list.

The following is a list of causes, affected models, and 'message-id' from [email protected] :

AC plug/unplug:

X120e - CAAAujb5v9dHdbdxDVvhNJoG4UrZC1TgKqeB_zGpAy7q8kZHMEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org x121e - 20120817143459.GB3462-eWLsEhkZJs/[email protected]
X220 - Confirmed by Richard Hartmann
X220i - [email protected]
X220t - 4F489F5B.9040705-CFLBMwTPW48UNGrzBIF7/[email protected]
X230 - CAKx4u7kqvVH0-gstomsiVYdGC0i6=bGxzaQ8sq9gbg76TGme3w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org T420 - 9c848ee30b006737d0534d906bab0cf6-l1rQmuElw4w5vnOj3qJKwaxOck334EZe@public.gmane.org T420s - [email protected]
W520 - 20121008181050.GF2549-7RcLWEz+wg2OywUUTrYc/[email protected]

Lid closed/openend:

X220 - [email protected]
Could not be confirmed by author

---
 drivers/platform/x86/thinkpad_acpi.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/platform/x86/thinkpad_acpi.c +9 -3
index 75dd651..2645084 100644
@@ -209,9 +209,8 @@ enum tpacpi_hkey_event_t {
 	TP_HKEY_EV_ALARM_SENSOR_XHOT	= 0x6022, /* sensor critically hot */
 	TP_HKEY_EV_THM_TABLE_CHANGED	= 0x6030, /* thermal table changed */
 
-	TP_HKEY_EV_UNK_6040		= 0x6040, /* Related to AC change?
-						     some sort of APM hint,
-						     W520 */
+	/* AC-related events */
+	TP_HKEY_EV_AC_CHANGED		= 0x6040, /* AC status changed */
 
 	/* Misc */
 	TP_HKEY_EV_RFKILL_CHANGED	= 0x7000, /* rfkill switch changed */
@@ -3629,6 +3628,13 @@ static bool hotkey_notify_6xxx(const u32 hkey,
 			 "a sensor reports something is extremely hot!\n");
 		/* recommended action: immediate sleep/hibernate */
 		break;
+	case TP_HKEY_EV_AC_CHANGED:
+		pr_info("AC status has changed\n");
+		/* X120e, x121e, X220, X220i, X220t, X230, T420, T420s, W520:
+		 * AC status changed; can be triggered by plugging or
+		 * unplugging AC adapter, docking or undocking, or closing
+		 * or opening the lid. */
+		break;
 
 	case TP_HKEY_EV_KEY_NUMLOCK:
 	case TP_HKEY_EV_KEY_FN:
Signature · 9 lines
1.7.10.4


------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
#1 lore raw
Quoted 46 lines · Richard Hartmann

Handle HKEY event generated on AC power change. The current message asks users to submit data related to this event which leads to a lot of confusion and noise on the mailing list.

The following is a list of causes, affected models, and 'message-id' from [email protected] :

AC plug/unplug:

X120e - CAAAujb5v9dHdbdxDVvhNJoG4UrZC1TgKqeB_zGpAy7q8kZHMEQ@mail.gmail.com x121e - [email protected]
X220 - Confirmed by Richard Hartmann
X220i - [email protected]
X220t - [email protected]
X230 - CAKx4u7kqvVH0-gstomsiVYdGC0i6=bGxzaQ8sq9gbg76TGme3w@mail.gmail.com T420 - [email protected] T420s - [email protected]
W520 - [email protected]

Lid closed/openend:

X220 - [email protected]
Could not be confirmed by author

---
 drivers/platform/x86/thinkpad_acpi.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/platform/x86/thinkpad_acpi.c +2 -3
index 75dd651..2645084 100644
@@ -209,9 +209,8 @@ enum tpacpi_hkey_event_t {
 	TP_HKEY_EV_ALARM_SENSOR_XHOT	= 0x6022, /* sensor critically hot */
 	TP_HKEY_EV_THM_TABLE_CHANGED	= 0x6030, /* thermal table changed */
 
-	TP_HKEY_EV_UNK_6040		= 0x6040, /* Related to AC change?
-						     some sort of APM hint,
-						     W520 */
+	/* AC-related events */
+	TP_HKEY_EV_AC_CHANGED		= 0x6040, /* AC status changed */
 
 	/* Misc */
 	TP_HKEY_EV_RFKILL_CHANGED	= 0x7000, /* rfkill switch changed */

drivers/platform/x86/thinkpad_acpi.c static bool hotkey_notify_6xxx(const u32 hkey, · line 3637

Quoted 10 lines
drivers/platform/x86/thinkpad_acpi.c +7 -0
@@ -3629,6 +3628,13 @@ static bool hotkey_notify_6xxx(const u32 hkey,
 			 "a sensor reports something is extremely hot!\n");
 		/* recommended action: immediate sleep/hibernate */
 		break;
+	case TP_HKEY_EV_AC_CHANGED:
+		pr_info("AC status has changed\n");
+		/* X120e, x121e, X220, X220i, X220t, X230, T420, T420s, W520:
+		 * AC status changed; can be triggered by plugging or
+		 * unplugging AC adapter, docking or undocking, or closing
+		 * or opening the lid. */
+		break;

It looks like a pretty useless message to me, AFAICT. If it is only an APM hint, then we probably shouldn't say anything in dmesg but simply ignore it.

I mean, do I additionally want to know that I just connected to AC after I just plugged the cable in? There's this green lamp on the side, doh! :-)

Thanks.

Signature · 2 lines
Regards/Gruss,
Boris.
#2 lore raw
In reply to Richard Hartmann

drivers/platform/x86/thinkpad_acpi.c static bool hotkey_notify_6xxx(const u32 hkey, · line 3640

Quoted 10 lines · Richard Hartmann
drivers/platform/x86/thinkpad_acpi.c +7 -0
+	case TP_HKEY_EV_AC_CHANGED:
+		pr_info("AC status has changed\n");
+		/* X120e, x121e, X220, X220i, X220t, X230, T420, T420s, W520:
+		 * AC status changed; can be triggered by plugging or
+		 * unplugging AC adapter, docking or undocking, or closing
+		 * or opening the lid. */
+		break;
 
 	case TP_HKEY_EV_KEY_NUMLOCK:
 	case TP_HKEY_EV_KEY_FN:

I guess we can drop that pr_info, and please block the issuing of the event to userspace, like this:

case TP_HKEY_EV_AC_CHANGED:
/* X120e, x121e, X220, X220i, X220t, X230, T420, T420s, W520:
* AC status changed; can be triggered by plugging or
* unplugging AC adapter, docking or undocking, or closing
* or opening the lid. */

/* fallthrough */

and letting it proceed to the TP_HKEY_EV_KEY_NUMLOCK block.

Also, do we have any confirmed reports about the lid switch causing event 0x6040? It doesn't look right... the comment might need to be updated.

Signature · 4 lines
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

A message that is not in the archive (sent off-list or not yet received): 20121227103843.GB7894-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org

#4 lore raw
Quoted 2 lines · Henrique de Moraes Holschuh

/* fallthrough */

[...]

Quoted 2 lines

and letting it proceed to the TP_HKEY_EV_KEY_NUMLOCK block.

OK.

Also, do we have any confirmed reports about the lid switch

Quoted 3 lines

causing event 0x6040? It doesn't look right... the comment might need to be updated.

I could not reproduce it on my X220. Would you prefer even stronger wording or should I get of it entirely?

Signature · 1 line
Richard

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712

_______________________________________________
ibm-acpi-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

#5 lore raw
Quoted 13 lines · Richard Hartmann
Quoted 2 lines · Henrique de Moraes Holschuh

/* fallthrough */

[...]

Quoted 2 lines

and letting it proceed to the TP_HKEY_EV_KEY_NUMLOCK block.

OK.

Quoted 7 lines

Also, do we have any confirmed reports about the lid switch

Quoted 3 lines

causing event 0x6040? It doesn't look right... the comment might need to be updated.

I could not reproduce it on my X220. Would you prefer even stronger wording or should I get of it entirely?

If you cannot reproduce it, we can shalk it up to user error or to corrected firmware bug, so you can remove any mention of lid open/close to event 6040...

Signature · 4 lines
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

A message that is not in the archive (sent off-list or not yet received): 20121228101013.GA15327-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org

#7 lore raw
Quoted 5 lines · Henrique de Moraes Holschuh

If you cannot reproduce it, we can shalk it up to user error or to corrected
firmware bug, so you can remove any mention of lid open/close to event 6040...

OK, great.

After some more testing, I suspect he closed the lid and then (un)plugged/docked.

Signature · 1 line
Richard

------------------------------------------------------------------------------
Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and much more. Get web development skills now with LearnDevNow - 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122812

_______________________________________________
ibm-acpi-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

#8 lore raw

PATCH 1/1 drivers/platform/x86/thinkpad_acpi.c: Handle HKEY event 0x6040

Handle HKEY event generated on AC power change. The current message asks users to submit data related to this event which leads to a lot of confusion and noise on the mailing list.

The following is a list affected models and 'Message-Id'
from [email protected] of people who saw this event when either plugging or unplugging the AC adapter or
docking or undocking their laptop.

X120e - CAAAujb5v9dHdbdxDVvhNJoG4UrZC1TgKqeB_zGpAy7q8kZHMEQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org X121e - 20120817143459.GB3462-eWLsEhkZJs/[email protected]
X220 - Confirmed by Richard Hartmann
X220i - [email protected]
X220t - 4F489F5B.9040705-CFLBMwTPW48UNGrzBIF7/[email protected]
X230 - CAKx4u7kqvVH0-gstomsiVYdGC0i6=bGxzaQ8sq9gbg76TGme3w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org T420 - 9c848ee30b006737d0534d906bab0cf6-l1rQmuElw4w5vnOj3qJKwaxOck334EZe@public.gmane.org T420s - [email protected]
W520 - 20121008181050.GF2549-7RcLWEz+wg2OywUUTrYc/[email protected]

---
 drivers/platform/x86/thinkpad_acpi.c |   11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/platform/x86/thinkpad_acpi.c +8 -3
index 75dd651..15e2bba 100644
@@ -209,9 +209,8 @@ enum tpacpi_hkey_event_t {
 	TP_HKEY_EV_ALARM_SENSOR_XHOT	= 0x6022, /* sensor critically hot */
 	TP_HKEY_EV_THM_TABLE_CHANGED	= 0x6030, /* thermal table changed */
 
-	TP_HKEY_EV_UNK_6040		= 0x6040, /* Related to AC change?
-						     some sort of APM hint,
-						     W520 */
+	/* AC-related events */
+	TP_HKEY_EV_AC_CHANGED		= 0x6040, /* AC status changed */
 
 	/* Misc */
 	TP_HKEY_EV_RFKILL_CHANGED	= 0x7000, /* rfkill switch changed */
@@ -3629,6 +3628,12 @@ static bool hotkey_notify_6xxx(const u32 hkey,
 			 "a sensor reports something is extremely hot!\n");
 		/* recommended action: immediate sleep/hibernate */
 		break;
+	case TP_HKEY_EV_AC_CHANGED:
+		/* X120e, X121e, X220, X220i, X220t, X230, T420, T420s, W520:
+		 * AC status changed; can be triggered by plugging or
+		 * unplugging AC adapter, docking or undocking. */
+
+		/* fallthrough */
 
 	case TP_HKEY_EV_KEY_NUMLOCK:
 	case TP_HKEY_EV_KEY_FN:
Signature · 9 lines
1.7.10.4


------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122912
Acked-by on v1 1/1
#9 lore raw
Quoted 19 lines · Richard Hartmann

Handle HKEY event generated on AC power change. The current message asks users to submit data related to this event which leads to a lot of confusion and noise on the mailing list.

The following is a list affected models and 'Message-Id' from [email protected] of people who saw this event when either plugging or unplugging the AC adapter or docking or undocking their laptop.

X120e - CAAAujb5v9dHdbdxDVvhNJoG4UrZC1TgKqeB_zGpAy7q8kZHMEQ@mail.gmail.com X121e - [email protected]
X220 - Confirmed by Richard Hartmann
X220i - [email protected]
X220t - [email protected]
X230 - CAKx4u7kqvVH0-gstomsiVYdGC0i6=bGxzaQ8sq9gbg76TGme3w@mail.gmail.com T420 - [email protected] T420s - [email protected]
W520 - [email protected]

Quoted 1 line
Signature · 2 lines
Regards/Gruss,
Boris.
Acked-by on v1 1/1
#10 lore raw
In reply to Richard Hartmann
Quoted 19 lines · Richard Hartmann

Handle HKEY event generated on AC power change. The current message asks users to submit data related to this event which leads to a lot of confusion and noise on the mailing list.

The following is a list affected models and 'Message-Id' from [email protected] of people who saw this event when either plugging or unplugging the AC adapter or docking or undocking their laptop.

X120e - CAAAujb5v9dHdbdxDVvhNJoG4UrZC1TgKqeB_zGpAy7q8kZHMEQ@mail.gmail.com X121e - [email protected]
X220 - Confirmed by Richard Hartmann
X220i - [email protected]
X220t - [email protected]
X230 - CAKx4u7kqvVH0-gstomsiVYdGC0i6=bGxzaQ8sq9gbg76TGme3w@mail.gmail.com T420 - [email protected] T420s - [email protected]
W520 - [email protected]

Quoted 1 line
Quoted 33 lines
---
 drivers/platform/x86/thinkpad_acpi.c |   11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/platform/x86/thinkpad_acpi.c +8 -3
index 75dd651..15e2bba 100644
@@ -209,9 +209,8 @@ enum tpacpi_hkey_event_t {
 	TP_HKEY_EV_ALARM_SENSOR_XHOT	= 0x6022, /* sensor critically hot */
 	TP_HKEY_EV_THM_TABLE_CHANGED	= 0x6030, /* thermal table changed */
 
-	TP_HKEY_EV_UNK_6040		= 0x6040, /* Related to AC change?
-						     some sort of APM hint,
-						     W520 */
+	/* AC-related events */
+	TP_HKEY_EV_AC_CHANGED		= 0x6040, /* AC status changed */
 
 	/* Misc */
 	TP_HKEY_EV_RFKILL_CHANGED	= 0x7000, /* rfkill switch changed */
@@ -3629,6 +3628,12 @@ static bool hotkey_notify_6xxx(const u32 hkey,
 			 "a sensor reports something is extremely hot!\n");
 		/* recommended action: immediate sleep/hibernate */
 		break;
+	case TP_HKEY_EV_AC_CHANGED:
+		/* X120e, X121e, X220, X220i, X220t, X230, T420, T420s, W520:
+		 * AC status changed; can be triggered by plugging or
+		 * unplugging AC adapter, docking or undocking. */
+
+		/* fallthrough */
 
 	case TP_HKEY_EV_KEY_NUMLOCK:
 	case TP_HKEY_EV_KEY_FN:
Signature · 4 lines
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

A message that is not in the archive (sent off-list or not yet received): 20121230020008.GA24121-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org

#12 lore raw

On Sun, Dec 30, 2012 at 3:00 AM, Henrique de Moraes Holschuh <hmh-N3TV7GIv+o9fyO9Q7EP/[email protected]

Quoted 5 lines

wrote:

Thanks for the two ACKs.

Just to make sure: From how I read the (outdated) Copyright section, you are the maintainer of thinkpad_acpi and thus will copy over the ACKs into my commit message, merge, and forward into what will become 3.9 at some point, correct?

Richard

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012

_______________________________________________
ibm-acpi-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

#13 lore raw
Quoted 6 lines · Richard Hartmann

On Sun, Dec 30, 2012 at 3:00 AM, Henrique de Moraes Holschuh <[email protected]

Quoted 4 lines

wrote:

Quoted 6 lines

Thanks for the two ACKs.

Just to make sure: From how I read the (outdated) Copyright section, you are the maintainer of thinkpad_acpi and thus will copy over the ACKs into my commit message, merge, and forward into what will become 3.9 at some point, correct?

Usually the subsystem maintainer picks such simple patches and ACKs directly from the platform-driver-x86 list email, adds his signed-of-by, and eventually sends it to Linus.

For this "obviously correct" single-code-line fix, we might even lucky out and it could make it to 3.8, depends on his judgment.

Signature · 4 lines
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
#14 lore raw
Quoted 3 lines · Henrique de Moraes Holschuh

Usually the subsystem maintainer picks such simple patches and ACKs directly from the platform-driver-x86 list email, adds his signed-of-by, and eventually sends it to Linus.

Just so this does not get lost, neither Linus' tree nor [1] carry this patch, yet. Is there anything more I can/should do?

Quoted 2 lines

For this "obviously correct" single-code-line fix, we might even lucky out and it could make it to 3.8, depends on his judgment.

Sadly, no.

Thanks,
Richard

[1] git://cavan.codon.org.uk/platform-drivers-x86.git