Bug in latest gitk - can't click lines connecting commits
I was testing some patches against the latest gitk, and noticed that when I click the mouse on the lines that connect the commits in the history graph, I get an error popup with:
Error: can't read "cflist_top": no such variable
Looks like this was introduced in gitk commit b967135d89e8d8461d059
gitk: Synchronize highlighting in file view when scrolling diff
This commit hasn't been merged yet from upstream into git.
Here's the full error trace:
can't read "cflist_top": no such variable
can't read "cflist_top": no such variable
while executing
"$cflist tag remove highlight $cflist_top.0 "$cflist_top.0 lineend""
(procedure "highlightfile" line 4)
invoked from within
"highlightfile 0"
(procedure "highlightfile_for_scrollpos" line 8) invoked from within
"highlightfile_for_scrollpos $topidx"
(procedure "scrolltext" line 9)
invoked from within
"scrolltext 0.0 1.0"
(vertical scrolling command executed by text)
-Jason
Quoted 7 lines · Jason Holden
I was testing some patches against the latest gitk, and noticed that when I click the mouse on the lines that connect the commits in the history graph, I get an error popup with:
Error: can't read "cflist_top": no such variableLooks like this was introduced in gitk commit
b967135d89e8d8461d059
gitk: Synchronize highlighting in file view when scrolling diff
A patch that fixes this was proposed over two months ago, and Paul said he had applied it:
<http://permalink.gmane.org/gmane.comp.version-control.git/208162>
However, looking at git://ozlabs.org/~paulus/gitk.git it's not there. Paul?
Signature · 3 lines
Stefan Haller Berlin, Germany http://www.haller-berlin.de/
Quoted 10 lines · Stefan Haller
Quoted 7 lines · Jason Holden
I was testing some patches against the latest gitk, and noticed that when I click the mouse on the lines that connect the commits in the history graph, I get an error popup with:
Error: can't read "cflist_top": no such variableLooks like this was introduced in gitk commit
b967135d89e8d8461d059
gitk: Synchronize highlighting in file view when scrolling diff
Quoted 7 lines
A patch that fixes this was proposed over two months ago, and Paul said he had applied it:
<http://permalink.gmane.org/gmane.comp.version-control.git/208162>
However, looking at
git://ozlabs.org/~paulus/gitk.gitit's not there. Paul?
I just forgot to push it out. It's there now.
Paul.
Quoted 14 lines · Paul Mackerras
Quoted 13 lines · Stefan Haller
Quoted 7 lines · Jason Holden
I was testing some patches against the latest gitk, and noticed that when I click the mouse on the lines that connect the commits in the history graph, I get an error popup with:
Error: can't read "cflist_top": no such variableLooks like this was introduced in gitk commit
b967135d89e8d8461d059
gitk: Synchronize highlighting in file view when scrolling diffA patch that fixes this was proposed over two months ago, and Paul said he had applied it:
Quoted 6 lines
Quoted 4 lines
<http://permalink.gmane.org/gmane.comp.version-control.git/208162>
However, looking at
git://ozlabs.org/~paulus/gitk.gitit's not there. Paul?I just forgot to push it out. It's there now.
I notice that I have a handful of commits that I haven't pulled from your repository, and the last commit on your 'master' is about 20 days old. Is it safe for me to pull these now?
I can teach myself that your push is your pull-request, but I do not think we agreed to arrange it that way yet, so...
Quoted 4 lines · Junio C Hamano
I notice that I have a handful of commits that I haven't pulled from your repository, and the last commit on your 'master' is about 20 days old. Is it safe for me to pull these now?
Yes, please pull them now.
Regards,
Paul.
Quoted 7 lines · Paul Mackerras
Quoted 4 lines · Junio C Hamano
I notice that I have a handful of commits that I haven't pulled from your repository, and the last commit on your 'master' is about 20 days old. Is it safe for me to pull these now?
Yes, please pull them now.
Thanks.