Skip to contentSkip to conversation

vfs: Add missing errno.h inclusion to namei.h

PATCH In review Mark Brown 3 participants 4 messages Jan 2, 2013 – Jan 3, 2013 VFS

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 vfs: Add missing errno.h inclusion to namei.h

In current -next namei.h now include/linux/namei.h uses ESTALE but does not include errno.h, leading to build failures on ARM where errno.h is not previously implicitly included by some other header as is the case in some bits of ext3. Fix this by adding a direct inclusion of errno.h.

---
 include/linux/namei.h |    1 +
 1 file changed, 1 insertion(+)
include/linux/namei.h +1 -0
index e998c03..5a5ff57 100644
@@ -2,6 +2,7 @@
 #define _LINUX_NAMEI_H
 
 #include <linux/dcache.h>
+#include <linux/errno.h>
 #include <linux/linkage.h>
 #include <linux/path.h>
 
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 15 lines · On Wed, 2 Jan 2013 13:36:26 +0000 Mark Brown…

In current -next namei.h now include/linux/namei.h uses ESTALE but does not include errno.h, leading to build failures on ARM where errno.h is not previously implicitly included by some other header as is the case in some bits of ext3. Fix this by adding a direct inclusion of errno.h.

---
 include/linux/namei.h |    1 +
 1 file changed, 1 insertion(+)
include/linux/namei.h +0 -0
index e998c03..5a5ff57 100644

include/linux/namei.h line 8

Quoted 7 lines
include/linux/namei.h +1 -0
@@ -2,6 +2,7 @@
 #define _LINUX_NAMEI_H
 
 #include <linux/dcache.h>
+#include <linux/errno.h>
 #include <linux/linkage.h>
 #include <linux/path.h>
 

I think Ted and Stephen (cc'ed here) proposed the same patch a week or so ago, but I'm not sure why Al hasn't pushed it yet.

Signature · 1 line
Jeff Layton <[email protected]>
author
#2 lore raw
Quoted 2 lines · Jeff Layton

I think Ted and Stephen (cc'ed here) proposed the same patch a week or so ago, but I'm not sure why Al hasn't pushed it yet.

Well, a Christmas vacation isn't totally unreasonable...

maintainer
#3 lore raw
Quoted 6 lines · Mark Brown
Quoted 2 lines · Jeff Layton

I think Ted and Stephen (cc'ed here) proposed the same patch a week or so ago, but I'm not sure why Al hasn't pushed it yet.

Well, a Christmas vacation isn't totally unreasonable...

Arrgh... My apologies - it had sat applied since 25th, but hadn't been pushed and pull request hadn't been sent. Linus, could you pull git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus

Shortlog:
Stephen Warren (1):
namei.h: include errno.h

Diffstat:

 include/linux/namei.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)