mips: bcm47xx: select GPIOLIB for BCMA on bcm47xx platform
Subsystems (2)
PATCH 1/1 mips: bcm47xx: select GPIOLIB for BCMA on bcm47xx platform
The Kconfig items BCM47XX_BCMA and BCM47XX_SSB selected respectively BCMA_DRIVER_GPIO and SSB_DRIVER_GPIO. These options depend on GPIOLIB without explicitly selecting it so it results in a warning when GPIOLIB is not set:
scripts/kconfig/conf --oldconfig Kconfig
warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO ... unmet direct
dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB) warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO ... unmet direct dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
which subsequently results in compile errors.
--- arch/mips/bcm47xx/Kconfig | 3 +++ 1 file changed, 3 insertions(+)
arch/mips/bcm47xx/Kconfig +3 -0
@@ -8,8 +8,10 @@ config BCM47XX_SSB select SSB_DRIVER_EXTIF select SSB_EMBEDDED select SSB_B43_PCI_BRIDGE if PCI + select SSB_DRIVER_PCICORE if PCI select SSB_PCICORE_HOSTMODE if PCI select SSB_DRIVER_GPIO + select GPIOLIB default y help Add support for old Broadcom BCM47xx boards with Sonics Silicon Backplane support.
@@ -25,6 +27,7 @@ config BCM47XX_BCMA select BCMA_HOST_PCI if PCI select BCMA_DRIVER_PCI_HOSTMODE if PCI select BCMA_DRIVER_GPIO + select GPIOLIB default y help Add support for new Broadcom BCM47xx boards with Broadcom specific Advanced Microcontroller Bus.
Signature · 1 line
1.7.10.4
Shouldn't this go to Ralf?
Quoted 47 lines · Arend van Spriel
The
KconfigitemsBCM47XX_BCMAandBCM47XX_SSBselected respectivelyBCMA_DRIVER_GPIOandSSB_DRIVER_GPIO. These options depend on GPIOLIB without explicitly selecting it so it results in a warning when GPIOLIB is not set:
scripts/kconfig/conf--oldconfigKconfig
warning: (BCM47XX_BCMA) selectsBCMA_DRIVER_GPIO... unmet directdependencies (BCMA_POSSIBLE && BCMA && GPIOLIB) warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO ... unmet direct dependencies (SSB_POSSIBLE && SSB && GPIOLIB)which subsequently results in compile errors.
Cc Hauke Mehrtens <[email protected]>Signed-off-by Arend van Spriel <[email protected]>--- arch/mips/bcm47xx/Kconfig | 3 +++ 1 file changed, 3 insertions(+)arch/mips/bcm47xx/Kconfig +3
-0@@ -8,8 +8,10 @@ config BCM47XX_SSB select SSB_DRIVER_EXTIF select SSB_EMBEDDED select SSB_B43_PCI_BRIDGE if PCI + select SSB_DRIVER_PCICORE if PCI select SSB_PCICORE_HOSTMODE if PCI select SSB_DRIVER_GPIO + select GPIOLIB default y help Add support for old Broadcom BCM47xx boards with Sonics Silicon Backplane support.@@ -25,6 +27,7 @@ config BCM47XX_BCMA select BCMA_HOST_PCI if PCI select BCMA_DRIVER_PCI_HOSTMODE if PCI select BCMA_DRIVER_GPIO + select GPIOLIB default y help Add support for new Broadcom BCM47xx boards with Broadcom specific Advanced Microcontroller Bus.Signature · 1 line
1.7.10.4
Signature · 2 lines
John W. Linville Someday the world will need a hero, and you [email protected] might be all we have. Be ready.
Quoted 1 line · John W. Linville
Shouldn't this go to Ralf?
Ah, sorry. You are my default target for patches ;-) I will resend it to Ralf.
Gr. AvS
Quoted 49 lines · Arend van Spriel
Quoted 47 lines
The
KconfigitemsBCM47XX_BCMAandBCM47XX_SSBselected respectivelyBCMA_DRIVER_GPIOandSSB_DRIVER_GPIO. These options depend on GPIOLIB without explicitly selecting it so it results in a warning when GPIOLIB is not set:
scripts/kconfig/conf--oldconfigKconfig
warning: (BCM47XX_BCMA) selectsBCMA_DRIVER_GPIO... unmet directdependencies (BCMA_POSSIBLE && BCMA && GPIOLIB) warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO ... unmet direct dependencies (SSB_POSSIBLE && SSB && GPIOLIB)which subsequently results in compile errors.
Cc Hauke Mehrtens <[email protected]>Signed-off-by Arend van Spriel <[email protected]>--- arch/mips/bcm47xx/Kconfig | 3 +++ 1 file changed, 3 insertions(+)arch/mips/bcm47xx/Kconfig +3
-0@@ -8,8 +8,10 @@ config BCM47XX_SSB select SSB_DRIVER_EXTIF select SSB_EMBEDDED select SSB_B43_PCI_BRIDGE if PCI + select SSB_DRIVER_PCICORE if PCI select SSB_PCICORE_HOSTMODE if PCI select SSB_DRIVER_GPIO + select GPIOLIB default y help Add support for old Broadcom BCM47xx boards with Sonics Silicon Backplane support.@@ -25,6 +27,7 @@ config BCM47XX_BCMA select BCMA_HOST_PCI if PCI select BCMA_DRIVER_PCI_HOSTMODE if PCI select BCMA_DRIVER_GPIO + select GPIOLIB default y help Add support for new Broadcom BCM47xx boards with Broadcom specific Advanced Microcontroller Bus.Signature · 1 line
1.7.10.4