Status of the patches under review at LMML (35 patches)
This is the summary of the patches that are currently under review at Linux Media Mailing List <[email protected]>.
Each patch is represented by its submission date, the subject (up to 70 chars) and the patchwork link (if submitted via email).
P.S.: This email is c/c to the developers where some action is expected.
If you were copied, please review the patches, acking/nacking or submitting an update.
== New patches ==
Those patches require some review from the community:
This one could break again DVB-S->DVB-S2 support, so, it needs to be carefully reviewed and tested:
Jun,21 2012: [media] dvb frontend core: tuning in ISDB-T using DVB API v3 http://patchwork.linuxtv.org/patch/12988 Olivier Grenie <[email protected]>
This one fix a code that, IMHO, should, instead be replaced by something better:
Sep,17 2012: [3/3] cx25821: Cleanup filename assignment code http://patchwork.linuxtv.org/patch/14445 Peter Senna Tschudin <[email protected]>
This one doesn't seem right for me. Anybody can test/work with it?
Sep, 2 2012: fix: iMon Knob event interpretation issues http://patchwork.linuxtv.org/patch/16030 Alexandre Lissy <[email protected]>
I'm not sure if we should apply this one or not, as it will increase the probability of miss-interpreting a nec IR protocol. Comments?
Jul,26 2012: media: rc: Add support to decode Remotes using NECx IR protocol http://patchwork.linuxtv.org/patch/13480 Ravi Kumar V <[email protected]>
== Manu Abraham <[email protected]> ==
Those patches are there for a long time. I think I'll simply apply all of them, if they're not reviewed on the next couple weeks:
Mar,11 2012: [2/3] stv090x: use error counter 1 for BER estimation http://patchwork.linuxtv.org/patch/10301 Andreas Regel <[email protected]> Mar,11 2012: [3/3] stv090x: On STV0903 do not set registers of the second path. http://patchwork.linuxtv.org/patch/10302 Andreas Regel <[email protected]> Nov,29 2011: stv090x: implement function for reading uncorrected blocks count http://patchwork.linuxtv.org/patch/8656 Mariusz Bia?o?czyk <[email protected]> Jun, 8 2011: Add remote control support for mantis http://patchwork.linuxtv.org/patch/7217 Christoph Pinkl <[email protected]> Apr, 1 2012: [05/11] Slightly more friendly debugging output. http://patchwork.linuxtv.org/patch/10520 "Steinar H. Gunderson" <[email protected]> Apr, 1 2012: [06/11] Replace ca_lock by a slightly more general int_stat_lock. http://patchwork.linuxtv.org/patch/10521 "Steinar H. Gunderson" <[email protected]> Apr, 1 2012: [07/11] Fix a ton of SMP-unsafe accesses. http://patchwork.linuxtv.org/patch/10523 "Steinar H. Gunderson" <[email protected]> Apr, 1 2012: [08/11] Remove some unused structure members. http://patchwork.linuxtv.org/patch/10525 "Steinar H. Gunderson" <[email protected]> Apr, 1 2012: [09/11] Correct wait_event_timeout error return check. http://patchwork.linuxtv.org/patch/10526 "Steinar H. Gunderson" <[email protected]> Apr, 1 2012: [10/11] Ignore timeouts waiting for the IRQ0 flag. http://patchwork.linuxtv.org/patch/10527 "Steinar H. Gunderson" <[email protected]> Apr, 1 2012: [11/11] Enable Mantis CA support. http://patchwork.linuxtv.org/patch/10524 "Steinar H. Gunderson" <[email protected]>
== Prabhakar Lad <[email protected]> ==
Aug,24 2012: Corrected Oops on omap_vout when no manager is connected http://patchwork.linuxtv.org/patch/14033 Federico Fuga <[email protected]> Oct,22 2012: [media] davinci: vpbe: fix missing unlock on error in vpbe_initialize( http://patchwork.linuxtv.org/patch/15106 Wei Yongjun <[email protected]> Oct,24 2012: [media] vpif_display: fix return value check in vpif_reqbufs() http://patchwork.linuxtv.org/patch/15167 Wei Yongjun <[email protected]>
== Maxim Levitsky <[email protected]> ==
Oct,15 2012: [1/4,media] ene-ir: Fix cleanup on probe failure http://patchwork.linuxtv.org/patch/15024 Matthijs Kooijman <[email protected]>
== Guennadi Liakhovetski <[email protected]> ==
Oct,30 2012: [v2,2/4] media: mx2_camera: Add image size HW limits. http://patchwork.linuxtv.org/patch/15298 Javier Martin <[email protected]> Nov,13 2012: sh_vou: Move from videobuf to videobuf2 http://patchwork.linuxtv.org/patch/15433 Laurent Pinchart <[email protected]> Nov,16 2012: [05/14,media] atmel-isi: Update error check for unsigned variables http://patchwork.linuxtv.org/patch/15475 Tushar Behera <[email protected]> Jan, 3 2013: [1/3] sh_vou: Don't modify const variable in sh_vou_s_crop() http://patchwork.linuxtv.org/patch/16095 Laurent Pinchart <[email protected]> Jan, 3 2013: [2/3] sh_vou: Use video_drvdata() http://patchwork.linuxtv.org/patch/16097 Laurent Pinchart <[email protected]> Jan, 3 2013: [3/3] sh_vou: Use vou_dev instead of vou_file wherever possible http://patchwork.linuxtv.org/patch/16096 Laurent Pinchart <[email protected]>
== Laurent Pinchart <[email protected]> ==
Dec,12 2012: [v2] ad5820: Voice coil motor controller driver http://patchwork.linuxtv.org/patch/15881 Florian Neuhaus <[email protected]> Jan, 4 2013: omap3isp: Add support for interlaced input data http://patchwork.linuxtv.org/patch/16133 William Swanson <[email protected]> Sep, 4 2012: [5/5] drivers/media/platform/omap3isp/isp.c: fix error return code http://patchwork.linuxtv.org/patch/14169 Peter Senna Tschudin <[email protected]>
== Sylwester Nawrocki <[email protected]> ==
Dec,28 2012: [1/3,media] s5p-mfc: use mfc_err instead of printk http://patchwork.linuxtv.org/patch/16012 Sachin Kamat <[email protected]> Jan, 6 2013: s5p-tv: mixer: fix handling of VIDIOC_S_FMT http://patchwork.linuxtv.org/patch/16143 Tomasz Stanislawski <[email protected]>
== Marek Szyprowski <[email protected]> ==
Nov,12 2012: [media] videobuf2-core: print current state of buffer in vb2_buffer_do http://patchwork.linuxtv.org/patch/15420 Tushar Behera <[email protected]>
== Sascha Hauer <[email protected]> ==
Sacha is returing next week. He should be addressing this issue by them:
Nov,14 2012: [media] coda: Fix build due to iram.h rename http://patchwork.linuxtv.org/patch/15447 Fabio Estevam <[email protected]>
== Mauro Carvalho Chehab <[email protected]> ==
Those are my own RFC patches. I should rework the QoS patches next week/weekend:
Dec,28 2012: [RFCv3] dvb: Add DVBv5 properties for quality parameters http://patchwork.linuxtv.org/patch/16026 Mauro Carvalho Chehab <[email protected]> Dec,28 2012: [RFC, media] dvb: frontend API: Add a flag to indicate that get_fronte http://patchwork.linuxtv.org/patch/16024 Mauro Carvalho Chehab <[email protected]> Jan, 1 2013: [RFCv3] dvb: Add DVBv5 properties for quality parameters http://patchwork.linuxtv.org/patch/16053 Mauro Carvalho Chehab <[email protected]>
Number of pending patches per reviewer:
Manu Abraham <[email protected]> : 11 Guennadi Liakhovetski <[email protected]> : 6 LinuxTV community : 4 Laurent Pinchart <[email protected]> : 3 Mauro Carvalho Chehab <[email protected]> : 3 Prabhakar Lad <[email protected]> : 3 Sylwester Nawrocki <[email protected]> : 2 Sascha Hauer <[email protected]> : 1 Maxim Levitsky <[email protected]> : 1 Marek Szyprowski <[email protected]> : 1
Cheers,
Mauro
---
If you discover any patch submitted via email that weren't caught by kernel.patchwork.org, this means that the patch got mangled by your emailer. The more likely cause is that the emailer converted tabs into spaces or broke long lines. Please fix your emailer and re-send.
Hi,
Quoted 5 lines · Mauro Carvalho Chehab
This is the summary of the patches that are currently under review at Linux Media Mailing List <[email protected]>.
Each patch is represented by its submission date, the subject (up to 70 chars) and the patchwork link (if submitted via email).
<Snip>
Quoted 4 lines
== Prabhakar Lad <[email protected]> ==Aug,24 2012: Corrected Oops on
omap_voutwhen no manager is connected http://patchwork.linuxtv.org/patch/14033 Federico Fuga <[email protected]>
Tomi can you take care of this patch ?
Quoted 1 line
Oct,22 2012: [media] davinci: vpbe: fix missing unlock on error in vpbe_initialize( http://patchwork.linuxtv.org/patch/15106 Wei Yongjun <[email protected]>
This can be marked as 'Accepted'.
Quoted 1 line
Oct,24 2012: [media]
vpif_display: fix return value check invpif_reqbufs()http://patchwork.linuxtv.org/patch/15167 Wei Yongjun <[email protected]>
This patch can be marked as 'Superseded'.
Regards,
--Prabhakar
Quoted 70 lines
== Maxim Levitsky <[email protected]> ==Oct,15 2012: [1/4,media] ene-ir: Fix cleanup on probe failure http://patchwork.linuxtv.org/patch/15024 Matthijs Kooijman <[email protected]>
== Guennadi Liakhovetski <[email protected]> ==Oct,30 2012: [v2,2/4] media: mx2_camera: Add image size HW limits. http://patchwork.linuxtv.org/patch/15298 Javier Martin <[email protected]> Nov,13 2012: sh_vou: Move from videobuf to videobuf2 http://patchwork.linuxtv.org/patch/15433 Laurent Pinchart <[email protected]> Nov,16 2012: [05/14,media] atmel-isi: Update error check for unsigned variables http://patchwork.linuxtv.org/patch/15475 Tushar Behera <[email protected]> Jan, 3 2013: [1/3] sh_vou: Don't modify const variable in sh_vou_s_crop() http://patchwork.linuxtv.org/patch/16095 Laurent Pinchart <[email protected]> Jan, 3 2013: [2/3] sh_vou: Use video_drvdata() http://patchwork.linuxtv.org/patch/16097 Laurent Pinchart <[email protected]> Jan, 3 2013: [3/3] sh_vou: Use vou_dev instead of vou_file wherever possible http://patchwork.linuxtv.org/patch/16096 Laurent Pinchart <[email protected]>== Laurent Pinchart <[email protected]> ==Dec,12 2012: [v2] ad5820: Voice coil motor controller driver http://patchwork.linuxtv.org/patch/15881 Florian Neuhaus <[email protected]> Jan, 4 2013: omap3isp: Add support for interlaced input data http://patchwork.linuxtv.org/patch/16133 William Swanson <[email protected]> Sep, 4 2012: [5/5] drivers/media/platform/omap3isp/isp.c: fix error return code http://patchwork.linuxtv.org/patch/14169 Peter Senna Tschudin <[email protected]>== Sylwester Nawrocki <[email protected]> ==Dec,28 2012: [1/3,media] s5p-mfc: use mfc_err instead of printk http://patchwork.linuxtv.org/patch/16012 Sachin Kamat <[email protected]> Jan, 6 2013: s5p-tv: mixer: fix handling of VIDIOC_S_FMT http://patchwork.linuxtv.org/patch/16143 Tomasz Stanislawski <[email protected]>== Marek Szyprowski <[email protected]> ==Nov,12 2012: [media] videobuf2-core: print current state of buffer in
vb2_buffer_dohttp://patchwork.linuxtv.org/patch/15420 Tushar Behera <[email protected]>== Sascha Hauer <[email protected]> ==Sacha is returing next week. He should be addressing this issue by them:
Nov,14 2012: [media] coda: Fix build due toiram.hrename http://patchwork.linuxtv.org/patch/15447 Fabio Estevam <[email protected]>== Mauro Carvalho Chehab <[email protected]> ==Those are my own RFC patches. I should rework the QoS patches next week/weekend:
Dec,28 2012: [RFCv3] dvb: Add DVBv5 properties for quality parameters http://patchwork.linuxtv.org/patch/16026 Mauro Carvalho Chehab <[email protected]> Dec,28 2012: [RFC, media] dvb: frontend API: Add a flag to indicate that get_fronte http://patchwork.linuxtv.org/patch/16024 Mauro Carvalho Chehab <[email protected]> Jan, 1 2013: [RFCv3] dvb: Add DVBv5 properties for quality parameters http://patchwork.linuxtv.org/patch/16053 Mauro Carvalho Chehab <[email protected]>Number of pending patches per reviewer:
Manu Abraham <[email protected]> : 11 Guennadi Liakhovetski <[email protected]> : 6 LinuxTV community : 4 Laurent Pinchart <[email protected]> : 3 Mauro Carvalho Chehab <[email protected]> : 3 Prabhakar Lad <[email protected]> : 3 Sylwester Nawrocki <[email protected]> : 2 Sascha Hauer <[email protected]> : 1 Maxim Levitsky <[email protected]> : 1 Marek Szyprowski <[email protected]> : 1Cheers,
Mauro---
If you discover any patch submitted via email that weren't caught by kernel.patchwork.org, this means that the patch got mangled by your emailer. The more likely cause is that the emailer converted tabs into spaces or broke long lines. Please fix your emailer and re-send.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Prabhakar,
Quoted 6 lines · On Monday 07 January 2013 11:26:01 Prabhakar Lad wrote:
Quoted 4 lines · Mauro Carvalho Chehab
This is the summary of the patches that are currently under review at Linux Media Mailing List <[email protected]>.
Each patch is represented by its submission date, the subject (up to 70 chars) and the patchwork link (if submitted via email).
Quoted 8 lines
<Snip>
Quoted 5 lines
== Prabhakar Lad <[email protected]> ==Aug,24 2012: Corrected Oops on
omap_voutwhen no manager is connected
http://patchwork.linuxtv.org/patch/14033 Federico Fuga
<[email protected]>Tomi can you take care of this patch ?
Tomi is on parental leave until beginning of February. Beside, he doesn't have much experience with the omap_vout driver. We need an Acked-by on this patch before he can take it in his tree.
Signature · 3 lines
Regards, Laurent Pinchart
Hi Laurent,
Quoted 13 lines · Laurent Pinchart
Hi Prabhakar,
Quoted 10 lines · On Monday 07 January 2013 11:26:01 Prabhakar Lad wrote:
Quoted 4 lines · Mauro Carvalho Chehab
This is the summary of the patches that are currently under review at Linux Media Mailing List <[email protected]>.
Each patch is represented by its submission date, the subject (up to 70 chars) and the patchwork link (if submitted via email).<Snip>
Quoted 2 lines
== Prabhakar Lad <[email protected]> ==
Quoted 9 lines
Quoted 4 lines
Quoted 3 lines
Aug,24 2012: Corrected Oops on
omap_voutwhen no manager is connected
http://patchwork.linuxtv.org/patch/14033 Federico Fuga
<[email protected]>Tomi can you take care of this patch ?
Tomi is on parental leave until beginning of February. Beside, he doesn't have much experience with the
omap_voutdriver. We need an Acked-by on this patch before he can take it in his tree.
Thanks for the info, I did contact Vaibhav even he is on leave till Jan-20.
Murali can you Ack/Review this patch so that Tomi can pick it up when hes back from
vacation (this patch doesnt apply on 3.8)
Regards,
--Prabhakar
Quoted 5 lines
--
Regards,Laurent Pinchart
Quoted 11 lines · Mauro Carvalho Chehab
This is the summary of the patches that are currently under review at Linux Media Mailing List <[email protected]>.
Each patch is represented by its submission date, the subject (up to 70 chars) and the patchwork link (if submitted via email).
P.S.: This email is c/c to the developers where some action is expected.
If you were copied, please review the patches, acking/nacking or submitting an update.== New patches ==
...
Quoted 3 lines
== Sylwester Nawrocki <[email protected]> ==Dec,28 2012: [1/3,media] s5p-mfc: use
mfc_errinstead of printk http://patchwork.linuxtv.org/patch/16012 Sachin Kamat <[email protected]>
This patch doesn't apply any more, it's superseded by this patch from Kamil, that includes same change - http://patchwork.linuxtv.org/patch/16073
Quoted 1 line
Jan, 6 2013: s5p-tv: mixer: fix handling of
VIDIOC_S_FMThttp://patchwork.linuxtv.org/patch/16143 Tomasz Stanislawski <[email protected]>
And it's been decided to postpone merging of this one for some time, so I've marked it as Under review.
--
Thanks,
Sylwester
Hi Mauro,
Quoted 9 lines · On Sunday 06 January 2013 11:34:55 Mauro Carvalho Chehab wrote:
This is the summary of the patches that are currently under review at Linux Media Mailing List <[email protected]>.
Each patch is represented by its submission date, the subject (up to 70 chars) and the patchwork link (if submitted via email).
P.S.: This email is c/c to the developers where some action is expected.
If you were copied, please review the patches, acking/nacking or submitting an update.
[snip]
Quoted 5 lines
== Laurent Pinchart <[email protected]> ==Dec,12 2012: [v2] ad5820: Voice coil motor controller driver
http://patchwork.linuxtv.org/patch/15881
Florian Neuhaus <[email protected]>
Still under review, I haven't had time to look into it yet.
Quoted 3 lines
Jan, 4 2013: omap3isp: Add support for interlaced input data
http://patchwork.linuxtv.org/patch/16133
William Swanson <[email protected]>
The patch is still under review, I've asked for more information today.
Quoted 4 lines
Sep, 4 2012: [5/5]
drivers/media/platform/omap3isp/isp.c: fix error return code
http://patchwork.linuxtv.org/patch/14169
Peter Senna Tschudin <[email protected]>
This one is already in mainline.
Signature · 3 lines
Regards, Laurent Pinchart
Hi Mauro
Quoted 3 lines · Mauro Carvalho Chehab
== Guennadi Liakhovetski <[email protected]> ==Oct,30 2012: [v2,2/4] media:
mx2_camera: Add image size HW limits. http://patchwork.linuxtv.org/patch/15298 Javier Martin <[email protected]>
In the mainline as commit 6ec5575c381de50b17e68796435f20ce1b27de79
Quoted 1 line
Nov,13 2012:
sh_vou: Move from videobuf to videobuf2 http://patchwork.linuxtv.org/patch/15433 Laurent Pinchart <[email protected]>
Patch has to be fixed.
Quoted 1 line
Nov,16 2012: [05/14,media] atmel-isi: Update error check for unsigned variables http://patchwork.linuxtv.org/patch/15475 Tushar Behera <[email protected]>
Hmm, I'll push it (or an equivalent of it) in the second 3.9 pull request
Quoted 3 lines
Jan, 3 2013: [1/3] sh_vou: Don't modify const variable in sh_vou_s_crop() http://patchwork.linuxtv.org/patch/16095 Laurent Pinchart <[email protected]> Jan, 3 2013: [2/3] sh_vou: Use video_drvdata() http://patchwork.linuxtv.org/patch/16097 Laurent Pinchart <[email protected]> Jan, 3 2013: [3/3] sh_vou: Use vou_dev instead of vou_file wherever possible http://patchwork.linuxtv.org/patch/16096 Laurent Pinchart <[email protected]>
These ones arrived after my pull request, I'll take care of them in the next pull round.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
Quoted 36 lines · Mauro Carvalho Chehab
This is the summary of the patches that are currently under review at Linux Media Mailing List <[email protected]>.
Each patch is represented by its submission date, the subject (up to 70 chars) and the patchwork link (if submitted via email).
P.S.: This email is c/c to the developers where some action is expected.
If you were copied, please review the patches, acking/nacking or submitting an update.== New patches ==
Those patches require some review from the community:
This one could break again DVB-S->DVB-S2 support, so, it needs to be carefully reviewed and tested:
Jun,21 2012: [media] dvb frontend core: tuning in ISDB-T using DVB API v3 http://patchwork.linuxtv.org/patch/12988 Olivier Grenie <[email protected]>
This one fix a code that, IMHO, should, instead be replaced by something better:
Sep,17 2012: [3/3] cx25821: Cleanup filename assignment code http://patchwork.linuxtv.org/patch/14445 Peter Senna Tschudin <[email protected]>This one doesn't seem right for me. Anybody can test/work with it?
Sep, 2 2012: fix: iMon Knob event interpretation issues http://patchwork.linuxtv.org/patch/16030 Alexandre Lissy <[email protected]>I'm not sure if we should apply this one or not, as it will increase the probability of miss-interpreting a nec IR protocol. Comments?
Jul,26 2012: media: rc: Add support to decode Remotes using NECx IR protocol http://patchwork.linuxtv.org/patch/13480 Ravi Kumar V <[email protected]>== Manu Abraham <[email protected]> ==Those patches are there for a long time. I think I'll simply apply all of them, if they're not reviewed on the next couple weeks:
Quoted 11 lines
Mar,11 2012: [2/3] stv090x: use error counter 1 for BER estimation http://patchwork.linuxtv.org/patch/10301 Andreas Regel <[email protected]> Mar,11 2012: [3/3] stv090x: On STV0903 do not set registers of the second path. http://patchwork.linuxtv.org/patch/10302 Andreas Regel <[email protected]> Nov,29 2011: stv090x: implement function for reading uncorrected blocks count http://patchwork.linuxtv.org/patch/8656 Mariusz Bia?o?czyk <[email protected]> Jun, 8 2011: Add remote control support for mantis http://patchwork.linuxtv.org/patch/7217 Christoph Pinkl <[email protected]> Apr, 1 2012: [05/11] Slightly more friendly debugging output. http://patchwork.linuxtv.org/patch/10520 "Steinar H. Gunderson" <[email protected]> Apr, 1 2012: [06/11] Replace ca_lock by a slightly more general int_stat_lock. http://patchwork.linuxtv.org/patch/10521 "Steinar H. Gunderson" <[email protected]> Apr, 1 2012: [07/11] Fix a ton of SMP-unsafe accesses. http://patchwork.linuxtv.org/patch/10523 "Steinar H. Gunderson" <[email protected]> Apr, 1 2012: [08/11] Remove some unused structure members. http://patchwork.linuxtv.org/patch/10525 "Steinar H. Gunderson" <[email protected]> Apr, 1 2012: [09/11] Correct wait_event_timeout error return check. http://patchwork.linuxtv.org/patch/10526 "Steinar H. Gunderson" <[email protected]> Apr, 1 2012: [10/11] Ignore timeouts waiting for the IRQ0 flag. http://patchwork.linuxtv.org/patch/10527 "Steinar H. Gunderson" <[email protected]> Apr, 1 2012: [11/11] Enable Mantis CA support. http://patchwork.linuxtv.org/patch/10524 "Steinar H. Gunderson" <[email protected]>
Somehow, these patches missed me. This weekend, I am traveling. I will take a look at it during the weekend after that one.
Regards,
Manu
Manu Abraham
Acked-byQuoted 8 lines · Mauro Carvalho Chehab
This is the summary of the patches that are currently under review at Linux Media Mailing List <[email protected]>.
Each patch is represented by its submission date, the subject (up to 70 chars) and the patchwork link (if submitted via email).
Quoted 6 lines
== Manu Abraham <[email protected]> ==Those patches are there for a long time. I think I'll simply apply all of them, if they're not reviewed on the next couple weeks:
Mar,11 2012: [2/3] stv090x: use error counter 1 for BER estimation http://patchwork.linuxtv.org/patch/10301 Andreas Regel <[email protected]>
I am not at all sure on this patch. If there is a valid test result on this patch, then I am all for it.
Quoted 1 line
Mar,11 2012: [3/3] stv090x: On STV0903 do not set registers of the second path. http://patchwork.linuxtv.org/patch/10302 Andreas Regel <[email protected]>
Patch seems mostly correct, there are some unpleasantness in it. But nevertheless it looks okay. Haven't tested it at all.
Quoted 1 line
Nov,29 2011: stv090x: implement function for reading uncorrected blocks count http://patchwork.linuxtv.org/patch/8656 Mariusz Bia?o?czyk <[email protected]>
Comments within patchwork itself.
Quoted 1 line
Jun, 8 2011: Add remote control support for mantis http://patchwork.linuxtv.org/patch/7217 Christoph Pinkl <[email protected]>
I did test this patch a while back. It didn't work as expected at all.
Quoted 1 line
Apr, 1 2012: [05/11] Slightly more friendly debugging output. http://patchwork.linuxtv.org/patch/10520 "Steinar H. Gunderson" <[email protected]>
Simply a cosmetic patch. Doesn't bring any advantage. Knowing what
MMIO address failed doesn't help at all. If you have failures, then you
will have failures with the entire mapped addresses. So AFAICT, this patch doesn't bring any advantage to help in additional debugging either.
Quoted 1 line
Apr, 1 2012: [06/11] Replace
ca_lockby a slightly more generalint_stat_lock. http://patchwork.linuxtv.org/patch/10521 "Steinar H. Gunderson" <[email protected]>
This is actually sleeping in interrupt context. All it does is a cosmetic name change and adding a mutex across the IRQ handler, which is
not a valid thing to do.
Quoted 1 line
Apr, 1 2012: [07/11] Fix a ton of SMP-unsafe accesses. http://patchwork.linuxtv.org/patch/10523 "Steinar H. Gunderson" <[email protected]>
Use of volatile .. I am not sure. It does need a lock someplace, but I am not sure whether this patch is doing correctly at all.
Quoted 1 line
Apr, 1 2012: [08/11] Remove some unused structure members. http://patchwork.linuxtv.org/patch/10525 "Steinar H. Gunderson" <[email protected]>
The enumeration holds the status of the SmartBuffer, currently it is not being checked against. Deleting it might not be a useful thing.. ? Though the gpif_status in the mantis_dev structure could be removed, thus removing a dereference.
Quoted 1 line
Apr, 1 2012: [09/11] Correct
wait_event_timeouterror return check. http://patchwork.linuxtv.org/patch/10526 "Steinar H. Gunderson" <[email protected]>
Patch is correct, but likely needs to be regenerated, being dependant on another patch
Quoted 1 line
Apr, 1 2012: [10/11] Ignore timeouts waiting for the IRQ0 flag. http://patchwork.linuxtv.org/patch/10527 "Steinar H. Gunderson" <[email protected]>
There is something really wrong going on. The CPU went into a loop and hence reads do not return. Ignoring timeouts doesn't seem the proper way to me.
Quoted 1 line
Apr, 1 2012: [11/11] Enable Mantis CA support. http://patchwork.linuxtv.org/patch/10524 "Steinar H. Gunderson" <[email protected]>
Not yet there.
Manu,
Please reply to the original thread or c/c the original author to let him know and answer to you.
Em Tue, 15 Jan 2013 16:57:26 +0530
Manu Abraham <[email protected]> escreveu:
Andreas,
Please see the comment below:
Quoted 8 lines
Quoted 4 lines
Those patches are there for a long time. I think I'll simply apply all of them, if they're not reviewed on the next couple weeks:
Mar,11 2012: [2/3] stv090x: use error counter 1 for BER estimation http://patchwork.linuxtv.org/patch/10301 Andreas Regel <[email protected]>
I am not at all sure on this patch. If there is a valid test result on this patch, then I am all for it.
Signature · 2 lines
Cheers, Mauro
Christoph,
Please see the comments below.
Em Tue, 15 Jan 2013 16:57:26 +0530
Manu Abraham <[email protected]> escreveu:
Quoted 4 lines
Quoted 1 line
Jun, 8 2011: Add remote control support for mantis http://patchwork.linuxtv.org/patch/7217 Christoph Pinkl <[email protected]>
I did test this patch a while back. It didn't work as expected at all.
Regards,
Mauro
Steinar,
Please see the comments below.
Regards,
Mauro
Em Tue, 15 Jan 2013 16:57:26 +0530
Manu Abraham <[email protected]> escreveu:
Quoted 15 lines
Quoted 1 line
Apr, 1 2012: [05/11] Slightly more friendly debugging output. http://patchwork.linuxtv.org/patch/10520 "Steinar H. Gunderson" <[email protected]>
Simply a cosmetic patch. Doesn't bring any advantage. Knowing what
MMIO address failed doesn't help at all. If you have failures, then you
will have failures with the entire mapped addresses. So AFAICT, this patch doesn't bring any advantage to help in additional debugging either.Quoted 1 line
Apr, 1 2012: [06/11] Replace
ca_lockby a slightly more generalint_stat_lock. http://patchwork.linuxtv.org/patch/10521 "Steinar H. Gunderson" <[email protected]>This is actually sleeping in interrupt context. All it does is a cosmetic name change and adding a mutex across the IRQ handler, which is
not a valid thing to do.
Quoted 5 lines
Quoted 1 line
Apr, 1 2012: [07/11] Fix a ton of SMP-unsafe accesses. http://patchwork.linuxtv.org/patch/10523 "Steinar H. Gunderson" <[email protected]>
Use of volatile .. I am not sure. It does need a lock someplace, but I am not sure whether this patch is doing correctly at all.
True.
Steinar, volatile generally doesn't work in kernel. You should either use RCU, atomic_t or some locking to protect the data access instead.
Quoted 27 lines
Quoted 3 lines
Apr, 1 2012: [08/11] Remove some unused structure members. http://patchwork.linuxtv.org/patch/10525 "Steinar H. Gunderson" <[email protected]>
The enumeration holds the status of the SmartBuffer, currently it is not being checked against. Deleting it might not be a useful thing.. ? Though the
gpif_statusin themantis_devstructure could be removed, thus removing a dereference.Quoted 1 line
Apr, 1 2012: [09/11] Correct
wait_event_timeouterror return check. http://patchwork.linuxtv.org/patch/10526 "Steinar H. Gunderson" <[email protected]>Patch is correct, but likely needs to be regenerated, being dependant on another patch
Quoted 1 line
Apr, 1 2012: [10/11] Ignore timeouts waiting for the IRQ0 flag. http://patchwork.linuxtv.org/patch/10527 "Steinar H. Gunderson" <[email protected]>
There is something really wrong going on. The CPU went into a loop and hence reads do not return. Ignoring timeouts doesn't seem the proper way to me.
Quoted 1 line
Apr, 1 2012: [11/11] Enable Mantis CA support. http://patchwork.linuxtv.org/patch/10524 "Steinar H. Gunderson" <[email protected]>
Not yet there.
Signature · 2 lines
Cheers, Mauro
Quoted 3 lines · Mauro Carvalho Chehab
Steinar,
Please see the comments below.
Hi,
I've given up getting DVB in Linux to work long time ago; if you do not want the patches as-is, feel free to reject them.
/* Steinar */
Signature · 1 line
Homepage: http://www.sesse.net/