nfsd: fix unused "nn" variable warning in free_client()
Subsystems (2)
PATCH 1/1 nfsd: fix unused "nn" variable warning in free_client()
If CONFIG_LOCKDEP is disabled, then there would be a warning like this:
CC [M] fs/nfsd/nfs4state.ofs/nfsd/nfs4state.c: In function ‘free_client’:fs/nfsd/nfs4state.c:1051:19: warning: unused variable ‘nn’ [-Wunused-variable]
So, let's add "maybe_unused" tag to this variable.
--- fs/nfsd/nfs4state.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
fs/nfsd/nfs4state.c +1 -1
@@ -1048,7 +1048,7 @@ static struct nfs4_client *alloc_client(struct xdr_netobj name)static inline void free_client (struct nfs4_client *clp) { -struct nfsd_net *nn =net_generic (clp->net, nfsd_net_id); +struct nfsd_net __maybe_unused *nn =net_generic (clp->net, nfsd_net_id);lockdep_assert_held (&nn->client_lock);while (!list_empty (&clp->cl_sessions)) {
Bruce, sorry, forgot to add:
09.01.2013 13:38, Stanislav Kinsbursky пишет:
Quoted 27 lines
If
CONFIG_LOCKDEPis disabled, then there would be a warning like this:CC [M]
fs/nfsd/nfs4state.ofs/nfsd/nfs4state.c: In function ‘free_client’:fs/nfsd/nfs4state.c:1051:19: warning: unused variable ‘nn’ [-Wunused-variable]So, let's add "
maybe_unused" tag to this variable.Signed-off-by Stanislav Kinsbursky <[email protected]>--- fs/nfsd/nfs4state.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)fs/nfsd/nfs4state.c +1
-1@@ -1048,7 +1048,7 @@ static struct nfs4_client *alloc_client(struct xdr_netobj name)static inline void free_client (struct nfs4_client *clp) { -struct nfsd_net *nn =net_generic (clp->net, nfsd_net_id); +struct nfsd_net __maybe_unused *nn =net_generic (clp->net, nfsd_net_id);lockdep_assert_held (&nn->client_lock);while (!list_empty (&clp->cl_sessions)) {
Signature · 2 lines
Best regards, Stanislav Kinsbursky
Quoted 3 lines · Stanislav Kinsbursky
Bruce, sorry, forgot to add:
Reported-by Toralf Förster <[email protected]>
Thanks, added that, and committing for 3.9.--b.
Quoted 34 lines
09.01.2013 13:38, Stanislav Kinsbursky пишет:
Quoted 27 lines
If
CONFIG_LOCKDEPis disabled, then there would be a warning like this:CC [M]
fs/nfsd/nfs4state.ofs/nfsd/nfs4state.c: In function ‘free_client’:fs/nfsd/nfs4state.c:1051:19: warning: unused variable ‘nn’ [-Wunused-variable]So, let's add "
maybe_unused" tag to this variable.Signed-off-by Stanislav Kinsbursky <[email protected]>--- fs/nfsd/nfs4state.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)fs/nfsd/nfs4state.c +1
-1@@ -1048,7 +1048,7 @@ static struct nfs4_client *alloc_client(struct xdr_netobj name)static inline void free_client (struct nfs4_client *clp) { -struct nfsd_net *nn =net_generic (clp->net, nfsd_net_id); +struct nfsd_net __maybe_unused *nn =net_generic (clp->net, nfsd_net_id);lockdep_assert_held (&nn->client_lock);while (!list_empty (&clp->cl_sessions)) {Signature · 2 lines
Best regards, Stanislav Kinsbursky