mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error
PATCH 1/1 mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error
TPS65910 mfd driver uses functions that are only avaiable when REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd Kconfig to fix below build error:
drivers/built-in.o: In function `tps65910_irq_exit':
/media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference to regmap_del_irq_chip' drivers/built-in.o: In function tps65910_irq_init':
/media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference to regmap_add_irq_chip' drivers/built-in.o: In function tps65910_i2c_probe':
/media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
make: *** [vmlinux] Error 1
--- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/mfd/Kconfig +1 -0
@@ -237,6 +237,7 @@ config MFD_TPS65910 depends on I2C=y && GPIOLIB select MFD_CORE select REGMAP_I2C + select REGMAP_IRQ select IRQ_DOMAIN help if you say yes here you get support for the TPS65910 series of
Signature · 1 line
1.7.9.5
Quoted 22 lines · Chimata
TPS65910 mfd driver uses functions that are only avaiable when
REGMAP_IRQis enabled. So "selectREGMAP_IRQ" is added to mfdKconfigto fix below build error:
drivers/built-in.o: In function `tps65910_irq_exit':
/media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference toregmap_del_irq_chip' drivers/built-in.o: In functiontps65910_irq_init':
/media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference toregmap_add_irq_chip' drivers/built-in.o: In functiontps65910_i2c_probe':
/media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
make: *** [vmlinux] Error 1Signed-off-by AnilKumar Ch <[email protected]>--- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/mfd/Kconfig +0
-0
drivers/mfd/Kconfig config MFD_TPS65910 · line 243
Quoted 7 lines
drivers/mfd/Kconfig +1
-0@@ -237,6 +237,7 @@ config MFD_TPS65910 depends on I2C=y && GPIOLIB select MFD_CORE select REGMAP_I2C + select REGMAP_IRQ select IRQ_DOMAIN help if you say yes here you get support for the TPS65910 series of
Hi Samuel,
If there are no comments on this patch could you please pull?
Thanks
AnilKumar
Quoted 22 lines · Chimata
TPS65910 mfd driver uses functions that are only avaiable when
REGMAP_IRQis enabled. So "selectREGMAP_IRQ" is added to mfdKconfigto fix below build error:
drivers/built-in.o: In function `tps65910_irq_exit':
/media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference toregmap_del_irq_chip' drivers/built-in.o: In functiontps65910_irq_init':
/media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference toregmap_add_irq_chip' drivers/built-in.o: In functiontps65910_i2c_probe':
/media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
make: *** [vmlinux] Error 1Signed-off-by AnilKumar Ch <[email protected]>--- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/mfd/Kconfig +0
-0
drivers/mfd/Kconfig config MFD_TPS65910 · line 243
Quoted 7 lines
drivers/mfd/Kconfig +1
-0@@ -237,6 +237,7 @@ config MFD_TPS65910 depends on I2C=y && GPIOLIB select MFD_CORE select REGMAP_I2C + select REGMAP_IRQ select IRQ_DOMAIN help if you say yes here you get support for the TPS65910 series of
Hi Samuel,
Could you please pull this fix?
Thanks
AnilKumar
Matt Porter
Tested-byQuoted 33 lines · AnilKumar
Quoted 22 lines · Chimata
TPS65910 mfd driver uses functions that are only avaiable when
REGMAP_IRQis enabled. So "selectREGMAP_IRQ" is added to mfdKconfigto fix below build error:
drivers/built-in.o: In function `tps65910_irq_exit':
/media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference toregmap_del_irq_chip' drivers/built-in.o: In functiontps65910_irq_init':
/media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference toregmap_add_irq_chip' drivers/built-in.o: In functiontps65910_i2c_probe':
/media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
make: *** [vmlinux] Error 1Signed-off-by AnilKumar Ch <[email protected]>--- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/mfd/Kconfig +0
-0drivers/mfd/Kconfig config MFD_TPS65910 · line 243
Quoted 7 lines
drivers/mfd/Kconfig +1
-0@@ -237,6 +237,7 @@ config MFD_TPS65910 depends on I2C=y && GPIOLIB select MFD_CORE select REGMAP_I2C + select REGMAP_IRQ select IRQ_DOMAIN help if you say yes here you get support for the TPS65910 series ofHi Samuel,
Quoted 1 line
Could you please pull this fix?
Fixes broken OMAP kernel build here too.
-Matt
Quoted 34 lines · Matt
Quoted 33 lines · AnilKumar
Quoted 22 lines · Chimata
TPS65910 mfd driver uses functions that are only avaiable when
REGMAP_IRQis enabled. So "selectREGMAP_IRQ" is added to mfdKconfigto fix below build error:
drivers/built-in.o: In function `tps65910_irq_exit':
/media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference toregmap_del_irq_chip' drivers/built-in.o: In functiontps65910_irq_init':
/media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference toregmap_add_irq_chip' drivers/built-in.o: In functiontps65910_i2c_probe':
/media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
make: *** [vmlinux] Error 1Signed-off-by AnilKumar Ch <[email protected]>--- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/mfd/Kconfig +0
-0drivers/mfd/Kconfig config MFD_TPS65910 · line 243
Quoted 7 lines
drivers/mfd/Kconfig +1
-0@@ -237,6 +237,7 @@ config MFD_TPS65910 depends on I2C=y && GPIOLIB select MFD_CORE select REGMAP_I2C + select REGMAP_IRQ select IRQ_DOMAIN help if you say yes here you get support for the TPS65910 series ofHi Samuel,
Quoted 6 lines
Quoted 1 line
Could you please pull this fix?
Tested-by Matt Porter <[email protected]>Fixes broken OMAP kernel build here too.
Hi Samuel,
Could you please take this in?
Thanks
AnilKumar
Samuel Ortiz
AppliedHi Anilkumar,
Quoted 12 lines · AnilKumar Ch
TPS65910 mfd driver uses functions that are only avaiable when
REGMAP_IRQis enabled. So "selectREGMAP_IRQ" is added to mfdKconfigto fix below build error:
drivers/built-in.o: In function `tps65910_irq_exit':
/media/anil/kernel/drivers/mfd/tps65910.c:265: undefined reference toregmap_del_irq_chip' drivers/built-in.o: In functiontps65910_irq_init':
/media/anil/kernel/drivers/mfd/tps65910.c:254: undefined reference toregmap_add_irq_chip' drivers/built-in.o: In functiontps65910_i2c_probe':
/media/anil/kernel/drivers/mfd/tps65910.c:509: undefined reference to `regmap_irq_get_domain'
make: *** [vmlinux] Error 1
Quoted 4 lines
Signed-off-by AnilKumar Ch <[email protected]>--- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)
Applied to my for-linus branch. Sorry for not carrying it with my 3.8 pull request.
Cheers,
Samuel.
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/