Skip to contentSkip to conversation

bnx2x: move debugging code before the return

PATCH Applied Dan Carpenter 3 participants 3 messages Jan 10, 2013

Subsystems (4)
Networking Network drivers Kernel janitors Broadcom BNX2X 10 gigabit Ethernet driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 bnx2x: move debugging code before the return

I move the return down a line after the debugging printk.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c +1 -1
index 292634f..d7029c8 100644
@@ -2768,10 +2768,10 @@ static int bnx2x_set_rss_flags(struct bnx2x *bp, struct ethtool_rxnfc *info)
 		} else if ((info->flow_type == UDP_V6_FLOW) &&
 			   (bp->rss_conf_obj.udp_rss_v6 != udp_rss_requested)) {
 			bp->rss_conf_obj.udp_rss_v6 = udp_rss_requested;
-			return bnx2x_config_rss_pf(bp, &bp->rss_conf_obj, 0);
 			DP(BNX2X_MSG_ETHTOOL,
 			   "rss re-configured, UDP 4-tupple %s\n",
 			   udp_rss_requested ? "enabled" : "disabled");
+			return bnx2x_config_rss_pf(bp, &bp->rss_conf_obj, 0);
 		} else {
 			return 0;
 		}
Acked-by on v1 1/1
#1 lore raw
Quoted 33 lines

-----Original Message-----
From: [email protected] [mailto:netdev- [email protected]] On Behalf Of Dan Carpenter
Sent: Thursday, January 10, 2013 10:58 AM
To: Eilon Greenstein
Cc: [email protected]; [email protected]
Subject: [patch] bnx2x: move debugging code before the return

I move the return down a line after the debugging printk.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c +1 -1
index 292634f..d7029c8 100644
@@ -2768,10 +2768,10 @@ static int bnx2x_set_rss_flags(struct bnx2x *bp,
 struct ethtool_rxnfc *info)
 		} else if ((info->flow_type = UDP_V6_FLOW) &&
 			   (bp->rss_conf_obj.udp_rss_v6 !> udp_rss_requested)) {
 			bp->rss_conf_obj.udp_rss_v6 = udp_rss_requested;
-			return bnx2x_config_rss_pf(bp, &bp->rss_conf_obj,
 0);
 			DP(BNX2X_MSG_ETHTOOL,
 			   "rss re-configured, UDP 4-tupple %s\n",
 			   udp_rss_requested ? "enabled" : "disabled");
+			return bnx2x_config_rss_pf(bp, &bp->rss_conf_obj,
 0);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c +0 -1
 		} else {
 			return 0;
 		}
--
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Thanks Dan.

Acked-by Ariel Elior <[email protected]>