staging: go7007: print the audio input type

PATCH New Dan Carpenter 1 participant 1 message Jan 10, 2013

Subsystems (3)

Media (V4L/DVB) Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2013-01-10 09:00 UTC #0 lore raw

PATCH 1/1 staging: go7007: print the audio input type

Smatch complains that the "Audio input:" printk isn't reachable. Hiding the "return 0;" behind another statement is a style violation.

It looks like audio_input is normally configured so I've enabled the print statement.

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/media/go7007/s2250-board.c +1 -1

index d60e065..37400bf 100644
@@ -534,7 +534,7 @@ static int s2250_log_status(struct v4l2_subdev *sd)
 	v4l2_info(sd, "Brightness: %d\n", state->brightness);
 	v4l2_info(sd, "Contrast: %d\n", state->contrast);
 	v4l2_info(sd, "Saturation: %d\n", state->saturation);
-	v4l2_info(sd, "Hue: %d\n", state->hue);	return 0;
+	v4l2_info(sd, "Hue: %d\n", state->hue);
 	v4l2_info(sd, "Audio input: %s\n", state->audio_input = 0 ? "Line In" :
 					state->audio_input = 1 ? "Mic" :
 					state->audio_input = 2 ? "Mic Boost" :