Skip to contentSkip to conversation

Staging: comedi: add a missing break statement

PATCH In review Dan Carpenter 2 participants 2 messages Jan 13, 2013 – Jan 14, 2013

Subsystems (2)
Staging Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 Staging: comedi: add a missing break statement

This is a static checker fix. From the context it looks like there should be a break here.

Signed-off-by Dan Carpenter <[email protected]>

---
Please review this carefully. I think it's probably correct, but I'd appreciate an Ack from someone who knows comedi better.

drivers/staging/comedi/drivers/ni_tiocmd.c +1 -0
index 0c991b9..13747f3 100644
@@ -159,6 +159,7 @@ static int ni_tio_input_cmd(struct ni_gpct *counter, struct comedi_async *async)
 		async->inttrig = NULL;
 		mite_dma_arm(counter->mite_chan);
 		retval = ni_tio_arm(counter, 1, cmd->start_arg);
+		break;
 	case TRIG_OTHER:
 		async->inttrig = NULL;
 		mite_dma_arm(counter->mite_chan);
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Dan Carpenter

This is a static checker fix. From the context it looks like there should be a break here.

Signed-off-by Dan Carpenter <[email protected]>

---
Please review this carefully. I think it's probably correct, but I'd appreciate an Ack from someone who knows comedi better.

drivers/staging/comedi/drivers/ni_tiocmd.c +0 -0
index 0c991b9..13747f3 100644

drivers/staging/comedi/drivers/ni_tiocmd.c static int ni_tio_input_cmd(struct ni_gpct *counter, struct comedi_async *async) · line 165

Quoted 7 lines
drivers/staging/comedi/drivers/ni_tiocmd.c +1 -0
@@ -159,6 +159,7 @@ static int ni_tio_input_cmd(struct ni_gpct *counter, struct comedi_async *async)
  		async->inttrig = NULL;
  		mite_dma_arm(counter->mite_chan);
  		retval = ni_tio_arm(counter, 1, cmd->start_arg);
+		break;
  	case TRIG_OTHER:
  		async->inttrig = NULL;
  		mite_dma_arm(counter->mite_chan);
Acked-by Ian Abbott <[email protected]>
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-