Skip to contentSkip to conversation

clk: remove exported function from __init section

PATCH In review Denis Efremov 3 participants 3 messages Jan 6, 2013 – Jan 14, 2013 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: remove exported function from __init section

The symbol of_fixed_clk_setup is exported and annotated __init. This looks like section mismatch.
Fix this by removing the __init annotation of of_fixed_clk_setup.

---
 drivers/clk/clk-fixed-rate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk-fixed-rate.c +1 -1
index af78ed6..a53b53b 100644
@@ -85,7 +85,7 @@ struct clk *clk_register_fixed_rate(struct device *dev, const char *name,
 /**
  * of_fixed_clk_setup() - Setup function for simple fixed rate clock
  */
-void __init of_fixed_clk_setup(struct device_node *node)
+void of_fixed_clk_setup(struct device_node *node)
 {
 	struct clk *clk;
 	const char *clk_name = node->name;
Signature · 1 line
1.7.10.4
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Denis Efremov

The symbol of_fixed_clk_setup is exported and annotated __init. This looks like section mismatch.
Fix this by removing the __init annotation of of_fixed_clk_setup.

Mike should take this.

Quoted 18 lines
---
 drivers/clk/clk-fixed-rate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk-fixed-rate.c +1 -1
index af78ed6..a53b53b 100644
@@ -85,7 +85,7 @@ struct clk *clk_register_fixed_rate(struct device *dev, const char *name,
 /**
  * of_fixed_clk_setup() - Setup function for simple fixed rate clock
  */
-void __init of_fixed_clk_setup(struct device_node *node)
+void of_fixed_clk_setup(struct device_node *node)
 {
 	struct clk *clk;
 	const char *clk_name = node->name;
#2 lore raw

Quoting Rob Herring (2013-01-06 06:58:40)

Quoted 11 lines · Denis Efremov
Quoted 5 lines

The symbol of_fixed_clk_setup is exported and annotated __init. This looks like section mismatch.
Fix this by removing the __init annotation of of_fixed_clk_setup.

Mike should take this.

Thanks for catching this Denis. Taken into clk-next.

Regards,
Mike

Quoted 18 lines
Quoted 18 lines
---
 drivers/clk/clk-fixed-rate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk-fixed-rate.c +1 -1
index af78ed6..a53b53b 100644
@@ -85,7 +85,7 @@ struct clk *clk_register_fixed_rate(struct device *dev, const char *name,
 /**
  * of_fixed_clk_setup() - Setup function for simple fixed rate clock
  */
-void __init of_fixed_clk_setup(struct device_node *node)
+void of_fixed_clk_setup(struct device_node *node)
 {
      struct clk *clk;
      const char *clk_name = node->name;