sysfs: sysfs_update_group always fails and generates a WARNING CALL-trace

From fe40df7d716658a1fbdab79768628c81d4363428 Mon Sep 17 00:00:00 2001

@sysfs_update_group@ always fails and borns a WARNING CALL-trace if the group exists. BUT still now, no *reference* of this routine at all.

Quoted 1 line

From fe40df7d716658a1fbdab79768628c81d4363428 Mon Sep 17 00:00:00 2001

From: yanyg <[email protected]>
Date: Wed, 16 Jan 2013 11:25:15 +0800
Subject: [PATCH] sysfs-fixes:

@sysfs_update_group@ always fail and generates WARNING CALL trace. fix @internal_create_group@ to avoid it.

---
 fs/sysfs/group.c |   14 ++++++++++----
 1 files changed, 10 insertions(+), 4 deletions(-)

fs/sysfs/group.c +9 -4

index 2df555c..51fcf62 100644
@@ -60,7 +60,7 @@ static int internal_create_group(struct kobject *kobj, int update,
 				 const struct attribute_group *grp)
 {
 	struct sysfs_dirent *sd;
-	int error;
+	int error, do_put = 0;
 
 	BUG_ON(!kobj || (!update && !kobj->sd));
 

@@ -73,9 +73,14 @@ static int internal_create_group(struct kobject *kobj, int update,
 		return -EINVAL;
 	}
 	if (grp->name) {
-		error = sysfs_create_subdir(kobj, grp->name, &sd);
-		if (error)
-			return error;
+		sd = sysfs_get_dirent(kobj->sd, NULL, grp->name);
+		if (sd) {
+			do_put = 1;
+		} else {
+			error = sysfs_create_subdir(kobj, grp->name, &sd);
+			if (error)
+				return error;
+		}
 	} else
 		sd = kobj->sd;
 	sysfs_get(sd);

Quoted 2 lines

@sysfs_update_group@ always fails and borns a WARNING CALL-trace if the group exists. BUT still now, no *reference* of this routine at all.

I don't understand.

Quoted 6 lines

Quoted 2 lines

From fe40df7d716658a1fbdab79768628c81d4363428 Mon Sep 17 00:00:00 2001

From: yanyg <[email protected]>
Date: Wed, 16 Jan 2013 11:25:15 +0800
Subject: [PATCH] sysfs-fixes:

Quoted 2 lines

@sysfs_update_group@ always fail and generates WARNING CALL trace. fix @internal_create_group@ to avoid it.

Why did you embed the patch here, with the words above it? I would have to edit it to apply it :(

It's also not in a format I can apply (no signed-off-by: line.)

Quoted 37 lines

---
  fs/sysfs/group.c |   14 ++++++++++----
  1 files changed, 10 insertions(+), 4 deletions(-)

fs/sysfs/group.c +9 -4

index 2df555c..51fcf62 100644
@@ -60,7 +60,7 @@ static int internal_create_group(struct kobject *kobj, int update,
  				 const struct attribute_group *grp)
  {
  	struct sysfs_dirent *sd;
-	int error;
+	int error, do_put = 0;
 
  	BUG_ON(!kobj || (!update && !kobj->sd));
 

@@ -73,9 +73,14 @@ static int internal_create_group(struct kobject *kobj, int update,
  		return -EINVAL;
  	}
  	if (grp->name) {
-		error = sysfs_create_subdir(kobj, grp->name, &sd);
-		if (error)
-			return error;
+		sd = sysfs_get_dirent(kobj->sd, NULL, grp->name);
+		if (sd) {
+			do_put = 1;
+		} else {
+			error = sysfs_create_subdir(kobj, grp->name, &sd);
+			if (error)
+				return error;
+		}
  	} else
  		sd = kobj->sd;
  	sysfs_get(sd);

fs/sysfs/group.c static int internal_create_group(struct kobject *kobj, int update, · line 93

Quoted 4 lines

fs/sysfs/group.c +1 -0

@@ -85,6 +90,7 @@ static int internal_create_group(struct kobject *kobj, int update,
  			sysfs_remove_subdir(sd);
  	}
  	sysfs_put(sd);
+	if (do_put) sysfs_put(sd);

Always run your patches through scripts/checkpatch.pl and fix the problems it tells you about.

What code in the kernel is hitting this today?

thanks,

greg k-h