Skip to contentSkip to conversation

ide: Remove wrong assertion

PATCH Applied Kevin Wolf 2 participants 2 messages Jan 16, 2013

lore
Share & tools
lore

Kevin Wolf

author
#0 lore raw

PATCH 1/1 ide: Remove wrong assertion

The Bus Master IDE Active bit (BM_STATUS_DMAING) is not only set when the request is still in flight, but also when it has completed and the size of the physical memory regions in the PRDT was larger than the transfer size.

Signed-off-by Kevin Wolf <[email protected]>
---
 hw/ide/pci.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
hw/ide/pci.c +0 -1
index e6226e3..59fd539 100644
@@ -311,7 +311,6 @@ void bmdma_cmd_writeb(BMDMAState *bm, uint32_t val)
             if (bm->bus->dma->aiocb) {
                 bdrv_drain_all();
                 assert(bm->bus->dma->aiocb == NULL);
-                assert((bm->status & BM_STATUS_DMAING) == 0);
             }
         } else {
             bm->cur_addr = bm->addr;
Signature · 1 line
1.7.6.5
Applied
#1 lore raw
Quoted 9 lines · Kevin Wolf

The Bus Master IDE Active bit (BM_STATUS_DMAING) is not only set when the request is still in flight, but also when it has completed and the size of the physical memory regions in the PRDT was larger than the transfer size.

Signed-off-by Kevin Wolf <[email protected]>
---
 hw/ide/pci.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan