ARM: remove unnecessary 'select GENERIC_GPIO'

PATCH New Shawn Guo 3 participants 5 messages Jan 15, 2013 – Jan 18, 2013

Subsystems (4)

Arm (32-bit) Arm sub-architectures Broadcom BCM281XX/BCM11XXX/BCM216XX Arm architecture Arm/VT8500 Arm architecture

lore

Share & tools

lore

Shawn Guo

author

2013-01-15 13:13 UTC #0 lore raw

PATCH 1/1 ARM: remove unnecessary 'select GENERIC_GPIO'

The only use of GENERIC_GPIO (defined by architecture) in GPIO subsystem is being selected by GPIOLIB. Also there are no any use of the option at architecture level. Only two sub-architectures shmobile and orion really use the option as below.

  arch/arm/mach-shmobile/Makefile:obj-$(CONFIG_GENERIC_GPIO)      += $(pfc-y)
  arch/arm/plat-orion/Makefile:orion-gpio-$(CONFIG_GENERIC_GPIO) += gpio.o

Remove all those unnecessary sub-architecture level selection of GENERIC_GPIO, which are there only for confusing people.

Signed-off-by Shawn Guo <[email protected]>

---
 arch/arm/Kconfig                |    9 ---------
 arch/arm/mach-bcm/Kconfig       |    1 -
 arch/arm/mach-picoxcell/Kconfig |    1 -
 arch/arm/mach-vt8500/Kconfig    |    1 -
 4 files changed, 12 deletions(-)

arch/arm/Kconfig +0 -9

index 67874b8..c217521 100644
@@ -347,7 +347,6 @@ config ARCH_BCM2835
 	select COMMON_CLK
 	select CPU_V6
 	select GENERIC_CLOCKEVENTS
-	select GENERIC_GPIO
 	select MULTI_IRQ_HANDLER
 	select PINCTRL
 	select PINCTRL_BCM2835

@@ -644,7 +643,6 @@ config ARCH_TEGRA
 	select CLKSRC_MMIO
 	select COMMON_CLK
 	select GENERIC_CLOCKEVENTS
-	select GENERIC_GPIO
 	select HAVE_CLK
 	select HAVE_SMP
 	select MIGHT_HAVE_CACHE_L2X0

@@ -744,7 +742,6 @@ config ARCH_S3C24XX
 	select ARCH_HAS_CPUFREQ
 	select ARCH_USES_GETTIMEOFFSET
 	select CLKDEV_LOOKUP
-	select GENERIC_GPIO
 	select HAVE_CLK
 	select HAVE_S3C2410_I2C if I2C
 	select HAVE_S3C2410_WATCHDOG if WATCHDOG

@@ -787,7 +784,6 @@ config ARCH_S5P64X0
 	select CLKSRC_MMIO
 	select CPU_V6
 	select GENERIC_CLOCKEVENTS
-	select GENERIC_GPIO
 	select HAVE_CLK
 	select HAVE_S3C2410_I2C if I2C
 	select HAVE_S3C2410_WATCHDOG if WATCHDOG

@@ -802,7 +798,6 @@ config ARCH_S5PC100
 	select ARCH_USES_GETTIMEOFFSET
 	select CLKDEV_LOOKUP
 	select CPU_V7
-	select GENERIC_GPIO
 	select HAVE_CLK
 	select HAVE_S3C2410_I2C if I2C
 	select HAVE_S3C2410_WATCHDOG if WATCHDOG

@@ -820,7 +815,6 @@ config ARCH_S5PV210
 	select CLKSRC_MMIO
 	select CPU_V7
 	select GENERIC_CLOCKEVENTS
-	select GENERIC_GPIO
 	select HAVE_CLK
 	select HAVE_S3C2410_I2C if I2C
 	select HAVE_S3C2410_WATCHDOG if WATCHDOG

@@ -838,7 +832,6 @@ config ARCH_EXYNOS
 	select CLKDEV_LOOKUP
 	select CPU_V7
 	select GENERIC_CLOCKEVENTS
-	select GENERIC_GPIO
 	select HAVE_CLK
 	select HAVE_S3C2410_I2C if I2C
 	select HAVE_S3C2410_WATCHDOG if WATCHDOG

@@ -873,7 +866,6 @@ config ARCH_U300
 	select COMMON_CLK
 	select CPU_ARM926T
 	select GENERIC_CLOCKEVENTS
-	select GENERIC_GPIO
 	select HAVE_TCM
 	select SPARSE_IRQ
 	help

@@ -957,7 +949,6 @@ config ARCH_VT8500_SINGLE
 	select COMMON_CLK
 	select CPU_ARM926T
 	select GENERIC_CLOCKEVENTS
-	select GENERIC_GPIO
 	select HAVE_CLK
 	select MULTI_IRQ_HANDLER
 	select SPARSE_IRQ

arch/arm/mach-bcm/Kconfig +0 -1

index 48705c1..bf02471 100644
@@ -7,7 +7,6 @@ config ARCH_BCM
 	select ARM_GIC
 	select CPU_V7
 	select GENERIC_CLOCKEVENTS
-	select GENERIC_GPIO
 	select GENERIC_TIME
 	select GPIO_BCM
 	select SPARSE_IRQ

arch/arm/mach-picoxcell/Kconfig +0 -1

index 868796f..13bae78 100644
@@ -7,7 +7,6 @@ config ARCH_PICOXCELL
 	select DW_APB_TIMER
 	select DW_APB_TIMER_OF
 	select GENERIC_CLOCKEVENTS
-	select GENERIC_GPIO
 	select HAVE_TCM
 	select NO_IOPORT
 	select SPARSE_IRQ

arch/arm/mach-vt8500/Kconfig +0 -1

index 2ed0b7d..8464497 100644
@@ -6,7 +6,6 @@ config ARCH_VT8500
 	select CLKDEV_LOOKUP
 	select CPU_ARM926T
 	select GENERIC_CLOCKEVENTS
-	select GENERIC_GPIO
 	select HAVE_CLK
 	help
 	  Support for VIA/WonderMedia VT8500/WM85xx System-on-Chip.

Signature · 1 line

1.7.9.5

Linus Walleij

2013-01-17 13:36 UTC #1 lore raw

PATCH 1/1 ARM: remove unnecessary 'select GENERIC_GPIO'

Quoted 5 lines · Shawn Guo

The only use of GENERIC_GPIO (defined by architecture) in GPIO subsystem is being selected by GPIOLIB. Also there are no any use of the option at architecture level. Only two sub-architectures shmobile and orion really use the option as below.

Quoted 7 lines

  arch/arm/mach-shmobile/Makefile:obj-$(CONFIG_GENERIC_GPIO)      += $(pfc-y)
  arch/arm/plat-orion/Makefile:orion-gpio-$(CONFIG_GENERIC_GPIO) += gpio.o
Remove all those unnecessary sub-architecture level selection of GENERIC_GPIO, which are there only for confusing people.
Signed-off-by Shawn Guo <[email protected]>

Acked-by Linus Walleij <[email protected]>

Yours,
Linus Walleij

Shawn Guo

author

2013-01-17 14:18 UTC #2 lore raw

PATCH 1/1 ARM: remove unnecessary 'select GENERIC_GPIO'

Quoted 10 lines · Linus Walleij

Quoted 8 lines · Shawn Guo
The only use of GENERIC_GPIO (defined by architecture) in GPIO subsystem is being selected by GPIOLIB. Also there are no any use of the option at architecture level. Only two sub-architectures shmobile and orion really use the option as below.
  arch/arm/mach-shmobile/Makefile:obj-$(CONFIG_GENERIC_GPIO)      += $(pfc-y)
  arch/arm/plat-orion/Makefile:orion-gpio-$(CONFIG_GENERIC_GPIO) += gpio.o

Quoted 7 lines

Quoted 4 lines
Remove all those unnecessary sub-architecture level selection of GENERIC_GPIO, which are there only for confusing people.
Signed-off-by Shawn Guo <[email protected]>
Acked-by Linus Walleij <[email protected]>

Thanks, Linus.

Arnd, Olof,

Can you please take a look at the patch, and apply it as a cleanup if it looks good to you?

Shawn

Shawn Guo

author

2013-01-18 07:33 UTC #3 lore raw

PATCH 1/1 ARM: remove unnecessary 'select GENERIC_GPIO'

Quoted 16 lines · Shawn Guo

Quoted 15 lines · Linus Walleij
Quoted 12 lines · Shawn Guo
The only use of GENERIC_GPIO (defined by architecture) in GPIO subsystem is being selected by GPIOLIB. Also there are no any use of the option at architecture level. Only two sub-architectures shmobile and orion really use the option as below.
  arch/arm/mach-shmobile/Makefile:obj-$(CONFIG_GENERIC_GPIO)      += $(pfc-y)
  arch/arm/plat-orion/Makefile:orion-gpio-$(CONFIG_GENERIC_GPIO) += gpio.o
Remove all those unnecessary sub-architecture level selection of GENERIC_GPIO, which are there only for confusing people.
Signed-off-by Shawn Guo <[email protected]>

Quoted 9 lines

Quoted 2 lines
Acked-by Linus Walleij <[email protected]>
Thanks, Linus.
Arnd, Olof,
Can you please take a look at the patch, and apply it as a cleanup if it looks good to you?

The commit log does not look quite good. Will resend the patch with a better commit log.

Shawn

Grant Likely

2013-01-18 10:54 UTC #4 lore raw

PATCH 1/1 ARM: remove unnecessary 'select GENERIC_GPIO'

In reply to Linus Walleij

Quoted 10 lines · Linus Walleij

Quoted 8 lines · Shawn Guo
The only use of GENERIC_GPIO (defined by architecture) in GPIO subsystem is being selected by GPIOLIB. Also there are no any use of the option at architecture level. Only two sub-architectures shmobile and orion really use the option as below.
  arch/arm/mach-shmobile/Makefile:obj-$(CONFIG_GENERIC_GPIO)      += $(pfc-y)
  arch/arm/plat-orion/Makefile:orion-gpio-$(CONFIG_GENERIC_GPIO) += gpio.o

Quoted 6 lines

Quoted 4 lines
Remove all those unnecessary sub-architecture level selection of GENERIC_GPIO, which are there only for confusing people.
Signed-off-by Shawn Guo <[email protected]>
Acked-by Linus Walleij <[email protected]>

Looks good to me also.

Acked-by Grant Likely <[email protected]>