Skip to contentSkip to conversation

ppc patch queue 2013-01-18 for 3.8

GIT PULL New Alexander Graf 5 participants 10 messages Jan 17, 2013 – Jan 24, 2013

Subsystems (4)
Stable branch KVM PowerPC KVM PowerPC
lore
Share & tools
lore

Alexander Graf

author
#0 lore raw

Hi Marcelo / Gleb,

This is my current patch queue for ppc against 3.8. Please pull.

It contains a bug fix for an issue that Ben Collins ran into, where a guest would just abort because it traps during an unknown instruction.

Alex

The following changes since commit dfdebc24837ed0a1d6ad73b108a10d3c88d1b6e8:
Linus Torvalds (1):

        Merge tag 'for-linus-v3.8-rc4' of git://oss.sgi.com/xfs/xfs

are available in the git repository at:

git://github.com/agraf/linux-2.6.git kvm-ppc-3.8

Alexander Graf (1):
KVM: PPC: Emulate dcbf

 arch/powerpc/kvm/emulate.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
author
#1 lore raw

PATCH 1/1 KVM: PPC: Emulate dcbf

Guests can trigger MMIO exits using dcbf. Since we don't emulate cache incoherent MMIO, just do nothing and move on.

Reported-by Ben Collins <[email protected]>
Signed-off-by Alexander Graf <[email protected]>
Tested-by Ben Collins <[email protected]>
CC [email protected]
---
 arch/powerpc/kvm/emulate.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/powerpc/kvm/emulate.c +2 -0
index b0855e5..9d9cddc 100644
@@ -39,6 +39,7 @@
 #define OP_31_XOP_TRAP      4
 #define OP_31_XOP_LWZX      23
 #define OP_31_XOP_TRAP_64   68
+#define OP_31_XOP_DCBF      86
 #define OP_31_XOP_LBZX      87
 #define OP_31_XOP_STWX      151
 #define OP_31_XOP_STBX      215

@@ -374,6 +375,7 @@ int kvmppc_emulate_instruction(struct kvm_run *run, struct kvm_vcpu *vcpu)
 			emulated = kvmppc_emulate_mtspr(vcpu, sprn, rs);
 			break;
 
+		case OP_31_XOP_DCBF:
 		case OP_31_XOP_DCBI:
 			/* Do nothing. The guest is performing dcbi because
 			 * hardware DMA is not snooped by the dcache, but
Signature · 1 line
1.6.0.2
#2 lore raw
In reply to Alexander Graf
Quoted 7 lines · Alexander Graf

Hi Marcelo / Gleb,

This is my current patch queue for ppc against 3.8. Please pull.

It contains a bug fix for an issue that Ben Collins ran into, where a guest would just abort because it traps during an unknown instruction.

Is this regression from 3.7? If it is not it should wait for 3.9.

Quoted 14 lines

Alex

The following changes since commit dfdebc24837ed0a1d6ad73b108a10d3c88d1b6e8:
Linus Torvalds (1):

        Merge tag 'for-linus-v3.8-rc4' of git://oss.sgi.com/xfs/xfs

are available in the git repository at:

git://github.com/agraf/linux-2.6.git kvm-ppc-3.8

Alexander Graf (1):
KVM: PPC: Emulate dcbf

Quoted 6 lines
 arch/powerpc/kvm/emulate.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Gleb.

author
#3 lore raw
Quoted 9 lines · Gleb Natapov
Quoted 7 lines · Alexander Graf

Hi Marcelo / Gleb,

This is my current patch queue for ppc against 3.8. Please pull.

It contains a bug fix for an issue that Ben Collins ran into, where a guest would just abort because it traps during an unknown instruction.

Is this regression from 3.7? If it is not it should wait for 3.9.

The first time I heard of this was with a 3.8 guest. But we can also wait for 3.9 and push it through stable afterwards.

Alex

#4 lore raw
Quoted 6 lines · Alexander Graf
Quoted 3 lines · Gleb Natapov
Quoted 2 lines · Alexander Graf

Hi Marcelo / Gleb,

Quoted 8 lines
Quoted 6 lines
Quoted 5 lines

This is my current patch queue for ppc against 3.8. Please pull.

It contains a bug fix for an issue that Ben Collins ran into, where a guest would just abort because it traps during an unknown instruction.

Is this regression from 3.7? If it is not it should wait for 3.9.

The first time I heard of this was with a 3.8 guest. But we can also wait for 3.9 and push it through stable afterwards.

It's such a simple change, what is the issue with including it? If the bug is hit, qemu/kvm exits anyway, so adding the patch can't do any damage.

--
Ben Collins - Principal Architect
Servergy, Inc. - www.servergy.com

#5 lore raw
Quoted 10 lines · Ben Collins
Quoted 8 lines · Alexander Graf
Quoted 5 lines · Gleb Natapov
Quoted 4 lines · Alexander Graf

Hi Marcelo / Gleb,

This is my current patch queue for ppc against 3.8. Please pull.

Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 3 lines

It contains a bug fix for an issue that Ben Collins ran into, where a guest would just abort because it traps during an unknown instruction.

Is this regression from 3.7? If it is not it should wait for 3.9.

The first time I heard of this was with a 3.8 guest. But we can also wait for 3.9 and push it through stable afterwards.

It's such a simple change, what is the issue with including it? If the bug is hit, qemu/kvm exits anyway, so adding the patch can't do any damage.

If we continue pushing simple changes that can't do any damage to late -rc trees 3.8 will never be ready to released. The patch can go to stable after 3.8 is released. Again if this is indeed regression this another matter.

--
Gleb.

#6 lore raw
Quoted 16 lines · Gleb Natapov
Quoted 15 lines · Ben Collins
Quoted 13 lines · Alexander Graf
Quoted 9 lines · Gleb Natapov
Quoted 7 lines · Alexander Graf

Hi Marcelo / Gleb,

This is my current patch queue for ppc against 3.8. Please pull.

It contains a bug fix for an issue that Ben Collins ran into, where a guest would just abort because it traps during an unknown instruction.

Is this regression from 3.7? If it is not it should wait for 3.9.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

The first time I heard of this was with a 3.8 guest. But we can also wait for 3.9 and push it through stable afterwards.

It's such a simple change, what is the issue with including it? If the bug is hit, qemu/kvm exits anyway, so adding the patch can't do any damage.

If we continue pushing simple changes that can't do any damage to late -rc trees 3.8 will never be ready to released. The patch can go to stable after 3.8 is released. Again if this is indeed regression this another matter.

It's indeed a regression for me. Where as QEmu used to work, now it doesn't. The regression appears to only occur when running 3.8 kernel in guest, which means the only way to run a 3.8 kernel in guest is with this patch.

--
Servergy : http://www.servergy.com/
SwissDisk : http://www.swissdisk.com/
Ubuntu : http://www.ubuntu.com/
My Blog : http://ben-collins.blogspot.com/

#7 lore raw
In reply to Alexander Graf
Quoted 16 lines · Alexander Graf

Hi Marcelo / Gleb,

This is my current patch queue for ppc against 3.8. Please pull.

It contains a bug fix for an issue that Ben Collins ran into, where a guest would just abort because it traps during an unknown instruction.

Alex

The following changes since commit dfdebc24837ed0a1d6ad73b108a10d3c88d1b6e8:
Linus Torvalds (1):

        Merge tag 'for-linus-v3.8-rc4' of git://oss.sgi.com/xfs/xfs

are available in the git repository at:

Quoted 7 lines

git://github.com/agraf/linux-2.6.git kvm-ppc-3.8

Alexander Graf (1):
KVM: PPC: Emulate dcbf

 arch/powerpc/kvm/emulate.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Pulled, thanks.

author
#8 lore raw
Quoted 19 lines · Marcelo Tosatti
Quoted 18 lines · Alexander Graf

Hi Marcelo / Gleb,

This is my current patch queue for ppc against 3.8. Please pull.

It contains a bug fix for an issue that Ben Collins ran into, where a guest would just abort because it traps during an unknown instruction.

Alex

The following changes since commit dfdebc24837ed0a1d6ad73b108a10d3c88d1b6e8:
Linus Torvalds (1):

       Merge tag 'for-linus-v3.8-rc4' of git://oss.sgi.com/xfs/xfs

are available in the git repository at:

git://github.com/agraf/linux-2.6.git kvm-ppc-3.8

Quoted 7 lines
Quoted 5 lines

Alexander Graf (1):
KVM: PPC: Emulate dcbf

arch/powerpc/kvm/emulate.c | 2 ++

1 files changed, 2 insertions(+), 0 deletions(-)

Pulled, thanks.

Into which queue? kvm.git doesn't contain it anywhere.

Alex

#9 lore raw
Quoted 25 lines · Alexander Graf
Quoted 22 lines · Marcelo Tosatti
Quoted 21 lines · Alexander Graf

Hi Marcelo / Gleb,

This is my current patch queue for ppc against 3.8. Please pull.

It contains a bug fix for an issue that Ben Collins ran into, where a guest would just abort because it traps during an unknown instruction.

Alex

The following changes since commit dfdebc24837ed0a1d6ad73b108a10d3c88d1b6e8:
Linus Torvalds (1):

       Merge tag 'for-linus-v3.8-rc4' of git://oss.sgi.com/xfs/xfs

are available in the git repository at:

git://github.com/agraf/linux-2.6.git kvm-ppc-3.8

Alexander Graf (1):
KVM: PPC: Emulate dcbf

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

arch/powerpc/kvm/emulate.c | 2 ++

1 files changed, 2 insertions(+), 0 deletions(-)

Pulled, thanks.

Into which queue? kvm.git doesn't contain it anywhere.

master.

--
Gleb.